* [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
@ 2018-10-26 9:32 Biju Das
2018-10-26 9:32 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support Biju Das
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Biju Das @ 2018-10-26 9:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
This patch adds watchdog support to the r8a77470 SoC dtsi.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch tested against renesas-dev
---
arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index e40f5a9..872ad3a 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -196,6 +196,16 @@
reg = <0 0xe6160000 0 0x100>;
};
+ rwdt: watchdog@e6020000 {
+ compatible = "renesas,r8a77470-wdt",
+ "renesas,rcar-gen2-wdt";
+ reg = <0 0xe6020000 0 0x0c>;
+ clocks = <&cpg CPG_MOD 402>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 402>;
+ status = "disabled";
+ };
+
sysc: system-controller@e6180000 {
compatible = "renesas,r8a77470-sysc";
reg = <0 0xe6180000 0 0x200>;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
2018-10-26 9:32 [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Biju Das
@ 2018-10-26 9:32 ` Biju Das
2018-10-26 9:42 ` Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-11-06 10:18 ` Geert Uytterhoeven
2 siblings, 1 reply; 10+ messages in thread
From: Biju Das @ 2018-10-26 9:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
This patch enables watchdog support on the iWave iwg23s sbc.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 6277571..bc953fa 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -128,6 +128,11 @@
};
};
+&rwdt {
+ timeout-sec = <60>;
+ status = "okay";
+};
+
&scif1 {
pinctrl-0 = <&scif1_pins>;
pinctrl-names = "default";
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
2018-10-26 9:32 [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Biju Das
@ 2018-10-26 9:42 ` Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-11-06 10:18 ` Geert Uytterhoeven
2 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26 9:42 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland
Cc: Simon Horman, Magnus Damm, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson
> Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
>
> This patch adds watchdog support to the r8a77470 SoC dtsi.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> This patch tested against renesas-dev
> ---
> arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index e40f5a9..872ad3a 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -196,6 +196,16 @@
> reg = <0 0xe6160000 0 0x100>;
> };
>
> +rwdt: watchdog@e6020000 {
> +compatible = "renesas,r8a77470-wdt",
> + "renesas,rcar-gen2-wdt";
> +reg = <0 0xe6020000 0 0x0c>;
> +clocks = <&cpg CPG_MOD 402>;
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 402>;
> +status = "disabled";
> +};
> +
> sysc: system-controller@e6180000 {
> compatible = "renesas,r8a77470-sysc";
> reg = <0 0xe6180000 0 0x200>;
> --
> 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
@ 2018-10-26 9:42 ` Fabrizio Castro
0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26 9:42 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson
> Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
>
> This patch adds watchdog support to the r8a77470 SoC dtsi.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> This patch tested against renesas-dev
> ---
> arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index e40f5a9..872ad3a 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -196,6 +196,16 @@
> reg = <0 0xe6160000 0 0x100>;
> };
>
> +rwdt: watchdog@e6020000 {
> +compatible = "renesas,r8a77470-wdt",
> + "renesas,rcar-gen2-wdt";
> +reg = <0 0xe6020000 0 0x0c>;
> +clocks = <&cpg CPG_MOD 402>;
> +power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +resets = <&cpg 402>;
> +status = "disabled";
> +};
> +
> sysc: system-controller@e6180000 {
> compatible = "renesas,r8a77470-sysc";
> reg = <0 0xe6180000 0 0x200>;
> --
> 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
2018-10-26 9:32 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support Biju Das
@ 2018-10-26 9:42 ` Fabrizio Castro
0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26 9:42 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland
Cc: Simon Horman, Magnus Damm, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson
> Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
>
> This patch enables watchdog support on the iWave iwg23s sbc.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 6277571..bc953fa 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -128,6 +128,11 @@
> };
> };
>
> +&rwdt {
> +timeout-sec = <60>;
> +status = "okay";
> +};
> +
> &scif1 {
> pinctrl-0 = <&scif1_pins>;
> pinctrl-names = "default";
> --
> 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
@ 2018-10-26 9:42 ` Fabrizio Castro
0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-10-26 9:42 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson
> Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
>
> This patch enables watchdog support on the iWave iwg23s sbc.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 6277571..bc953fa 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -128,6 +128,11 @@
> };
> };
>
> +&rwdt {
> +timeout-sec = <60>;
> +status = "okay";
> +};
> +
> &scif1 {
> pinctrl-0 = <&scif1_pins>;
> pinctrl-names = "default";
> --
> 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
2018-10-26 9:42 ` Fabrizio Castro
(?)
@ 2018-10-29 16:13 ` Simon Horman
-1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-10-29 16:13 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson
On Fri, Oct 26, 2018 at 09:42:38AM +0000, Fabrizio Castro wrote:
> > Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
> >
> > This patch adds watchdog support to the r8a77470 SoC dtsi.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thanks, applied for v4.21.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
2018-10-26 9:42 ` Fabrizio Castro
(?)
@ 2018-10-29 16:14 ` Simon Horman
-1 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-10-29 16:14 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Geert Uytterhoeven,
Chris Paterson
On Fri, Oct 26, 2018 at 09:42:40AM +0000, Fabrizio Castro wrote:
> > Subject: [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support
> >
> > This patch enables watchdog support on the iWave iwg23s sbc.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thanks, applied for v4.21.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
2018-10-26 9:32 [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Biju Das
2018-10-26 9:32 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support Biju Das
2018-10-26 9:42 ` Fabrizio Castro
@ 2018-11-06 10:18 ` Geert Uytterhoeven
2018-11-06 12:25 ` Simon Horman
2 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-11-06 10:18 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Simon Horman, Magnus Damm,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hi Biju,
On Fri, Oct 26, 2018 at 11:40 AM Biju Das <biju.das@bp.renesas.com> wrote:
> This patch adds watchdog support to the r8a77470 SoC dtsi.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -196,6 +196,16 @@
> reg = <0 0xe6160000 0 0x100>;
> };
>
> + rwdt: watchdog@e6020000 {
Please follow the sort order rules:
- By unit-address (if present), per group,
- Alphabetically.
> + compatible = "renesas,r8a77470-wdt",
> + "renesas,rcar-gen2-wdt";
> + reg = <0 0xe6020000 0 0x0c>;
> + clocks = <&cpg CPG_MOD 402>;
> + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> + resets = <&cpg 402>;
> + status = "disabled";
> + };
> +
> sysc: system-controller@e6180000 {
> compatible = "renesas,r8a77470-sysc";
> reg = <0 0xe6180000 0 0x200>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
2018-11-06 10:18 ` Geert Uytterhoeven
@ 2018-11-06 12:25 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-11-06 12:25 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Rob Herring, Mark Rutland, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Nov 06, 2018 at 11:18:14AM +0100, Geert Uytterhoeven wrote:
> Hi Biju,
>
> On Fri, Oct 26, 2018 at 11:40 AM Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch adds watchdog support to the r8a77470 SoC dtsi.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a77470.dtsi
> > +++ b/arch/arm/boot/dts/r8a77470.dtsi
> > @@ -196,6 +196,16 @@
> > reg = <0 0xe6160000 0 0x100>;
> > };
> >
> > + rwdt: watchdog@e6020000 {
>
> Please follow the sort order rules:
> - By unit-address (if present), per group,
> - Alphabetically.
Thanks for noticing.
As I had already applied this patch I took the liberty of updating
it to preserve node sort order. The updates patch is as follows:
From: Biju Das <biju.das@bp.renesas.com>
Date: Fri, 26 Oct 2018 10:32:26 +0100
Subject: [PATCH] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
This patch adds watchdog support to the r8a77470 SoC dtsi.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
[simon: moved node to preserve sort order]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 6ac7f467065e..a703b74cc1f9 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -79,6 +79,16 @@
#size-cells = <2>;
ranges;
+ rwdt: watchdog@e6020000 {
+ compatible = "renesas,r8a77470-wdt",
+ "renesas,rcar-gen2-wdt";
+ reg = <0 0xe6020000 0 0x0c>;
+ clocks = <&cpg CPG_MOD 402>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 402>;
+ status = "disabled";
+ };
+
gpio0: gpio@e6050000 {
compatible = "renesas,gpio-r8a77470",
"renesas,rcar-gen2-gpio";
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-11-06 12:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 9:32 [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Biju Das
2018-10-26 9:32 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support Biju Das
2018-10-26 9:42 ` Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-10-29 16:14 ` Simon Horman
2018-10-26 9:42 ` [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-10-29 16:13 ` Simon Horman
2018-11-06 10:18 ` Geert Uytterhoeven
2018-11-06 12:25 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.