All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100
@ 2018-10-30 14:55 Adam Ford
  2018-10-30 16:33 ` Fabio Estevam
  2018-11-06 17:26 ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: Adam Ford @ 2018-10-30 14:55 UTC (permalink / raw)
  To: linux-arm-kernel

The driver currently supports coin cell / super cap charging, so
this patch extends it to support PF0100.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Rebase from correct branch.
V1:  Ooops, sorry about the noise.

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index dd41a9bb3f5c..df5df1c495ad 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -370,6 +370,7 @@ static struct pfuze_regulator pfuze100_regulators[] = {
 	PFUZE100_VGEN_REG(PFUZE100, VGEN4, PFUZE100_VGEN4VOL, 1800000, 3300000, 100000),
 	PFUZE100_VGEN_REG(PFUZE100, VGEN5, PFUZE100_VGEN5VOL, 1800000, 3300000, 100000),
 	PFUZE100_VGEN_REG(PFUZE100, VGEN6, PFUZE100_VGEN6VOL, 1800000, 3300000, 100000),
+	PFUZE100_COIN_REG(PFUZE100, COIN, PFUZE100_COINVOL, 0x7, pfuze100_coin),
 };
 
 static struct pfuze_regulator pfuze200_regulators[] = {
@@ -436,6 +437,7 @@ static struct of_regulator_match pfuze100_matches[] = {
 	{ .name = "vgen4",	},
 	{ .name = "vgen5",	},
 	{ .name = "vgen6",	},
+	{ .name = "coin",	},
 };
 
 /* PFUZE200 */
diff --git a/include/linux/regulator/pfuze100.h b/include/linux/regulator/pfuze100.h
index cb5aecd40f07..331d7d940c7a 100644
--- a/include/linux/regulator/pfuze100.h
+++ b/include/linux/regulator/pfuze100.h
@@ -33,7 +33,8 @@
 #define PFUZE100_VGEN4		12
 #define PFUZE100_VGEN5		13
 #define PFUZE100_VGEN6		14
-#define PFUZE100_MAX_REGULATOR	15
+#define PFUZE100_COIN		15
+#define PFUZE100_MAX_REGULATOR	16
 
 #define PFUZE200_SW1AB		0
 #define PFUZE200_SW2		1
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100
  2018-10-30 14:55 [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100 Adam Ford
@ 2018-10-30 16:33 ` Fabio Estevam
  2018-11-06 17:26 ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-10-30 16:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Oct 30, 2018 at 1:10 PM Adam Ford <aford173@gmail.com> wrote:
>
> The driver currently supports coin cell / super cap charging, so
> this patch extends it to support PF0100.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100
  2018-10-30 14:55 [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100 Adam Ford
  2018-10-30 16:33 ` Fabio Estevam
@ 2018-11-06 17:26 ` Mark Brown
  2018-11-06 17:58   ` Adam Ford
  1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2018-11-06 17:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Oct 30, 2018 at 09:55:07AM -0500, Adam Ford wrote:
> The driver currently supports coin cell / super cap charging, so
> this patch extends it to support PF0100.

You need to send patches to the relevant mailing lists, this provides an
archive of the review that happens and allows people other than the
reviewers you name to look at the patches.  Please see SubmittingPatches
for details of the patch submission process.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181106/98f3c093/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100
  2018-11-06 17:26 ` Mark Brown
@ 2018-11-06 17:58   ` Adam Ford
  2018-11-06 18:14     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Adam Ford @ 2018-11-06 17:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 6, 2018 at 11:26 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Oct 30, 2018 at 09:55:07AM -0500, Adam Ford wrote:
> > The driver currently supports coin cell / super cap charging, so
> > this patch extends it to support PF0100.
>
> You need to send patches to the relevant mailing lists, this provides an
> archive of the review that happens and allows people other than the
> reviewers you name to look at the patches.  Please see SubmittingPatches
> for details of the patch submission process.

Which mailing list list did I miss?  I normally scripts/get_maintainer
to generate the list from the patch.  It's quite possible I
fat-fingered something.

adam

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100
  2018-11-06 17:58   ` Adam Ford
@ 2018-11-06 18:14     ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-11-06 18:14 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 06, 2018 at 11:58:40AM -0600, Adam Ford wrote:
> On Tue, Nov 6, 2018 at 11:26 AM Mark Brown <broonie@kernel.org> wrote:

> > On Tue, Oct 30, 2018 at 09:55:07AM -0500, Adam Ford wrote:
> > > The driver currently supports coin cell / super cap charging, so
> > > this patch extends it to support PF0100.

> > You need to send patches to the relevant mailing lists, this provides an
> > archive of the review that happens and allows people other than the
> > reviewers you name to look at the patches.  Please see SubmittingPatches
> > for details of the patch submission process.

> Which mailing list list did I miss?  I normally scripts/get_maintainer
> to generate the list from the patch.  It's quite possible I
> fat-fingered something.

linux-kernel is the list for regulator patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181106/6253c222/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-11-06 18:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 14:55 [PATCH V2] regulator: pfuze100-regulator: add coin support to PF0100 Adam Ford
2018-10-30 16:33 ` Fabio Estevam
2018-11-06 17:26 ` Mark Brown
2018-11-06 17:58   ` Adam Ford
2018-11-06 18:14     ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.