All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf script: add newline after uregs output
@ 2018-11-07  9:37 Milian Wolff
  2018-11-07 14:25 ` Arnaldo Carvalho de Melo
  2018-11-22  7:08 ` [tip:perf/core] perf script: Add " tip-bot for Milian Wolff
  0 siblings, 2 replies; 3+ messages in thread
From: Milian Wolff @ 2018-11-07  9:37 UTC (permalink / raw)
  To: acme, jolsa; +Cc: Linux-kernel, linux-perf-users, Milian Wolff

This change makes it much easier to easily distinguish
between consecutive samples by keeping the empty line
between them, like we see when we do not enable uregs
output.

Before:

```
cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
            7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...
cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
            7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...
```

After:

```
cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
            7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...

cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
            7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
            ...
 ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...
```

Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
---
 tools/perf/builtin-script.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index b5bc85bd0bbe..daf73832743e 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -603,6 +603,8 @@ static int perf_sample__fprintf_uregs(struct perf_sample *sample,
 		printed += fprintf(fp, "%5s:0x%"PRIx64" ", perf_reg_name(r), val);
 	}
 
+	fprintf(fp, "\n");
+
 	return printed;
 }
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] perf script: add newline after uregs output
  2018-11-07  9:37 [PATCH] perf script: add newline after uregs output Milian Wolff
@ 2018-11-07 14:25 ` Arnaldo Carvalho de Melo
  2018-11-22  7:08 ` [tip:perf/core] perf script: Add " tip-bot for Milian Wolff
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-11-07 14:25 UTC (permalink / raw)
  To: Milian Wolff; +Cc: jolsa, Linux-kernel, linux-perf-users

Em Wed, Nov 07, 2018 at 10:37:05AM +0100, Milian Wolff escreveu:
> This change makes it much easier to easily distinguish
> between consecutive samples by keeping the empty line
> between them, like we see when we do not enable uregs
> output.

Thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip:perf/core] perf script: Add newline after uregs output
  2018-11-07  9:37 [PATCH] perf script: add newline after uregs output Milian Wolff
  2018-11-07 14:25 ` Arnaldo Carvalho de Melo
@ 2018-11-22  7:08 ` tip-bot for Milian Wolff
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Milian Wolff @ 2018-11-22  7:08 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: milian.wolff, hpa, jolsa, tglx, acme, linux-kernel, mingo

Commit-ID:  b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Gitweb:     https://git.kernel.org/tip/b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Author:     Milian Wolff <milian.wolff@kdab.com>
AuthorDate: Wed, 7 Nov 2018 10:37:05 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 21 Nov 2018 12:00:31 -0300

perf script: Add newline after uregs output

This change makes it much easier to easily distinguish between
consecutive samples by keeping the empty line between them, like we see
when we do not enable uregs output.

Before:

  cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
              7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
              ...
   ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...
  cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
              7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
              ...
   ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...

After:

  cpp-inlining 28298 [-01] 54837.342780:    3068085 cycles:pp:
              7ffff7c96709 __hypot_finite+0xa9 (/usr/lib/libm-2.28.so)
              ...
   ABI:2    AX:0x0    BX:0x40f56cf6    CX:0x294a3ae7    ...

  cpp-inlining 28298 [-01] 54837.344493:    2881929 cycles:pp:
              7ffff7c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
              ...
   ABI:2    AX:0x40d440c7    BX:0x40d440c7    CX:0x4d45e5da    ...

Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20181107093705.16346-1-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-script.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index b5bc85bd0bbe..daf73832743e 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -603,6 +603,8 @@ static int perf_sample__fprintf_uregs(struct perf_sample *sample,
 		printed += fprintf(fp, "%5s:0x%"PRIx64" ", perf_reg_name(r), val);
 	}
 
+	fprintf(fp, "\n");
+
 	return printed;
 }
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-22  7:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07  9:37 [PATCH] perf script: add newline after uregs output Milian Wolff
2018-11-07 14:25 ` Arnaldo Carvalho de Melo
2018-11-22  7:08 ` [tip:perf/core] perf script: Add " tip-bot for Milian Wolff

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.