From: Wei Liu <wei.liu2@citrix.com>
To: Sergey Dyasli <sergey.dyasli@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org, Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v3] mm/page_alloc: make bootscrub happen in idle-loop
Date: Wed, 7 Nov 2018 16:42:36 +0000 [thread overview]
Message-ID: <20181107164236.v6cmkenup2hlp7r4@zion.uk.xensource.com> (raw)
In-Reply-To: <ecab96b1-c620-fe41-6843-a9a6e0d9a6cc@citrix.com>
On Wed, Nov 07, 2018 at 04:36:08PM +0000, Sergey Dyasli wrote:
> On 07/11/2018 12:17, Wei Liu wrote:
> > On Wed, Nov 07, 2018 at 11:11:49AM +0000, Sergey Dyasli wrote:
> >> Scrubbing RAM during boot may take a long time on machines with lots
> >> of RAM. Add 'idle' option to bootscrub which marks all pages dirty
> >> initially so they will eventually be scrubbed in idle-loop on every
> >> online CPU.
> >>
> >> It's guaranteed that the allocator will return scrubbed pages by doing
> >> eager scrubbing during allocation (unless MEMF_no_scrub was provided).
> >>
> >> Use the new 'idle' option as the default one.
> >>
> >> Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
> >> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> v2 --> v3:
> >> - Removed "= 0" from enum bootscrub_mode
> >> - Removed num_online_nodes() from printk()
> >> - Added Reviewed-by
> >
> > I think your patch (v2?) is already committed.
>
> Hmm, you are right: CommitDate: Wed Nov 7 09:34:17 2018 +0100
> Sorry, I wasn't expecting that.
>
> Though printk() in the committed version has a typo:
>
> printk("Scrubbing free RAM on in background\n");
> ^^
Feel free to send a followup patch to fix that.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-11-07 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 11:11 [PATCH v3] mm/page_alloc: make bootscrub happen in idle-loop Sergey Dyasli
2018-11-07 12:17 ` Wei Liu
2018-11-07 16:36 ` Sergey Dyasli
2018-11-07 16:42 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107164236.v6cmkenup2hlp7r4@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sergey.dyasli@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.