Re: [PATCH v3] mm/page_alloc: make bootscrub happen in idle-loop

From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Julien Grall <julien.grall@arm.com>,
	"sergey.dyasli@citrix.com >> Sergey Dyasli"
	<sergey.dyasli@citrix.com>
Subject: Re: [PATCH v3] mm/page_alloc: make bootscrub happen in idle-loop
Date: Wed, 7 Nov 2018 16:36:08 +0000	[thread overview]
Message-ID: <ecab96b1-c620-fe41-6843-a9a6e0d9a6cc@citrix.com> (raw)
In-Reply-To: <20181107121714.q65fte6newwxcx2t@zion.uk.xensource.com>

On 07/11/2018 12:17, Wei Liu wrote:
> On Wed, Nov 07, 2018 at 11:11:49AM +0000, Sergey Dyasli wrote:
>> Scrubbing RAM during boot may take a long time on machines with lots
>> of RAM. Add 'idle' option to bootscrub which marks all pages dirty
>> initially so they will eventually be scrubbed in idle-loop on every
>> online CPU.
>>
>> It's guaranteed that the allocator will return scrubbed pages by doing
>> eager scrubbing during allocation (unless MEMF_no_scrub was provided).
>>
>> Use the new 'idle' option as the default one.
>>
>> Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2 --> v3:
>> - Removed "= 0" from enum bootscrub_mode
>> - Removed num_online_nodes() from printk()
>> - Added Reviewed-by
> 
> I think your patch (v2?) is already committed.

Hmm, you are right: CommitDate: Wed Nov 7 09:34:17 2018 +0100
Sorry, I wasn't expecting that.

Though printk() in the committed version has a typo:

    printk("Scrubbing free RAM on in background\n");
                               ^^

--
Thanks,
Sergey

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel