All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: cpufreq: remove stale arm_big_little_dt entry
@ 2018-11-07 17:40 Sudeep Holla
  2018-11-08  4:45 ` Viresh Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: Sudeep Holla @ 2018-11-07 17:40 UTC (permalink / raw)
  To: linux-pm, devicetree
  Cc: Sudeep Holla, Rafael J. Wysocki, Viresh Kumar, Rob Herring

Most of the ARM platforms used v2 OPP bindings to support big-little
configurations. This arm_big_little_dt binding is incomplete and was
never used.

Commit f174e49e4906 ("cpufreq: remove unused arm_big_little_dt driver")
removes the driver supporting this binding. However the binding was left
unnoticed, so let's get rid of it now.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 .../bindings/cpufreq/arm_big_little_dt.txt    | 65 -------------------
 1 file changed, 65 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt

Hi,

For some reason, I didn't expect the driver to have an entry in the
DT bindings and didn't look at it before. While I was searching references
to big-little that can be removed, I spotted this. Sorry for that.

Regards,
Sudeep

diff --git a/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt b/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
deleted file mode 100644
index 2aa06ac0fac5..000000000000
--- a/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
+++ /dev/null
@@ -1,65 +0,0 @@
-Generic ARM big LITTLE cpufreq driver's DT glue
------------------------------------------------
-
-This is DT specific glue layer for generic cpufreq driver for big LITTLE
-systems.
-
-Both required and optional properties listed below must be defined
-under node /cpus/cpu@x. Where x is the first cpu inside a cluster.
-
-FIXME: Cpus should boot in the order specified in DT and all cpus for a cluster
-must be present contiguously. Generic DT driver will check only node 'x' for
-cpu:x.
-
-Required properties:
-- operating-points: Refer to Documentation/devicetree/bindings/opp/opp.txt
-  for details
-
-Optional properties:
-- clock-latency: Specify the possible maximum transition latency for clock,
-  in unit of nanoseconds.
-
-Examples:
-
-cpus {
-	#address-cells = <1>;
-	#size-cells = <0>;
-
-	cpu@0 {
-		compatible = "arm,cortex-a15";
-		reg = <0>;
-		next-level-cache = <&L2>;
-		operating-points = <
-			/* kHz    uV */
-			792000  1100000
-			396000  950000
-			198000  850000
-		>;
-		clock-latency = <61036>; /* two CLK32 periods */
-	};
-
-	cpu@1 {
-		compatible = "arm,cortex-a15";
-		reg = <1>;
-		next-level-cache = <&L2>;
-	};
-
-	cpu@100 {
-		compatible = "arm,cortex-a7";
-		reg = <100>;
-		next-level-cache = <&L2>;
-		operating-points = <
-			/* kHz    uV */
-			792000  950000
-			396000  750000
-			198000  450000
-		>;
-		clock-latency = <61036>; /* two CLK32 periods */
-	};
-
-	cpu@101 {
-		compatible = "arm,cortex-a7";
-		reg = <101>;
-		next-level-cache = <&L2>;
-	};
-};
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: cpufreq: remove stale arm_big_little_dt entry
  2018-11-07 17:40 [PATCH] dt-bindings: cpufreq: remove stale arm_big_little_dt entry Sudeep Holla
@ 2018-11-08  4:45 ` Viresh Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2018-11-08  4:45 UTC (permalink / raw)
  To: Sudeep Holla; +Cc: linux-pm, devicetree, Rafael J. Wysocki, Rob Herring

On 07-11-18, 17:40, Sudeep Holla wrote:
> Most of the ARM platforms used v2 OPP bindings to support big-little
> configurations. This arm_big_little_dt binding is incomplete and was
> never used.
> 
> Commit f174e49e4906 ("cpufreq: remove unused arm_big_little_dt driver")
> removes the driver supporting this binding. However the binding was left
> unnoticed, so let's get rid of it now.
> 
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  .../bindings/cpufreq/arm_big_little_dt.txt    | 65 -------------------
>  1 file changed, 65 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
> 
> Hi,
> 
> For some reason, I didn't expect the driver to have an entry in the
> DT bindings and didn't look at it before. While I was searching references
> to big-little that can be removed, I spotted this. Sorry for that.
> 
> Regards,
> Sudeep
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt b/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
> deleted file mode 100644
> index 2aa06ac0fac5..000000000000
> --- a/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
> +++ /dev/null
> @@ -1,65 +0,0 @@
> -Generic ARM big LITTLE cpufreq driver's DT glue
> ------------------------------------------------
> -
> -This is DT specific glue layer for generic cpufreq driver for big LITTLE
> -systems.
> -
> -Both required and optional properties listed below must be defined
> -under node /cpus/cpu@x. Where x is the first cpu inside a cluster.
> -
> -FIXME: Cpus should boot in the order specified in DT and all cpus for a cluster
> -must be present contiguously. Generic DT driver will check only node 'x' for
> -cpu:x.
> -
> -Required properties:
> -- operating-points: Refer to Documentation/devicetree/bindings/opp/opp.txt
> -  for details
> -
> -Optional properties:
> -- clock-latency: Specify the possible maximum transition latency for clock,
> -  in unit of nanoseconds.
> -
> -Examples:
> -
> -cpus {
> -	#address-cells = <1>;
> -	#size-cells = <0>;
> -
> -	cpu@0 {
> -		compatible = "arm,cortex-a15";
> -		reg = <0>;
> -		next-level-cache = <&L2>;
> -		operating-points = <
> -			/* kHz    uV */
> -			792000  1100000
> -			396000  950000
> -			198000  850000
> -		>;
> -		clock-latency = <61036>; /* two CLK32 periods */
> -	};
> -
> -	cpu@1 {
> -		compatible = "arm,cortex-a15";
> -		reg = <1>;
> -		next-level-cache = <&L2>;
> -	};
> -
> -	cpu@100 {
> -		compatible = "arm,cortex-a7";
> -		reg = <100>;
> -		next-level-cache = <&L2>;
> -		operating-points = <
> -			/* kHz    uV */
> -			792000  950000
> -			396000  750000
> -			198000  450000
> -		>;
> -		clock-latency = <61036>; /* two CLK32 periods */
> -	};
> -
> -	cpu@101 {
> -		compatible = "arm,cortex-a7";
> -		reg = <101>;
> -		next-level-cache = <&L2>;
> -	};
> -};

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-08  4:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 17:40 [PATCH] dt-bindings: cpufreq: remove stale arm_big_little_dt entry Sudeep Holla
2018-11-08  4:45 ` Viresh Kumar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.