All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout
@ 2018-11-08 11:25 Lionel Landwerlin
  2018-11-08 12:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Lionel Landwerlin @ 2018-11-08 11:25 UTC (permalink / raw)
  To: igt-dev; +Cc: tvrtko.ursulin

Make availability of all elements more visible for debug purposes.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/query.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 08aabf94..3e7fd140 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -373,12 +373,20 @@ test_query_topology_matches_eu_total(int fd)
 	for (s = 0; s < topo_info->max_slices; s++) {
 		int ss;
 
-		igt_debug("slice%i:\n", s);
+		igt_debug("slice%i: (%s)\n", s,
+			  slice_available(topo_info, s) ? "available" : "fused");
+
+		if (!slice_available(topo_info, s))
+			continue;
 
 		for (ss = 0; ss < topo_info->max_subslices; ss++) {
 			int eu, n_subslice_eus = 0;
 
-			igt_debug("\tsubslice: %i\n", ss);
+			igt_debug("\tsubslice%i: (%s)\n", ss,
+				  subslice_available(topo_info, s, ss) ? "available" : "fused");
+
+			if (!subslice_available(topo_info, s, ss))
+				continue;
 
 			igt_debug("\t\teu_mask: 0b");
 			for (eu = 0; eu < topo_info->max_eus_per_subslice; eu++) {
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/query: more accurate available/fused topology printout
  2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
@ 2018-11-08 12:15 ` Patchwork
  2018-11-08 13:00 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-08 12:15 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

== Series Details ==

Series: tests/i915/query: more accurate available/fused topology printout
URL   : https://patchwork.freedesktop.org/series/52220/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4712 -> IGTPW_2049 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2049 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2049, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52220/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2049:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@module-reload:
      fi-kbl-7567u:       PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@drv_selftest@live_hangcheck:
      fi-icl-u:           SKIP -> PASS

    igt@pm_rpm@basic-rte:
      fi-kbl-7567u:       PASS -> SKIP +4

    
== Known issues ==

  Here are the changes found in IGTPW_2049 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-kbl-7567u:       PASS -> DMESG-WARN (fdo#105602) +1

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-kbl-7567u:       PASS -> DMESG-FAIL (fdo#105079)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_execlists:
      fi-icl-u:           INCOMPLETE (fdo#108315) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      FAIL (fdo#103841) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_contexts:
      fi-icl-u:           INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569


== Participating hosts (52 -> 45) ==

  Additional (1): fi-cnl-u 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-icl-u2 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4712 -> IGTPW_2049

  CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2049: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/
  IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/query: more accurate available/fused topology printout
  2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
  2018-11-08 12:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-11-08 13:00 ` Patchwork
  2018-11-08 15:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
  2018-11-08 20:22 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-08 13:00 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

== Series Details ==

Series: tests/i915/query: more accurate available/fused topology printout
URL   : https://patchwork.freedesktop.org/series/52220/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4712 -> IGTPW_2049 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_2049 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2049, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52220/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2049:

  === IGT changes ===

    ==== Warnings ====

    igt@drv_selftest@live_hangcheck:
      fi-icl-u:           SKIP -> PASS

    igt@pm_rpm@basic-rte:
      fi-kbl-7567u:       PASS -> SKIP +4

    
== Known issues ==

  Here are the changes found in IGTPW_2049 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-kbl-7567u:       PASS -> DMESG-WARN (fdo#105602) +1

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-kbl-7567u:       PASS -> DMESG-FAIL (fdo#105079)

    igt@pm_rpm@module-reload:
      fi-kbl-7567u:       PASS -> DMESG-WARN (fdo#108529)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_execlists:
      fi-icl-u:           INCOMPLETE (fdo#108315) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      FAIL (fdo#103841) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_contexts:
      fi-icl-u:           INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569)

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
  fdo#108529 https://bugs.freedesktop.org/show_bug.cgi?id=108529
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569


== Participating hosts (52 -> 45) ==

  Additional (1): fi-cnl-u 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-icl-u2 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4712 -> IGTPW_2049

  CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2049: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/
  IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout
  2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
  2018-11-08 12:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  2018-11-08 13:00 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-08 15:37 ` Tvrtko Ursulin
  2018-11-08 20:59   ` Lionel Landwerlin
  2018-11-08 20:22 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2018-11-08 15:37 UTC (permalink / raw)
  To: Lionel Landwerlin, igt-dev; +Cc: tvrtko.ursulin


On 08/11/2018 11:25, Lionel Landwerlin wrote:
> Make availability of all elements more visible for debug purposes.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>   tests/i915/query.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/query.c b/tests/i915/query.c
> index 08aabf94..3e7fd140 100644
> --- a/tests/i915/query.c
> +++ b/tests/i915/query.c
> @@ -373,12 +373,20 @@ test_query_topology_matches_eu_total(int fd)
>   	for (s = 0; s < topo_info->max_slices; s++) {
>   		int ss;
>   
> -		igt_debug("slice%i:\n", s);
> +		igt_debug("slice%i: (%s)\n", s,
> +			  slice_available(topo_info, s) ? "available" : "fused");
> +
> +		if (!slice_available(topo_info, s))
> +			continue;
>   
>   		for (ss = 0; ss < topo_info->max_subslices; ss++) {
>   			int eu, n_subslice_eus = 0;
>   
> -			igt_debug("\tsubslice: %i\n", ss);
> +			igt_debug("\tsubslice%i: (%s)\n", ss,
> +				  subslice_available(topo_info, s, ss) ? "available" : "fused");
> +
> +			if (!subslice_available(topo_info, s, ss))
> +				continue;
>   
>   			igt_debug("\t\teu_mask: 0b");
>   			for (eu = 0; eu < topo_info->max_eus_per_subslice; eu++) {
> 

Looks like a no-brainer now.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/query: more accurate available/fused topology printout
  2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
                   ` (2 preceding siblings ...)
  2018-11-08 15:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
@ 2018-11-08 20:22 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-08 20:22 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

== Series Details ==

Series: tests/i915/query: more accurate available/fused topology printout
URL   : https://patchwork.freedesktop.org/series/52220/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4712_full -> IGTPW_2049_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_2049_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2049_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52220/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2049_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_2049_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927, fdo#106886)

    igt@gem_exec_capture@capture-bsd2:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@gem_exec_reuse@baggage:
      shard-apl:          PASS -> DMESG-WARN (fdo#108690)

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      shard-glk:          PASS -> FAIL (fdo#108145) +1
      shard-kbl:          PASS -> FAIL (fdo#107725, fdo#108145)

    igt@kms_cursor_crc@cursor-128x128-onscreen:
      shard-kbl:          PASS -> FAIL (fdo#103232) +2

    igt@kms_cursor_crc@cursor-256x85-random:
      shard-apl:          PASS -> FAIL (fdo#103232) +4
      shard-glk:          PASS -> FAIL (fdo#103232) +3

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#105763, fdo#106538)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip@dpms-vs-vblank-race:
      shard-kbl:          PASS -> FAIL (fdo#103060)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-kbl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-apl:          PASS -> FAIL (fdo#103167) +1

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167) +7

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          PASS -> FAIL (fdo#103166) +5

    igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
      shard-apl:          PASS -> FAIL (fdo#103166) +3
      shard-kbl:          PASS -> FAIL (fdo#103166)

    
    ==== Possible fixes ====

    igt@gem_exec_bad_domains@cpu-domain:
      shard-apl:          DMESG-WARN (fdo#103558, fdo#105602) -> PASS +5

    igt@gem_pwrite_pread@snooped-copy-correctness:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_color@pipe-b-legacy-gamma:
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-apl:          FAIL (fdo#103232) -> PASS +6

    igt@kms_cursor_crc@cursor-64x64-dpms:
      shard-kbl:          FAIL (fdo#103232) -> PASS +3

    igt@kms_cursor_crc@cursor-64x64-random:
      shard-glk:          FAIL (fdo#103232) -> PASS +3

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-glk:          FAIL (fdo#103167) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-apl:          FAIL (fdo#103166) -> PASS +3

    igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
      shard-glk:          FAIL (fdo#103166) -> PASS

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-kbl:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic-clone-single-crtc:
      shard-snb:          DMESG-WARN (fdo#107469) -> PASS +2

    
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
  fdo#107725 https://bugs.freedesktop.org/show_bug.cgi?id=107725
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108690 https://bugs.freedesktop.org/show_bug.cgi?id=108690


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4712 -> IGTPW_2049

  CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2049: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/
  IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2049/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout
  2018-11-08 15:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
@ 2018-11-08 20:59   ` Lionel Landwerlin
  0 siblings, 0 replies; 6+ messages in thread
From: Lionel Landwerlin @ 2018-11-08 20:59 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: tvrtko.ursulin

On 08/11/2018 15:37, Tvrtko Ursulin wrote:
>
> On 08/11/2018 11:25, Lionel Landwerlin wrote:
>> Make availability of all elements more visible for debug purposes.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> ---
>>   tests/i915/query.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/i915/query.c b/tests/i915/query.c
>> index 08aabf94..3e7fd140 100644
>> --- a/tests/i915/query.c
>> +++ b/tests/i915/query.c
>> @@ -373,12 +373,20 @@ test_query_topology_matches_eu_total(int fd)
>>       for (s = 0; s < topo_info->max_slices; s++) {
>>           int ss;
>>   -        igt_debug("slice%i:\n", s);
>> +        igt_debug("slice%i: (%s)\n", s,
>> +              slice_available(topo_info, s) ? "available" : "fused");
>> +
>> +        if (!slice_available(topo_info, s))
>> +            continue;
>>             for (ss = 0; ss < topo_info->max_subslices; ss++) {
>>               int eu, n_subslice_eus = 0;
>>   -            igt_debug("\tsubslice: %i\n", ss);
>> +            igt_debug("\tsubslice%i: (%s)\n", ss,
>> +                  subslice_available(topo_info, s, ss) ? "available" 
>> : "fused");
>> +
>> +            if (!subslice_available(topo_info, s, ss))
>> +                continue;
>>                 igt_debug("\t\teu_mask: 0b");
>>               for (eu = 0; eu < topo_info->max_eus_per_subslice; eu++) {
>>
>
> Looks like a no-brainer now.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Regards,
>
> Tvrtko
>
Thanks, pushed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-08 20:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
2018-11-08 12:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-11-08 13:00 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-08 15:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2018-11-08 20:59   ` Lionel Landwerlin
2018-11-08 20:22 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.