* [Buildroot] [PATCH v3] dbus-python: add host package
@ 2018-11-09 0:38 Brent Generous
2019-08-01 10:53 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: Brent Generous @ 2018-11-09 0:38 UTC (permalink / raw)
To: buildroot
This can be useful for Python scripts running on a host machine that
need to connect to a bus on a remote device, e.g. test scripts.
The target dbus-python depends on dbus instead of selecting it because
dbus has dependencies that check that it is supported. Using 'select'
would override those dependencies. For host-dbus, there are no such
checks -- it's assumed the host has the features neeeded to run dbus, so
it is okay to just depend on host-dbus.
The pyexpat dependency is not needed, as it is forced on for
host-python.
Signed-off-by: Brent Generous <bgenerous@impinj.com>
---
package/Config.in.host | 1 +
package/dbus-python/Config.in.host | 6 ++++++
package/dbus-python/dbus-python.mk | 18 ++++++++++++++++++
3 files changed, 25 insertions(+)
create mode 100644 package/dbus-python/Config.in.host
diff --git a/package/Config.in.host b/package/Config.in.host
index 16b474fc9d..521ef146af 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -10,6 +10,7 @@ menu "Host utilities"
source "package/cmake/Config.in.host"
source "package/cramfs/Config.in.host"
source "package/cryptsetup/Config.in.host"
+ source "package/dbus-python/Config.in.host"
source "package/dfu-util/Config.in.host"
source "package/dos2unix/Config.in.host"
source "package/dosfstools/Config.in.host"
diff --git a/package/dbus-python/Config.in.host b/package/dbus-python/Config.in.host
new file mode 100644
index 0000000000..1e30e0a7f0
--- /dev/null
+++ b/package/dbus-python/Config.in.host
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_HOST_DBUS_PYTHON
+ bool "host dbus-python"
+ help
+ Python bindings for D-Bus
+
+ http://dbus.freedesktop.org/doc/dbus-python/
diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
index da04b7404f..456e621f18 100644
--- a/package/dbus-python/dbus-python.mk
+++ b/package/dbus-python/dbus-python.mk
@@ -12,6 +12,9 @@ DBUS_PYTHON_LICENSE_FILES = COPYING
DBUS_PYTHON_DEPENDENCIES = dbus-glib
DBUS_PYTHON_CONF_OPTS = --disable-html-docs --disable-api-docs
+HOST_DBUS_PYTHON_DEPENDENCIES = host-dbus-glib
+HOST_DBUS_PYTHON_CONF_OPTS = --disable-html-docs --disable-api-docs
+
ifeq ($(BR2_PACKAGE_PYTHON),y)
DBUS_PYTHON_DEPENDENCIES += python host-python
@@ -19,6 +22,13 @@ DBUS_PYTHON_CONF_ENV += \
PYTHON=$(HOST_DIR)/bin/python2 \
PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python2-config --includes`" \
PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python2-config --ldflags`"
+
+HOST_DBUS_PYTHON_DEPENDENCIES += host-python
+
+HOST_DBUS_PYTHON_CONF_ENV += \
+ PYTHON=$(HOST_DIR)/bin/python2 \
+ PYTHON_INCLUDES="`$(HOST_DIR)/usr/bin/python2-config --includes`" \
+ PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python2-config --ldflags`"
else
DBUS_PYTHON_DEPENDENCIES += python3 host-python3
@@ -26,6 +36,14 @@ DBUS_PYTHON_CONF_ENV += \
PYTHON=$(HOST_DIR)/bin/python3 \
PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
+
+HOST_DBUS_PYTHON_DEPENDENCIES += host-python3
+
+HOST_DBUS_PYTHON_CONF_ENV += \
+ PYTHON=$(HOST_DIR)/bin/python3 \
+ PYTHON_INCLUDES="`$(HOST_DIR)/usr/bin/python3-config --includes`" \
+ PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python3-config --ldflags`"
endif
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.14.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v3] dbus-python: add host package
2018-11-09 0:38 [Buildroot] [PATCH v3] dbus-python: add host package Brent Generous
@ 2019-08-01 10:53 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2019-08-01 10:53 UTC (permalink / raw)
To: buildroot
On 09/11/2018 01:38, Brent Generous wrote:
> This can be useful for Python scripts running on a host machine that
> need to connect to a bus on a remote device, e.g. test scripts.
>
> The target dbus-python depends on dbus instead of selecting it because
> dbus has dependencies that check that it is supported. Using 'select'
> would override those dependencies. For host-dbus, there are no such
> checks -- it's assumed the host has the features neeeded to run dbus, so
> it is okay to just depend on host-dbus.
>
> The pyexpat dependency is not needed, as it is forced on for
> host-python.
>
> Signed-off-by: Brent Generous <bgenerous@impinj.com>
Applied to master, thanks.
Sorry it took so long, after you were so quick to take into account our feedback.
Regards,
Arnout
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-01 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 0:38 [Buildroot] [PATCH v3] dbus-python: add host package Brent Generous
2019-08-01 10:53 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.