Re: [PATCH v2] x86/cpu: fix prototype warning

From: Greg KH <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: wang.yi59@zte.com.cn, matz@suse.de, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	suravee.suthikulpanit@amd.com, puwen@hygon.cn,
	davidwang@zhaoxin.com, linux-kernel@vger.kernel.org,
	zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] x86/cpu: fix prototype warning
Date: Fri, 9 Nov 2018 03:12:25 -0800	[thread overview]
Message-ID: <20181109111225.GA26335@kroah.com> (raw)
In-Reply-To: <20181109105538.GA21243@zn.tnic>

On Fri, Nov 09, 2018 at 11:55:38AM +0100, Borislav Petkov wrote:
> On Fri, Nov 09, 2018 at 08:43:12AM +0800, wang.yi59@zte.com.cn wrote:
> > Yeah, so that is. However, I suppose we should not enable this by default
> > before we fix ALL of these warning,
> 
> Yeah, the build is really noisy now.
> 
> > which is really a  hard work. :)
> 
> Yeah, I wonder if adding this to a kernel janitors TODO list or somesuch
> would help speeding up the process.
> 
> Maybe Greg knows.
> 
> Greg, the question is whether we can get people to help out with
> 
>   -Wmissing-prototypes
> 
> fixes around the tree. Currently, there are ~1400 warnings and we want
> to have 0 and then add that option to the main Makefile.
> 
> It is very easy to do: you simply build the kernel with W=1, choose one
> -Wmissing-prototypes warning and fix it by adding a function prototype
> or declaring the function static.
> 
> It should be a pretty easy for newbies to get involved...

Sure, sounds like a good task.  Post it to the driverdevel mailing list
and see if people are interested.

thanks,

greg k-h