All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: Don't dump Hi & Lo regs on >= MIPSr6
@ 2018-11-09 20:08 Paul Burton
  2018-11-13 22:22   ` Paul Burton
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Burton @ 2018-11-09 20:08 UTC (permalink / raw)
  To: linux-mips; +Cc: Paul Burton

MIPSr6 removed the Hi & Lo registers, so displaying their values on
MIPSr6 systems is pointless. Avoid doing so.

Signed-off-by: Paul Burton <paul.burton@mips.com>
---

 arch/mips/kernel/traps.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 21f36c9e8a86..a88994a77d52 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -51,6 +51,7 @@
 #include <asm/fpu.h>
 #include <asm/fpu_emulator.h>
 #include <asm/idle.h>
+#include <asm/isa-rev.h>
 #include <asm/mips-cps.h>
 #include <asm/mips-r2-to-r6-emul.h>
 #include <asm/mipsregs.h>
@@ -279,8 +280,10 @@ static void __show_regs(const struct pt_regs *regs)
 #ifdef CONFIG_CPU_HAS_SMARTMIPS
 	printk("Acx    : %0*lx\n", field, regs->acx);
 #endif
-	printk("Hi    : %0*lx\n", field, regs->hi);
-	printk("Lo    : %0*lx\n", field, regs->lo);
+	if (MIPS_ISA_REV < 6) {
+		printk("Hi    : %0*lx\n", field, regs->hi);
+		printk("Lo    : %0*lx\n", field, regs->lo);
+	}
 
 	/*
 	 * Saved cp0 registers
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Don't dump Hi & Lo regs on >= MIPSr6
@ 2018-11-13 22:22   ` Paul Burton
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Burton @ 2018-11-13 22:22 UTC (permalink / raw)
  To: Paul Burton; +Cc: linux-mips, Paul Burton, linux-mips

Hello,

Paul Burton wrote:
> MIPSr6 removed the Hi & Lo registers, so displaying their values on
> MIPSr6 systems is pointless. Avoid doing so.
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>

Applied to mips-next.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Don't dump Hi & Lo regs on >= MIPSr6
@ 2018-11-13 22:22   ` Paul Burton
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Burton @ 2018-11-13 22:22 UTC (permalink / raw)
  To: Paul Burton; +Cc: linux-mips

Hello,

Paul Burton wrote:
> MIPSr6 removed the Hi & Lo registers, so displaying their values on
> MIPSr6 systems is pointless. Avoid doing so.
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>

Applied to mips-next.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-13 22:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 20:08 [PATCH] MIPS: Don't dump Hi & Lo regs on >= MIPSr6 Paul Burton
2018-11-13 22:22 ` Paul Burton
2018-11-13 22:22   ` Paul Burton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.