* [PATCH v4 0/3] Huawei laptops
@ 2018-11-09 23:45 Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Ayman Bagabas @ 2018-11-09 23:45 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko, Ayman Bagabas, linux-kernel,
platform-driver-x86
Changes from v3:
* Code formatting
Changes from v2:
* Support for Huawei MBX
* Style and formating issues
[PATCH v3 1/3]
The first patch adds support for missing hotkeys on some models.
[PATCH v3 2/3]
This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This
solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501
It simply uses the pins configurations generated by hdajackretast using the
settings posted on the bug page https://imgur.com/a/N1xsCVZ
[PATCH v3 3/3]
This enables the micmute LED on Huawei laptops with these IDs:
1. Matebook X (19e5:3200)
2. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++
include/linux/platform_data/x86/huawei_wmi.h | 9 +
sound/pci/hda/huawei_wmi_helper.c | 47 ++++
sound/pci/hda/patch_realtek.c | 30 +++
6 files changed, 312 insertions(+)
create mode 100644 drivers/platform/x86/huawei_wmi.c
create mode 100644 include/linux/platform_data/x86/huawei_wmi.h
create mode 100644 sound/pci/hda/huawei_wmi_helper.c
--
2.17.2
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys.
2018-11-09 23:45 [PATCH v4 0/3] Huawei laptops Ayman Bagabas
@ 2018-11-09 23:45 ` Ayman Bagabas
2018-11-10 14:25 ` Andy Shevchenko
2018-11-09 23:45 ` [PATCH v4 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Ayman Bagabas @ 2018-11-09 23:45 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko, Ayman Bagabas, linux-kernel,
platform-driver-x86
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
---
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++
include/linux/platform_data/x86/huawei_wmi.h | 9 +
4 files changed, 235 insertions(+)
create mode 100644 drivers/platform/x86/huawei_wmi.c
create mode 100644 include/linux/platform_data/x86/huawei_wmi.h
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 54f6a40c75c6..5bdc4d54cddf 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1288,6 +1288,16 @@ config INTEL_ATOMISP2_PM
To compile this driver as a module, choose M here: the module
will be called intel_atomisp2_pm.
+config HUAWEI_LAPTOP
+ tristate "Huawei WMI hotkeys driver"
+ depends on ACPI_WMI
+ depends on INPUT
+ select INPUT_SPARSEKMAP
+ help
+ This driver provides support for Huawei WMI hotkeys.
+ It enables the missing keys and adds support to the micmute
+ LED found on some of these laptops.
+
endif # X86_PLATFORM_DEVICES
config PMC_ATOM
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 39ae94135406..ee93655d8bc1 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -32,6 +32,7 @@ obj-$(CONFIG_ACERHDF) += acerhdf.o
obj-$(CONFIG_HP_ACCEL) += hp_accel.o
obj-$(CONFIG_HP_WIRELESS) += hp-wireless.o
obj-$(CONFIG_HP_WMI) += hp-wmi.o
+obj-$(CONFIG_HUAWEI_LAPTOP) += huawei_wmi.o
obj-$(CONFIG_AMILO_RFKILL) += amilo-rfkill.o
obj-$(CONFIG_GPD_POCKET_FAN) += gpd-pocket-fan.o
obj-$(CONFIG_TC1100_WMI) += tc1100-wmi.o
diff --git a/drivers/platform/x86/huawei_wmi.c b/drivers/platform/x86/huawei_wmi.c
new file mode 100644
index 000000000000..940c07ce4552
--- /dev/null
+++ b/drivers/platform/x86/huawei_wmi.c
@@ -0,0 +1,215 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Huawei WMI hotkeys
+ *
+ * Copyright (C) 2018 Ayman Bagabas <ayman.bagabas@gmail.com>
+ */
+
+#include <linux/acpi.h>
+#include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
+#include <linux/module.h>
+#include <linux/platform_data/x86/huawei_wmi.h>
+
+MODULE_AUTHOR("Ayman Bagabas <ayman.bagabas@gmail.com>");
+MODULE_DESCRIPTION("Huawei WMI hotkeys");
+MODULE_LICENSE("GPL");
+
+/*
+ * Huawei WMI Events GUIDs
+ */
+#define MBX_EVENT_GUID "59142400-C6A3-40fa-BADB-8A2652834100"
+#define MBXP_EVENT_GUID "ABBC0F5C-8EA1-11D1-A000-C90629100000"
+
+MODULE_ALIAS("wmi:"MBX_EVENT_GUID);
+MODULE_ALIAS("wmi:"MBXP_EVENT_GUID);
+
+static const struct key_entry huawei_wmi_keymap[] __initconst = {
+ { KE_KEY, 0x281, { KEY_BRIGHTNESSDOWN } },
+ { KE_KEY, 0x282, { KEY_BRIGHTNESSUP } },
+ { KE_KEY, 0x284, { KEY_MUTE } },
+ { KE_KEY, 0x285, { KEY_VOLUMEDOWN } },
+ { KE_KEY, 0x286, { KEY_VOLUMEUP } },
+ { KE_KEY, 0x287, { KEY_MICMUTE } },
+ { KE_KEY, 0x289, { KEY_WLAN } },
+ // Huawei |M| button
+ { KE_KEY, 0x28a, { KEY_PROG1 } },
+ // Keyboard light
+ { KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
+ { KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
+ { KE_IGNORE, 0x295, { KEY_KBDILLUMUP } },
+ { KE_END, 0 }
+};
+
+static char *event_guid;
+static struct input_dev *inputdev;
+
+int huawei_wmi_micmute_led_set(bool on)
+{
+ acpi_handle handle;
+ char *method;
+ union acpi_object args[3];
+ struct acpi_object_list arg_list = {
+ .pointer = args,
+ .count = ARRAY_SIZE(args),
+ };
+
+ handle = ACPI_HANDLE(&inputdev->dev);
+ args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
+ args[1].integer.value = 0x04;
+
+ if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) {
+ args[0].integer.value = 0;
+ args[2].integer.value = on ? 1 : 0;
+ } else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) {
+ args[0].integer.value = 1;
+ args[2].integer.value = on ? 0 : 1;
+ } else {
+ dev_err(&inputdev->dev, "Unable to find ACPI method\n");
+ return -ENOSYS;
+ }
+
+ acpi_evaluate_object(handle, method, &arg_list, NULL);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(huawei_wmi_micmute_led_set);
+
+static void huawei_wmi_process_key(struct input_dev *inputdev, int code)
+{
+ const struct key_entry *key;
+
+ /*
+ * MBX uses code 0x80 to indicate a hotkey event.
+ * The actual key is fetched from the method WQ00
+ */
+ if (code == 0x80) {
+ acpi_status status;
+ unsigned long long result;
+ const char *method = "\\WMI0.WQ00";
+ union acpi_object args[1];
+ struct acpi_object_list arg_list = {
+ .pointer = args,
+ .count = ARRAY_SIZE(args),
+ };
+
+ args[0].type = ACPI_TYPE_INTEGER;
+ args[0].integer.value = 0;
+
+ status = acpi_evaluate_integer(ACPI_HANDLE(&inputdev->dev), (char *)method, &arg_list, &result);
+ if (ACPI_FAILURE(status)) {
+ dev_err(&inputdev->dev, "Unable to evaluate ACPI method %s\n", method);
+ return;
+ }
+
+ code = result;
+ }
+
+ key = sparse_keymap_entry_from_scancode(inputdev, code);
+ if (!key) {
+ dev_info(&inputdev->dev, "Unknown key pressed, code: 0x%04x\n", code);
+ return;
+ }
+
+ /*
+ * The MBXP handles backlight natively using ACPI,
+ * but not the MBX. If MBXP is being used, skip reporting event.
+ */
+ if ((key->sw.code == KEY_BRIGHTNESSUP || key->sw.code == KEY_BRIGHTNESSDOWN)
+ && strcmp(event_guid, MBXP_EVENT_GUID) == 0)
+ return;
+
+ sparse_keymap_report_entry(inputdev, key, 1, true);
+}
+
+static void huawei_wmi_notify(u32 value, void *context)
+{
+ struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
+ union acpi_object *obj;
+ acpi_status status;
+ struct input_dev *inputdev = (struct input_dev *)context;
+
+ status = wmi_get_event_data(value, &response);
+ if (ACPI_FAILURE(status)) {
+ dev_err(&inputdev->dev, "Bad event status 0x%x\n", status);
+ return;
+ }
+
+ obj = (union acpi_object *)response.pointer;
+ if (!obj)
+ return;
+
+ if (obj->type == ACPI_TYPE_INTEGER)
+ huawei_wmi_process_key(inputdev, obj->integer.value);
+ else
+ dev_info(&inputdev->dev, "Unknown response received %d\n", obj->type);
+
+ kfree(response.pointer);
+}
+
+static int huawei_wmi_input_init(void)
+{
+ acpi_status status;
+ int err;
+
+ inputdev = input_allocate_device();
+ if (!inputdev)
+ return -ENOMEM;
+
+ inputdev->name = "Huawei WMI hotkeys";
+ inputdev->phys = "wmi/input0";
+ inputdev->id.bustype = BUS_HOST;
+
+ err = sparse_keymap_setup(inputdev,
+ huawei_wmi_keymap, NULL);
+ if (err)
+ goto err_free_dev;
+
+ status = wmi_install_notify_handler(event_guid,
+ huawei_wmi_notify,
+ inputdev);
+ if (ACPI_FAILURE(status)) {
+ err = -EIO;
+ goto err_free_dev;
+ }
+
+ err = input_register_device(inputdev);
+ if (err)
+ goto err_remove_notifier;
+
+ return 0;
+
+err_remove_notifier:
+ wmi_remove_notify_handler(event_guid);
+err_free_dev:
+ input_free_device(inputdev);
+ return err;
+}
+
+static void huawei_wmi_input_exit(void)
+{
+ wmi_remove_notify_handler(event_guid);
+ input_unregister_device(inputdev);
+}
+
+static int __init huawei_wmi_init(void)
+{
+ if (wmi_has_guid(MBX_EVENT_GUID)) {
+ event_guid = MBX_EVENT_GUID;
+ } else if (wmi_has_guid(MBXP_EVENT_GUID)) {
+ event_guid = MBXP_EVENT_GUID;
+ } else {
+ pr_warn("Compatible WMI GUID not found\n");
+ return -ENODEV;
+ }
+
+ return huawei_wmi_input_init();
+}
+
+static void __exit huawei_wmi_exit(void)
+{
+ huawei_wmi_input_exit();
+}
+
+module_init(huawei_wmi_init);
+module_exit(huawei_wmi_exit);
diff --git a/include/linux/platform_data/x86/huawei_wmi.h b/include/linux/platform_data/x86/huawei_wmi.h
new file mode 100644
index 000000000000..dd251780ee5c
--- /dev/null
+++ b/include/linux/platform_data/x86/huawei_wmi.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
+#ifndef __HUAWEI_WMI_H__
+#define __HUAWEI_WMI_H__
+
+int huawei_wmi_micmute_led_set(bool on);
+
+#endif
+#endif
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 2/3] ALSA: hda: fix front speakers on Huawei MBXP.
2018-11-09 23:45 [PATCH v4 0/3] Huawei laptops Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
@ 2018-11-09 23:45 ` Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-11-10 14:17 ` [PATCH v4 0/3] Huawei laptops Andy Shevchenko
3 siblings, 0 replies; 11+ messages in thread
From: Ayman Bagabas @ 2018-11-09 23:45 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko, Jaroslav Kysela, Takashi Iwai,
Ayman Bagabas, Kailang Yang, Hui Wang, linux-kernel,
platform-driver-x86, alsa-devel
This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
https://bugzilla.kernel.org/show_bug.cgi?id=200501
It enables the front speakers on Huawei Matebook X Pro laptops.
These laptops come with Dolby Atmos sound system and these pins
configuration enables the front speakers.
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
---
sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fa61674a5605..135c0826859b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5493,6 +5493,7 @@ enum {
ALC298_FIXUP_TPT470_DOCK,
ALC255_FIXUP_DUMMY_LINEOUT_VERB,
ALC255_FIXUP_DELL_HEADSET_MIC,
+ ALC256_FIXUP_HUAWEI_MBXP_PINS,
ALC295_FIXUP_HP_X360,
ALC221_FIXUP_HP_HEADSET_MIC,
};
@@ -5764,6 +5765,22 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC269_FIXUP_HEADSET_MIC
},
+ [ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ {0x12, 0x90a60130},
+ {0x13, 0x40000000},
+ {0x14, 0x90170110},
+ {0x18, 0x411111f0},
+ {0x19, 0x04a11040},
+ {0x1a, 0x411111f0},
+ {0x1b, 0x90170112},
+ {0x1d, 0x40759a05},
+ {0x1e, 0x411111f0},
+ {0x21, 0x04211020},
+ { }
+ }
+ },
[ALC269_FIXUP_ASUS_X101_FUNC] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc269_fixup_x101_headset_mic,
@@ -6594,6 +6611,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
+ SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
#if 0
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
2018-11-09 23:45 [PATCH v4 0/3] Huawei laptops Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
@ 2018-11-09 23:45 ` Ayman Bagabas
2018-11-10 14:26 ` Andy Shevchenko
2018-11-10 14:17 ` [PATCH v4 0/3] Huawei laptops Andy Shevchenko
3 siblings, 1 reply; 11+ messages in thread
From: Ayman Bagabas @ 2018-11-09 23:45 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko, Jaroslav Kysela, Takashi Iwai,
Ayman Bagabas, Kailang Yang, Hui Wang, linux-kernel,
platform-driver-x86, alsa-devel
Some of Huawei laptops come with a LED in the micmute key. This patch
enables and disable this LED accordingly.
This enables micmute LED for:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
---
sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
sound/pci/hda/patch_realtek.c | 14 ++++++++-
2 files changed, 60 insertions(+), 1 deletion(-)
create mode 100644 sound/pci/hda/huawei_wmi_helper.c
diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
new file mode 100644
index 000000000000..7c91f914ffba
--- /dev/null
+++ b/sound/pci/hda/huawei_wmi_helper.c
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Helper functions for Huawei WMI micmute LED;
+ * to be included from codec driver
+ */
+
+#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
+#include <linux/platform_data/x86/huawei_wmi.h>
+
+static int (*huawei_wmi_micmute_led_set_func)(bool);
+
+static void update_huawei_wmi_micmute_led(struct hda_codec *codec)
+{
+ struct hda_gen_spec *spec = codec->spec;
+ huawei_wmi_micmute_led_set_func(spec->micmute_led.led_value);
+}
+
+static void alc_fixup_huawei_wmi(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ bool removefunc = false;
+
+ if (action == HDA_FIXUP_ACT_PROBE) {
+ if (!huawei_wmi_micmute_led_set_func)
+ huawei_wmi_micmute_led_set_func = symbol_request(huawei_wmi_micmute_led_set);
+ if (!huawei_wmi_micmute_led_set_func) {
+ codec_warn(codec, "Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n");
+ return;
+ }
+
+ removefunc = (huawei_wmi_micmute_led_set_func(false) < 0)
+ || (snd_hda_gen_add_micmute_led(codec, update_huawei_wmi_micmute_led) < 0);
+ }
+
+ if (huawei_wmi_micmute_led_set_func && (action == HDA_FIXUP_ACT_FREE || removefunc)) {
+ symbol_put(huawei_wmi_micmute_led_set);
+ huawei_wmi_micmute_led_set_func = NULL;
+ }
+}
+
+#else
+
+static void alc_fixup_huawei_wmi(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+}
+
+#endif
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 135c0826859b..5431dee40f4f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
/* for alc295_fixup_hp_top_speakers */
#include "hp_x360_helper.c"
+/* for alc_fixup_huawei_micmute_led */
+#include "huawei_wmi_helper.c"
+
enum {
ALC269_FIXUP_SONY_VAIO,
ALC275_FIXUP_SONY_VAIO_GPIO2,
@@ -5494,6 +5497,7 @@ enum {
ALC255_FIXUP_DUMMY_LINEOUT_VERB,
ALC255_FIXUP_DELL_HEADSET_MIC,
ALC256_FIXUP_HUAWEI_MBXP_PINS,
+ ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED,
ALC295_FIXUP_HP_X360,
ALC221_FIXUP_HP_HEADSET_MIC,
};
@@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC269_FIXUP_HEADSET_MIC
},
+ [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc_fixup_huawei_wmi
+ },
[ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = {
{0x1e, 0x411111f0},
{0x21, 0x04211020},
{ }
- }
+ },
+ .chained = true,
+ .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED
},
[ALC269_FIXUP_ASUS_X101_FUNC] = {
.type = HDA_FIXUP_FUNC,
@@ -6611,6 +6621,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
+ SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
+ SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/3] Huawei laptops
2018-11-09 23:45 [PATCH v4 0/3] Huawei laptops Ayman Bagabas
` (2 preceding siblings ...)
2018-11-09 23:45 ` [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
@ 2018-11-10 14:17 ` Andy Shevchenko
2018-11-10 14:18 ` Andy Shevchenko
3 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2018-11-10 14:17 UTC (permalink / raw)
To: Ayman Bagabas
Cc: Darren Hart, Andy Shevchenko, Linux Kernel Mailing List, Platform Driver
On Sat, Nov 10, 2018 at 1:45 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
>
Thanks for an updated version.
I have pushed this to my review and testing queue, however, I would
wait till Taskashi ACKs the last two patches in the series.
Meanwhile you may rename the files to follow the pattern (<VENDOR>-wmi.c etc).
> Changes from v3:
> * Code formatting
>
> Changes from v2:
> * Support for Huawei MBX
> * Style and formating issues
>
> [PATCH v3 1/3]
> The first patch adds support for missing hotkeys on some models.
>
> [PATCH v3 2/3]
> This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This
> solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501
> It simply uses the pins configurations generated by hdajackretast using the
> settings posted on the bug page https://imgur.com/a/N1xsCVZ
>
> [PATCH v3 3/3]
> This enables the micmute LED on Huawei laptops with these IDs:
> 1. Matebook X (19e5:3200)
> 2. Matebook X (19e5:3201)
> 3. Matebook X Pro (19e5:3204)
>
>
> Ayman Bagabas (3):
> x86: add support for Huawei WMI hotkeys.
> ALSA: hda: fix front speakers on Huawei MBXP.
> ALSA: hda: add support for Huawei WMI micmute LED
>
> drivers/platform/x86/Kconfig | 10 +
> drivers/platform/x86/Makefile | 1 +
> drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++
> include/linux/platform_data/x86/huawei_wmi.h | 9 +
> sound/pci/hda/huawei_wmi_helper.c | 47 ++++
> sound/pci/hda/patch_realtek.c | 30 +++
> 6 files changed, 312 insertions(+)
> create mode 100644 drivers/platform/x86/huawei_wmi.c
> create mode 100644 include/linux/platform_data/x86/huawei_wmi.h
> create mode 100644 sound/pci/hda/huawei_wmi_helper.c
>
> --
> 2.17.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/3] Huawei laptops
2018-11-10 14:17 ` [PATCH v4 0/3] Huawei laptops Andy Shevchenko
@ 2018-11-10 14:18 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2018-11-10 14:18 UTC (permalink / raw)
To: Ayman Bagabas
Cc: Darren Hart, Andy Shevchenko, Linux Kernel Mailing List, Platform Driver
On Sat, Nov 10, 2018 at 4:17 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sat, Nov 10, 2018 at 1:45 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
> >
>
> Thanks for an updated version.
>
> I have pushed this to my review and testing queue, however, I would
> wait till Taskashi ACKs the last two patches in the series.
> Meanwhile you may rename the files to follow the pattern (<VENDOR>-wmi.c etc).
To clarify, I'm talking here of the files regarding to PDx86. Whatever
scheme is used in ALSA I don't care.
> > Changes from v3:
> > * Code formatting
> >
> > Changes from v2:
> > * Support for Huawei MBX
> > * Style and formating issues
> >
> > [PATCH v3 1/3]
> > The first patch adds support for missing hotkeys on some models.
> >
> > [PATCH v3 2/3]
> > This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This
> > solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501
> > It simply uses the pins configurations generated by hdajackretast using the
> > settings posted on the bug page https://imgur.com/a/N1xsCVZ
> >
> > [PATCH v3 3/3]
> > This enables the micmute LED on Huawei laptops with these IDs:
> > 1. Matebook X (19e5:3200)
> > 2. Matebook X (19e5:3201)
> > 3. Matebook X Pro (19e5:3204)
> >
> >
> > Ayman Bagabas (3):
> > x86: add support for Huawei WMI hotkeys.
> > ALSA: hda: fix front speakers on Huawei MBXP.
> > ALSA: hda: add support for Huawei WMI micmute LED
> >
> > drivers/platform/x86/Kconfig | 10 +
> > drivers/platform/x86/Makefile | 1 +
> > drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++
> > include/linux/platform_data/x86/huawei_wmi.h | 9 +
> > sound/pci/hda/huawei_wmi_helper.c | 47 ++++
> > sound/pci/hda/patch_realtek.c | 30 +++
> > 6 files changed, 312 insertions(+)
> > create mode 100644 drivers/platform/x86/huawei_wmi.c
> > create mode 100644 include/linux/platform_data/x86/huawei_wmi.h
> > create mode 100644 sound/pci/hda/huawei_wmi_helper.c
> >
> > --
> > 2.17.2
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys.
2018-11-09 23:45 ` [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
@ 2018-11-10 14:25 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2018-11-10 14:25 UTC (permalink / raw)
To: Ayman Bagabas
Cc: Darren Hart, Andy Shevchenko, Linux Kernel Mailing List, Platform Driver
On Sat, Nov 10, 2018 at 1:45 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
>
> This driver adds support for missing hotkeys on some Huawei laptops.
> Currently, only Huawei Matebook X and Matebook X Pro is supported.
> drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++
> include/linux/platform_data/x86/huawei_wmi.h | 9 +
So, please use a de facto pattern, i.e. <VENDOR>-wmi.c, so for *.h.
> +config HUAWEI_LAPTOP
This better to be consistent with the module name.
> + help
> + This driver provides support for Huawei WMI hotkeys.
> + It enables the missing keys and adds support to the micmute
> + LED found on some of these laptops.
Here we usually put a line how module will be called.
> +// SPDX-License-Identifier: GPL-2.0
You need to choose proper license either here, or in MODULE_LICENSE()
line. For now they are not in align.
> +MODULE_LICENSE("GPL");
> + /*
> + * MBX uses code 0x80 to indicate a hotkey event.
> + * The actual key is fetched from the method WQ00
Period is missed.
> + */
> +static void huawei_wmi_notify(u32 value, void *context)
> +{
> + struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
> + union acpi_object *obj;
> + acpi_status status;
> + struct input_dev *inputdev = (struct input_dev *)context;
No need an explicit casting.
Also, move this to be first line in the definition block.
> + status = wmi_get_event_data(value, &response);
> + if (ACPI_FAILURE(status)) {
> + dev_err(&inputdev->dev, "Bad event status 0x%x\n", status);
> + return;
> + }
> +}
> + err = sparse_keymap_setup(inputdev,
> + huawei_wmi_keymap, NULL);
Would it be one line?
> + if (err)
> + goto err_free_dev;
> +
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
2018-11-09 23:45 ` [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
@ 2018-11-10 14:26 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2018-11-10 14:26 UTC (permalink / raw)
To: Ayman Bagabas
Cc: Darren Hart, Andy Shevchenko, Jaroslav Kysela, Takashi Iwai,
Kailang Yang, Hui Wang, Linux Kernel Mailing List,
Platform Driver, ALSA Development Mailing List
On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
>
> Some of Huawei laptops come with a LED in the micmute key. This patch
> enables and disable this LED accordingly.
> This enables micmute LED for:
> 1. Matebook X (19e5:3200), (19e5:3201)
> 2. Matebook X Pro (19e5:3204)
>
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> ---
> sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
> sound/pci/hda/patch_realtek.c | 14 ++++++++-
> 2 files changed, 60 insertions(+), 1 deletion(-)
> create mode 100644 sound/pci/hda/huawei_wmi_helper.c
>
> diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
> new file mode 100644
> index 000000000000..7c91f914ffba
> --- /dev/null
> +++ b/sound/pci/hda/huawei_wmi_helper.c
> @@ -0,0 +1,47 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Helper functions for Huawei WMI micmute LED;
> + * to be included from codec driver
> + */
> +
> +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
ENABLED or REACHABLE?
> +#include <linux/platform_data/x86/huawei_wmi.h>
> +
> +static int (*huawei_wmi_micmute_led_set_func)(bool);
> +
> +static void update_huawei_wmi_micmute_led(struct hda_codec *codec)
> +{
> + struct hda_gen_spec *spec = codec->spec;
> + huawei_wmi_micmute_led_set_func(spec->micmute_led.led_value);
> +}
> +
> +static void alc_fixup_huawei_wmi(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> + bool removefunc = false;
> +
> + if (action == HDA_FIXUP_ACT_PROBE) {
> + if (!huawei_wmi_micmute_led_set_func)
> + huawei_wmi_micmute_led_set_func = symbol_request(huawei_wmi_micmute_led_set);
> + if (!huawei_wmi_micmute_led_set_func) {
> + codec_warn(codec, "Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n");
> + return;
> + }
> +
> + removefunc = (huawei_wmi_micmute_led_set_func(false) < 0)
> + || (snd_hda_gen_add_micmute_led(codec, update_huawei_wmi_micmute_led) < 0);
> + }
> +
> + if (huawei_wmi_micmute_led_set_func && (action == HDA_FIXUP_ACT_FREE || removefunc)) {
> + symbol_put(huawei_wmi_micmute_led_set);
> + huawei_wmi_micmute_led_set_func = NULL;
> + }
> +}
> +
> +#else
> +
> +static void alc_fixup_huawei_wmi(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> +}
> +
> +#endif
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 135c0826859b..5431dee40f4f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
> /* for alc295_fixup_hp_top_speakers */
> #include "hp_x360_helper.c"
>
> +/* for alc_fixup_huawei_micmute_led */
> +#include "huawei_wmi_helper.c"
> +
> enum {
> ALC269_FIXUP_SONY_VAIO,
> ALC275_FIXUP_SONY_VAIO_GPIO2,
> @@ -5494,6 +5497,7 @@ enum {
> ALC255_FIXUP_DUMMY_LINEOUT_VERB,
> ALC255_FIXUP_DELL_HEADSET_MIC,
> ALC256_FIXUP_HUAWEI_MBXP_PINS,
> + ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED,
> ALC295_FIXUP_HP_X360,
> ALC221_FIXUP_HP_HEADSET_MIC,
> };
> @@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = {
> .chained = true,
> .chain_id = ALC269_FIXUP_HEADSET_MIC
> },
> + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = {
> + .type = HDA_FIXUP_FUNC,
> + .v.func = alc_fixup_huawei_wmi
> + },
> [ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
> .type = HDA_FIXUP_PINS,
> .v.pins = (const struct hda_pintbl[]) {
> @@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = {
> {0x1e, 0x411111f0},
> {0x21, 0x04211020},
> { }
> - }
> + },
> + .chained = true,
> + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED
> },
> [ALC269_FIXUP_ASUS_X101_FUNC] = {
> .type = HDA_FIXUP_FUNC,
> @@ -6611,6 +6621,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
> SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
> + SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
> + SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
> SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
> SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
>
> --
> 2.17.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
@ 2018-11-10 14:26 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2018-11-10 14:26 UTC (permalink / raw)
To: Ayman Bagabas
Cc: ALSA Development Mailing List, Kailang Yang,
Linux Kernel Mailing List, Takashi Iwai, Hui Wang, Darren Hart,
Platform Driver, Andy Shevchenko
On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
>
> Some of Huawei laptops come with a LED in the micmute key. This patch
> enables and disable this LED accordingly.
> This enables micmute LED for:
> 1. Matebook X (19e5:3200), (19e5:3201)
> 2. Matebook X Pro (19e5:3204)
>
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> ---
> sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
> sound/pci/hda/patch_realtek.c | 14 ++++++++-
> 2 files changed, 60 insertions(+), 1 deletion(-)
> create mode 100644 sound/pci/hda/huawei_wmi_helper.c
>
> diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
> new file mode 100644
> index 000000000000..7c91f914ffba
> --- /dev/null
> +++ b/sound/pci/hda/huawei_wmi_helper.c
> @@ -0,0 +1,47 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Helper functions for Huawei WMI micmute LED;
> + * to be included from codec driver
> + */
> +
> +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
ENABLED or REACHABLE?
> +#include <linux/platform_data/x86/huawei_wmi.h>
> +
> +static int (*huawei_wmi_micmute_led_set_func)(bool);
> +
> +static void update_huawei_wmi_micmute_led(struct hda_codec *codec)
> +{
> + struct hda_gen_spec *spec = codec->spec;
> + huawei_wmi_micmute_led_set_func(spec->micmute_led.led_value);
> +}
> +
> +static void alc_fixup_huawei_wmi(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> + bool removefunc = false;
> +
> + if (action == HDA_FIXUP_ACT_PROBE) {
> + if (!huawei_wmi_micmute_led_set_func)
> + huawei_wmi_micmute_led_set_func = symbol_request(huawei_wmi_micmute_led_set);
> + if (!huawei_wmi_micmute_led_set_func) {
> + codec_warn(codec, "Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n");
> + return;
> + }
> +
> + removefunc = (huawei_wmi_micmute_led_set_func(false) < 0)
> + || (snd_hda_gen_add_micmute_led(codec, update_huawei_wmi_micmute_led) < 0);
> + }
> +
> + if (huawei_wmi_micmute_led_set_func && (action == HDA_FIXUP_ACT_FREE || removefunc)) {
> + symbol_put(huawei_wmi_micmute_led_set);
> + huawei_wmi_micmute_led_set_func = NULL;
> + }
> +}
> +
> +#else
> +
> +static void alc_fixup_huawei_wmi(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> +}
> +
> +#endif
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 135c0826859b..5431dee40f4f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
> /* for alc295_fixup_hp_top_speakers */
> #include "hp_x360_helper.c"
>
> +/* for alc_fixup_huawei_micmute_led */
> +#include "huawei_wmi_helper.c"
> +
> enum {
> ALC269_FIXUP_SONY_VAIO,
> ALC275_FIXUP_SONY_VAIO_GPIO2,
> @@ -5494,6 +5497,7 @@ enum {
> ALC255_FIXUP_DUMMY_LINEOUT_VERB,
> ALC255_FIXUP_DELL_HEADSET_MIC,
> ALC256_FIXUP_HUAWEI_MBXP_PINS,
> + ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED,
> ALC295_FIXUP_HP_X360,
> ALC221_FIXUP_HP_HEADSET_MIC,
> };
> @@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = {
> .chained = true,
> .chain_id = ALC269_FIXUP_HEADSET_MIC
> },
> + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = {
> + .type = HDA_FIXUP_FUNC,
> + .v.func = alc_fixup_huawei_wmi
> + },
> [ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
> .type = HDA_FIXUP_PINS,
> .v.pins = (const struct hda_pintbl[]) {
> @@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = {
> {0x1e, 0x411111f0},
> {0x21, 0x04211020},
> { }
> - }
> + },
> + .chained = true,
> + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED
> },
> [ALC269_FIXUP_ASUS_X101_FUNC] = {
> .type = HDA_FIXUP_FUNC,
> @@ -6611,6 +6621,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
> SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
> + SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
> + SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED),
> SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
> SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
>
> --
> 2.17.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
2018-11-10 14:26 ` Andy Shevchenko
@ 2018-11-11 8:44 ` Takashi Iwai
-1 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2018-11-11 8:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Ayman Bagabas, ALSA Development Mailing List, Hui Wang,
Andy Shevchenko, Darren Hart, Jaroslav Kysela, Kailang Yang,
Linux Kernel Mailing List, Platform Driver
On Sat, 10 Nov 2018 15:26:55 +0100,
Andy Shevchenko wrote:
>
> On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
> >
> > Some of Huawei laptops come with a LED in the micmute key. This patch
> > enables and disable this LED accordingly.
> > This enables micmute LED for:
> > 1. Matebook X (19e5:3200), (19e5:3201)
> > 2. Matebook X Pro (19e5:3204)
> >
> > Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> > ---
> > sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
> > sound/pci/hda/patch_realtek.c | 14 ++++++++-
> > 2 files changed, 60 insertions(+), 1 deletion(-)
> > create mode 100644 sound/pci/hda/huawei_wmi_helper.c
> >
> > diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
> > new file mode 100644
> > index 000000000000..7c91f914ffba
> > --- /dev/null
> > +++ b/sound/pci/hda/huawei_wmi_helper.c
> > @@ -0,0 +1,47 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Helper functions for Huawei WMI micmute LED;
> > + * to be included from codec driver
> > + */
> > +
>
> > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
>
> ENABLED or REACHABLE?
FWIW, other similar codes take ENABLED. It's dynamic binding, and the
codec driver may be re-bound even if it's a built-in.
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED
@ 2018-11-11 8:44 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2018-11-11 8:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: ALSA Development Mailing List, Ayman Bagabas,
Linux Kernel Mailing List, Hui Wang, Kailang Yang, Darren Hart,
Platform Driver, Andy Shevchenko
On Sat, 10 Nov 2018 15:26:55 +0100,
Andy Shevchenko wrote:
>
> On Sat, Nov 10, 2018 at 1:46 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
> >
> > Some of Huawei laptops come with a LED in the micmute key. This patch
> > enables and disable this LED accordingly.
> > This enables micmute LED for:
> > 1. Matebook X (19e5:3200), (19e5:3201)
> > 2. Matebook X Pro (19e5:3204)
> >
> > Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> > ---
> > sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++
> > sound/pci/hda/patch_realtek.c | 14 ++++++++-
> > 2 files changed, 60 insertions(+), 1 deletion(-)
> > create mode 100644 sound/pci/hda/huawei_wmi_helper.c
> >
> > diff --git a/sound/pci/hda/huawei_wmi_helper.c b/sound/pci/hda/huawei_wmi_helper.c
> > new file mode 100644
> > index 000000000000..7c91f914ffba
> > --- /dev/null
> > +++ b/sound/pci/hda/huawei_wmi_helper.c
> > @@ -0,0 +1,47 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Helper functions for Huawei WMI micmute LED;
> > + * to be included from codec driver
> > + */
> > +
>
> > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
>
> ENABLED or REACHABLE?
FWIW, other similar codes take ENABLED. It's dynamic binding, and the
codec driver may be re-bound even if it's a built-in.
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-11-11 8:44 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 23:45 [PATCH v4 0/3] Huawei laptops Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-10 14:25 ` Andy Shevchenko
2018-11-09 23:45 ` [PATCH v4 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-09 23:45 ` [PATCH v4 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-11-10 14:26 ` Andy Shevchenko
2018-11-10 14:26 ` Andy Shevchenko
2018-11-11 8:44 ` Takashi Iwai
2018-11-11 8:44 ` Takashi Iwai
2018-11-10 14:17 ` [PATCH v4 0/3] Huawei laptops Andy Shevchenko
2018-11-10 14:18 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.