All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
@ 2018-11-11 16:45 Michał Łyszczek
  2018-11-11 16:56 ` Baruch Siach
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Michał Łyszczek @ 2018-11-11 16:45 UTC (permalink / raw)
  To: buildroot

Rockchip's rk3328 encapsulates the BL31 part of ATP but it needs
image in ELF format. This is extension to
2c4809e6088660dc71de9de8cee0bba312aafbe4

This commit introduces a BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF variable
to achieve this.

Signed-off-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>
Tested-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>

---
Changes v1 -> v2:
  - fix wrong prefix BR_ to BR2_
---
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 7 +++++++
 boot/uboot/Config.in                              | 7 +++++++
 boot/uboot/uboot.mk                               | 4 ++++
 3 files changed, 18 insertions(+)

diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index 23f493653d..8f0f745ac0 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -94,6 +94,12 @@ ARM_TRUSTED_FIRMWARE_MAKE_OPTS += RESET_TO_BL31=1
 ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-uboot-tools
 endif
 
+ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
+define ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF
+	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/bl31/bl31.elf $(BINARIES_DIR)/
+endef
+endif
+
 define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
 	$(ARM_TRUSTED_FIRMWARE_BUILD_FIPTOOL)
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(ARM_TRUSTED_FIRMWARE_MAKE_OPTS) \
@@ -104,6 +110,7 @@ endef
 define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
 	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
+	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
 endef
 
 # Configuration check
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index ac6f8bc8c1..7f2f7945ac 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -179,6 +179,13 @@ config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
 	  variable pointing to ATF's BL31 binary, is passed during the
 	  Buildroot build.
 
+config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
+	bool "U-Boot needs bl31.elf"
+	depends on BR2_TARGET_UBOOT_NEEDS_ATF_BL31
+	help
+		Uses bl31.elf instead of bl31.bin image.  This is needed by some
+		platforms (like rk3328) to generate valid uboot.itb with ATF
+
 menu "U-Boot binary format"
 
 config BR2_TARGET_UBOOT_FORMAT_AIS
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index cbdfee6ac3..06efd7b052 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -137,8 +137,12 @@ UBOOT_MAKE_OPTS += \
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31),y)
 UBOOT_DEPENDENCIES += arm-trusted-firmware
+ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
+UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.elf
+else
 UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.bin
 endif
+endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
 UBOOT_DEPENDENCIES += host-dtc
-- 
2.18.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
  2018-11-11 16:45 [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot Michał Łyszczek
@ 2018-11-11 16:56 ` Baruch Siach
  2018-11-11 17:15   ` michal.lyszczek at bofc.pl
  2018-11-11 20:36 ` Thomas Petazzoni
  2018-11-11 20:37 ` Thomas Petazzoni
  2 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-11-11 16:56 UTC (permalink / raw)
  To: buildroot

Hi Micha?,

Micha? ?yszczek writes:
> Rockchip's rk3328 encapsulates the BL31 part of ATP but it needs
> image in ELF format. This is extension to
> 2c4809e6088660dc71de9de8cee0bba312aafbe4
>
> This commit introduces a BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF variable
> to achieve this.
>
> Signed-off-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>
> Tested-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>
>
> ---
> Changes v1 -> v2:
>   - fix wrong prefix BR_ to BR2_
> ---
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 7 +++++++
>  boot/uboot/Config.in                              | 7 +++++++
>  boot/uboot/uboot.mk                               | 4 ++++
>  3 files changed, 18 insertions(+)
>
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index 23f493653d..8f0f745ac0 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -94,6 +94,12 @@ ARM_TRUSTED_FIRMWARE_MAKE_OPTS += RESET_TO_BL31=1
>  ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-uboot-tools
>  endif
>  
> +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> +define ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF
> +	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/bl31/bl31.elf $(BINARIES_DIR)/
> +endef
> +endif

Why not add this 'ifeq' into ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL ...

> +
>  define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
>  	$(ARM_TRUSTED_FIRMWARE_BUILD_FIPTOOL)
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(ARM_TRUSTED_FIRMWARE_MAKE_OPTS) \
> @@ -104,6 +110,7 @@ endef
>  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
>  	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
>  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
> +	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)

... and drop this part.

>  endef
>  
>  # Configuration check
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index ac6f8bc8c1..7f2f7945ac 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -179,6 +179,13 @@ config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
>  	  variable pointing to ATF's BL31 binary, is passed during the
>  	  Buildroot build.
>  
> +config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
> +	bool "U-Boot needs bl31.elf"
> +	depends on BR2_TARGET_UBOOT_NEEDS_ATF_BL31
> +	help
> +		Uses bl31.elf instead of bl31.bin image.  This is needed by some
> +		platforms (like rk3328) to generate valid uboot.itb with ATF
> +
>  menu "U-Boot binary format"
>  
>  config BR2_TARGET_UBOOT_FORMAT_AIS
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index cbdfee6ac3..06efd7b052 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -137,8 +137,12 @@ UBOOT_MAKE_OPTS += \
>  
>  ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31),y)
>  UBOOT_DEPENDENCIES += arm-trusted-firmware
> +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> +UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.elf
> +else
>  UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.bin
>  endif
> +endif
>  
>  ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
>  UBOOT_DEPENDENCIES += host-dtc

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
  2018-11-11 16:56 ` Baruch Siach
@ 2018-11-11 17:15   ` michal.lyszczek at bofc.pl
  0 siblings, 0 replies; 6+ messages in thread
From: michal.lyszczek at bofc.pl @ 2018-11-11 17:15 UTC (permalink / raw)
  To: buildroot

On 2018-11-11 18:56:17, Baruch Siach wrote:
Hi Baruch

> > +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> > +define ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF
> > +	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/bl31/bl31.elf $(BINARIES_DIR)/
> > +endef
> > +endif
> 
> Why not add this 'ifeq' into ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL ...
> 
> > +
> >  define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
> >  	$(ARM_TRUSTED_FIRMWARE_BUILD_FIPTOOL)
> >  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(ARM_TRUSTED_FIRMWARE_MAKE_OPTS) \
> > @@ -104,6 +110,7 @@ endef
> >  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> >  	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
> >  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
> > +	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
> 
> ... and drop this part.
> 

Because ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL is inside
BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT ifeq and that option is not
required for my change. What's more, ATP won't build for rk3328 when
BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT is enabled, because some
functions are no implemented and undefined reference error occurs.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
  2018-11-11 16:45 [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot Michał Łyszczek
  2018-11-11 16:56 ` Baruch Siach
@ 2018-11-11 20:36 ` Thomas Petazzoni
  2018-11-11 21:28   ` michal.lyszczek at bofc.pl
  2018-11-11 20:37 ` Thomas Petazzoni
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-11-11 20:36 UTC (permalink / raw)
  To: buildroot

Hello,

Thanks for this contribution!

On Sun, 11 Nov 2018 17:45:32 +0100, Micha? ?yszczek wrote:

> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index 23f493653d..8f0f745ac0 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -94,6 +94,12 @@ ARM_TRUSTED_FIRMWARE_MAKE_OPTS += RESET_TO_BL31=1
>  ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-uboot-tools
>  endif
>  
> +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> +define ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF
> +	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/bl31/bl31.elf $(BINARIES_DIR)/
> +endef
> +endif
> +
>  define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
>  	$(ARM_TRUSTED_FIRMWARE_BUILD_FIPTOOL)
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(ARM_TRUSTED_FIRMWARE_MAKE_OPTS) \
> @@ -104,6 +110,7 @@ endef
>  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
>  	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
>  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
> +	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
>  endef
>  
>  # Configuration check
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index ac6f8bc8c1..7f2f7945ac 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -179,6 +179,13 @@ config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
>  	  variable pointing to ATF's BL31 binary, is passed during the
>  	  Buildroot build.
>  
> +config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
> +	bool "U-Boot needs bl31.elf"
> +	depends on BR2_TARGET_UBOOT_NEEDS_ATF_BL31
> +	help
> +		Uses bl31.elf instead of bl31.bin image.  This is needed by some
> +		platforms (like rk3328) to generate valid uboot.itb with ATF

Nit: the indentation for the help text should be one tab + two spaces.

>  ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31),y)
>  UBOOT_DEPENDENCIES += arm-trusted-firmware
> +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> +UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.elf
> +else
>  UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.bin
>  endif

So this code means that you can either use the bl31 as ELF *or* the
bl31 as binary. So I believe it should not be possible to select both.
Therefore, I would suggest to instead have:

config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
        bool "U-Boot needs ATF BL31"
	... as it already exists ...

choice
	prompt "U-Boot ATF BL31 format"
	default BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN

config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN
	bool "bl31.bin"

config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
	bool "bl31.elf"

endchoice

And then use that in both arm-trusted-firmware.mk and uboot.mk.

What do you think ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
  2018-11-11 16:45 [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot Michał Łyszczek
  2018-11-11 16:56 ` Baruch Siach
  2018-11-11 20:36 ` Thomas Petazzoni
@ 2018-11-11 20:37 ` Thomas Petazzoni
  2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-11-11 20:37 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 11 Nov 2018 17:45:32 +0100, Micha? ?yszczek wrote:
> Rockchip's rk3328 encapsulates the BL31 part of ATP but it needs
> image in ELF format. This is extension to
> 2c4809e6088660dc71de9de8cee0bba312aafbe4
> 
> This commit introduces a BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF variable
> to achieve this.
> 
> Signed-off-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>
> Tested-by: Micha? ?yszczek <michal.lyszczek@bofc.pl>

Another small comment: there is no need to have your own Tested-by.
Indeed, when you send a patch, we expect that you have tested it :-)

Tested-by are useful when other people than the patch author give their
Tested-by.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot
  2018-11-11 20:36 ` Thomas Petazzoni
@ 2018-11-11 21:28   ` michal.lyszczek at bofc.pl
  0 siblings, 0 replies; 6+ messages in thread
From: michal.lyszczek at bofc.pl @ 2018-11-11 21:28 UTC (permalink / raw)
  To: buildroot

On 2018-11-11 21:36:47, Thomas Petazzoni wrote:
> Hello,
> 
> Thanks for this contribution!
> 
> On Sun, 11 Nov 2018 17:45:32 +0100, Micha? ?yszczek wrote:
> 
> > diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> > index 23f493653d..8f0f745ac0 100644
> > --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> > +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> > @@ -94,6 +94,12 @@ ARM_TRUSTED_FIRMWARE_MAKE_OPTS += RESET_TO_BL31=1
> >  ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-uboot-tools
> >  endif
> >  
> > +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> > +define ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF
> > +	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/bl31/bl31.elf $(BINARIES_DIR)/
> > +endef
> > +endif
> > +
> >  define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
> >  	$(ARM_TRUSTED_FIRMWARE_BUILD_FIPTOOL)
> >  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(ARM_TRUSTED_FIRMWARE_MAKE_OPTS) \
> > @@ -104,6 +110,7 @@ endef
> >  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> >  	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
> >  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
> > +	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
> >  endef
> >  
> >  # Configuration check
> > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> > index ac6f8bc8c1..7f2f7945ac 100644
> > --- a/boot/uboot/Config.in
> > +++ b/boot/uboot/Config.in
> > @@ -179,6 +179,13 @@ config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
> >  	  variable pointing to ATF's BL31 binary, is passed during the
> >  	  Buildroot build.
> >  
> > +config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
> > +	bool "U-Boot needs bl31.elf"
> > +	depends on BR2_TARGET_UBOOT_NEEDS_ATF_BL31
> > +	help
> > +		Uses bl31.elf instead of bl31.bin image.  This is needed by some
> > +		platforms (like rk3328) to generate valid uboot.itb with ATF
> 
> Nit: the indentation for the help text should be one tab + two spaces.

Oops, didn't notice, fixed.
> >  ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31),y)
> >  UBOOT_DEPENDENCIES += arm-trusted-firmware
> > +ifeq ($(BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF),y)
> > +UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.elf
> > +else
> >  UBOOT_MAKE_OPTS += BL31=$(BINARIES_DIR)/bl31.bin
> >  endif
> 
> So this code means that you can either use the bl31 as ELF *or* the
> bl31 as binary. So I believe it should not be possible to select both.
> Therefore, I would suggest to instead have:
> 
> config BR2_TARGET_UBOOT_NEEDS_ATF_BL31
>         bool "U-Boot needs ATF BL31"
> 	... as it already exists ...
> 
> choice
> 	prompt "U-Boot ATF BL31 format"
> 	default BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN
> 
> config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_BIN
> 	bool "bl31.bin"
> 
> config BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF
> 	bool "bl31.elf"
> 
> endchoice
> 
> And then use that in both arm-trusted-firmware.mk and uboot.mk.
> 
> What do you think ?

This is definately better option. And it even looks I won't have to
change anything other than uboot's Config.in.

I was also thinking to delete this line when elf is used:

> cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/

But since it's wildcard I'd leave it as is. This will cause bl31.bin to
be copied to $BINARIES_DIR alongside with bl31.elf, but it may be possible
someone will need to have, let's say bl31.elf but bl32.bin, and removing
this line would takie this option away from him.

I will prepare new patch shortly.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-11 21:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-11 16:45 [Buildroot] [PATCH v2] uboot: add support for bundling ATF BL31 in ELF format into U-Boot Michał Łyszczek
2018-11-11 16:56 ` Baruch Siach
2018-11-11 17:15   ` michal.lyszczek at bofc.pl
2018-11-11 20:36 ` Thomas Petazzoni
2018-11-11 21:28   ` michal.lyszczek at bofc.pl
2018-11-11 20:37 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.