[Buildroot] [PATCH 1/1] libmicrohttpd: fix build on riscv

[Buildroot] [PATCH 1/1] libmicrohttpd: fix build on riscv

[Fabrice Fontaine]

Define _REENTRANT like already done for ARC otherwise pthread detection
will fail

Fixes:
 - https://autobuild.buildroot.org/results/910dc7164312637bf4dcd89e4cb476ae198466c8

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libmicrohttpd/libmicrohttpd.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libmicrohttpd/libmicrohttpd.mk b/package/libmicrohttpd/libmicrohttpd.mk
index 1cda434819..c22ad08478 100644
--- a/package/libmicrohttpd/libmicrohttpd.mk
+++ b/package/libmicrohttpd/libmicrohttpd.mk
@@ -11,10 +11,10 @@ LIBMICROHTTPD_INSTALL_STAGING = YES
 LIBMICROHTTPD_CONF_OPTS = --disable-curl --disable-examples
 LIBMICROHTTPD_CFLAGS = $(TARGET_CFLAGS) -std=c99
 
-# gcc on arc doesn't define _REENTRANT when -pthread is passed while
+# gcc on arc and riscv doesn't define _REENTRANT when -pthread is passed while
 # it should. Compensate this deficiency here otherwise libmicrohttpd
 # configure script doesn't find that thread support is enabled.
-ifeq ($(BR2_arc),y)
+ifeq ($(BR2_arc)$(BR2_riscv),y)
 LIBMICROHTTPD_CFLAGS += -D_REENTRANT
 endif
 
-- 
2.17.1

[Buildroot] [PATCH 1/1] libmicrohttpd: fix build on riscv

[Thomas Petazzoni]

Hello,

+Mark Corbin in Cc.

On Sat, 10 Nov 2018 17:00:28 +0100, Fabrice Fontaine wrote:
> Define _REENTRANT like already done for ARC otherwise pthread detection
> will fail
> 
> Fixes:
>  - https://autobuild.buildroot.org/results/910dc7164312637bf4dcd89e4cb476ae198466c8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libmicrohttpd/libmicrohttpd.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Mark: could you report upstream to the RISC-V gcc developers that the
gcc port should define _REENTRANT when -pthread is passed ?

I.E, most platforms do some variations of:

#define SUBTARGET_CPP_SPEC  "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"

in their gcc/config/<ARCH>/linux.h file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com