All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] imx-uuc: bump revision to 79e9798e
@ 2018-11-12  9:44 Gary Bisson
  2018-11-13 21:08 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Gary Bisson @ 2018-11-12  9:44 UTC (permalink / raw)
  To: buildroot

Main changes:
- fix build error by gcc 8.2
- re-factor the code
- use unique CPU ID when available
- improve UDC management

Fixes:
http://autobuild.buildroot.net/results/b39d56c1573308c4f947de23363da7c05e2aaf0d/

Also switch back the repository from codeauroraforum to NXPmicro now
that the Qualcomm/NXP merger was denied.

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
 package/freescale-imx/imx-uuc/imx-uuc.hash | 2 +-
 package/freescale-imx/imx-uuc/imx-uuc.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/freescale-imx/imx-uuc/imx-uuc.hash b/package/freescale-imx/imx-uuc/imx-uuc.hash
index c9c29f8692..623bd27644 100644
--- a/package/freescale-imx/imx-uuc/imx-uuc.hash
+++ b/package/freescale-imx/imx-uuc/imx-uuc.hash
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 1463e855d1229e6b6c02df2085f6bff5974bc061d13a61646b63675c160cba99  imx-uuc-2ae634281a39c82b6a8ee0fdcfbfbe42183ceb53.tar.gz
+sha256 ac4960b9dc53cfd09709951c4bf1f774567ff0918d0b216b480e1f7df8c6ee48  imx-uuc-79e9798eee9cd972d92ed2b18f170de856d153c9.tar.gz
diff --git a/package/freescale-imx/imx-uuc/imx-uuc.mk b/package/freescale-imx/imx-uuc/imx-uuc.mk
index 5e0bb3be0e..bdfa51b171 100644
--- a/package/freescale-imx/imx-uuc/imx-uuc.mk
+++ b/package/freescale-imx/imx-uuc/imx-uuc.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-IMX_UUC_VERSION = 2ae634281a39c82b6a8ee0fdcfbfbe42183ceb53
-IMX_UUC_SITE = $(call github,codeauroraforum,imx-uuc,$(IMX_UUC_VERSION))
+IMX_UUC_VERSION = 79e9798eee9cd972d92ed2b18f170de856d153c9
+IMX_UUC_SITE = $(call github,NXPmicro,imx-uuc,$(IMX_UUC_VERSION))
 IMX_UUC_LICENSE = GPL-2.0+
 IMX_UUC_LICENSE_FILES = COPYING
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] imx-uuc: bump revision to 79e9798e
  2018-11-12  9:44 [Buildroot] [PATCH] imx-uuc: bump revision to 79e9798e Gary Bisson
@ 2018-11-13 21:08 ` Thomas Petazzoni
  2018-11-14  9:29   ` Gary Bisson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-13 21:08 UTC (permalink / raw)
  To: buildroot

Hello Gary,

On Mon, 12 Nov 2018 10:44:02 +0100, Gary Bisson wrote:
> Main changes:
> - fix build error by gcc 8.2

I know it is what the upstream commit says, but the makedev() issue has
nothing to do with gcc 8.2, but with glibc 2.28. I fixed up the commit
log on that aspect.

To be honest, I hesitated a bit because we normally don't take version
bumps in master at this point. However, this is a fairly small
and not that widely used package, the number of upstream changes is not
enormous, so I applied it to master. But I really hesitated with asking
for just a backport of the glibc 2.28 fix instead.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] imx-uuc: bump revision to 79e9798e
  2018-11-13 21:08 ` Thomas Petazzoni
@ 2018-11-14  9:29   ` Gary Bisson
  0 siblings, 0 replies; 3+ messages in thread
From: Gary Bisson @ 2018-11-14  9:29 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On Tue, Nov 13, 2018 at 10:08 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Gary,
>
> On Mon, 12 Nov 2018 10:44:02 +0100, Gary Bisson wrote:
> > Main changes:
> > - fix build error by gcc 8.2
>
> I know it is what the upstream commit says, but the makedev() issue has
> nothing to do with gcc 8.2, but with glibc 2.28. I fixed up the commit
> log on that aspect.

Thanks, I actually didn't even dig deeper once I saw that this commit
was fixing the exact same error.

> To be honest, I hesitated a bit because we normally don't take version
> bumps in master at this point. However, this is a fairly small
> and not that widely used package, the number of upstream changes is not
> enormous, so I applied it to master. But I really hesitated with asking
> for just a backport of the glibc 2.28 fix instead.

I understand, but note that there are a couple of other patches in
that bump that also fix some other possible build issues (although the
titles aren't very useful):
e05cc55 fix build error when gcc over 7.0
7c7562b fix build error

So really a version bump seemed like the easy route instead of
backporting all those patches.
But I understand it isn't ideal at this stage of the 2018.11 release.

Regards,
Gary

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-14  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12  9:44 [Buildroot] [PATCH] imx-uuc: bump revision to 79e9798e Gary Bisson
2018-11-13 21:08 ` Thomas Petazzoni
2018-11-14  9:29   ` Gary Bisson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.