All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: fix broadwell EU computation
@ 2018-11-12 12:39 Lionel Landwerlin
  2018-11-12 13:14 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Lionel Landwerlin @ 2018-11-12 12:39 UTC (permalink / raw)
  To: intel-gfx

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
 drivers/gpu/drm/i915/intel_device_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 89ed3a84a4fa..ceecb5bd5226 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
 			u8 eu_disabled_mask;
 			u32 n_disabled;
 
-			if (!(sseu->subslice_mask[ss] & BIT(ss)))
+			if (!(sseu->subslice_mask[s] & BIT(ss)))
 				/* skip disabled subslice */
 				continue;
 
-- 
2.19.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: fix broadwell EU computation
  2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
@ 2018-11-12 13:14 ` Patchwork
  2018-11-12 14:58 ` ✓ Fi.CI.IGT: " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-11-12 13:14 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: fix broadwell EU computation
URL   : https://patchwork.freedesktop.org/series/52355/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5121 -> Patchwork_10802 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52355/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10802 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@kms_flip@basic-flip-vs-modeset:
      fi-hsw-4770r:       DMESG-WARN (fdo#105602) -> PASS

    
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602


== Participating hosts (50 -> 45) ==

  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_5121 -> Patchwork_10802

  CI_DRM_5121: e2bd5e4c200971836c4f58e5c9c6df1a2f8b5e1f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10802: 4b87ee767073c8ae518a6a154278c20c0171fe81 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

4b87ee767073 drm/i915: fix broadwell EU computation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10802/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: fix broadwell EU computation
  2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
  2018-11-12 13:14 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-12 14:58 ` Patchwork
  2018-11-12 15:44 ` [PATCH] " Chris Wilson
  2018-11-12 15:57 ` Tvrtko Ursulin
  3 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-11-12 14:58 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: fix broadwell EU computation
URL   : https://patchwork.freedesktop.org/series/52355/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5121_full -> Patchwork_10802_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_10802_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10802_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10802_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_10802_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@fence-restore-tiled2untiled:
      shard-skl:          PASS -> INCOMPLETE (fdo#107773, fdo#104108)

    igt@kms_color@pipe-a-ctm-0-75:
      shard-skl:          PASS -> FAIL (fdo#108682)

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          NOTRUN -> FAIL (fdo#106509, fdo#105454)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-glk:          PASS -> FAIL (fdo#103167) +2

    igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
      shard-skl:          PASS -> FAIL (fdo#103166)

    igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
      shard-skl:          NOTRUN -> FAIL (fdo#108145)

    igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
      shard-skl:          PASS -> FAIL (fdo#107815)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
      shard-glk:          PASS -> FAIL (fdo#103166)

    igt@kms_setmode@basic:
      shard-hsw:          PASS -> FAIL (fdo#99912)

    igt@kms_sysfs_edid_timing:
      shard-skl:          NOTRUN -> FAIL (fdo#100047)

    igt@kms_universal_plane@universal-plane-pipe-a-functional:
      shard-apl:          PASS -> FAIL (fdo#103166) +1

    igt@perf_pmu@busy-start-vcs0:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-skl:          INCOMPLETE (fdo#106886) -> PASS

    igt@gem_cpu_reloc@full:
      shard-skl:          INCOMPLETE (fdo#108073) -> PASS

    igt@gem_userptr_blits@readonly-unsync:
      shard-skl:          INCOMPLETE (fdo#108074) -> PASS

    igt@kms_cursor_crc@cursor-256x256-onscreen:
      shard-skl:          FAIL (fdo#103232) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-glk:          FAIL (fdo#103167) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
      shard-skl:          FAIL (fdo#105682) -> PASS

    igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
      shard-skl:          FAIL (fdo#103167) -> PASS +1

    igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
      shard-glk:          FAIL (fdo#108145) -> PASS +1

    igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
      shard-skl:          FAIL (fdo#108145, fdo#107815) -> PASS

    igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
      shard-skl:          FAIL (fdo#107815) -> PASS

    igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
      shard-glk:          FAIL (fdo#103166) -> PASS
      shard-apl:          FAIL (fdo#103166) -> PASS

    igt@kms_psr@suspend:
      shard-skl:          INCOMPLETE (fdo#107773) -> PASS

    igt@perf@short-reads:
      shard-skl:          FAIL (fdo#103183) -> PASS

    igt@pm_rpm@universal-planes-dpms:
      shard-skl:          INCOMPLETE (fdo#107807) -> PASS

    
    ==== Warnings ====

    igt@kms_vblank@pipe-a-query-busy:
      shard-snb:          DMESG-WARN (fdo#107469) -> INCOMPLETE (fdo#105411)

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103183 https://bugs.freedesktop.org/show_bug.cgi?id=103183
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
  fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
  fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108682 https://bugs.freedesktop.org/show_bug.cgi?id=108682
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_5121 -> Patchwork_10802

  CI_DRM_5121: e2bd5e4c200971836c4f58e5c9c6df1a2f8b5e1f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10802: 4b87ee767073c8ae518a6a154278c20c0171fe81 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10802/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
  2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
  2018-11-12 13:14 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-11-12 14:58 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-12 15:44 ` Chris Wilson
  2018-11-12 15:57 ` Tvrtko Ursulin
  3 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-11-12 15:44 UTC (permalink / raw)
  To: Lionel Landwerlin, intel-gfx

Quoting Lionel Landwerlin (2018-11-12 12:39:31)
> subslice_mask is an array indexed by slice, not subslice.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 89ed3a84a4fa..ceecb5bd5226 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
>                         u8 eu_disabled_mask;
>                         u32 n_disabled;
>  
> -                       if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +                       if (!(sseu->subslice_mask[s] & BIT(ss)))

Tallies up with the other users.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
  2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
                   ` (2 preceding siblings ...)
  2018-11-12 15:44 ` [PATCH] " Chris Wilson
@ 2018-11-12 15:57 ` Tvrtko Ursulin
  2018-11-12 17:42   ` Lionel Landwerlin
  3 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2018-11-12 15:57 UTC (permalink / raw)
  To: Lionel Landwerlin, intel-gfx


On 12/11/2018 12:39, Lionel Landwerlin wrote:
> subslice_mask is an array indexed by slice, not subslice.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 89ed3a84a4fa..ceecb5bd5226 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
>   			u8 eu_disabled_mask;
>   			u32 n_disabled;
>   
> -			if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +			if (!(sseu->subslice_mask[s] & BIT(ss)))
>   				/* skip disabled subslice */
>   				continue;
>   
> 
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
  2018-11-12 15:57 ` Tvrtko Ursulin
@ 2018-11-12 17:42   ` Lionel Landwerlin
  0 siblings, 0 replies; 11+ messages in thread
From: Lionel Landwerlin @ 2018-11-12 17:42 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx

On 12/11/2018 15:57, Tvrtko Ursulin wrote:
>
> On 12/11/2018 12:39, Lionel Landwerlin wrote:
>> subslice_mask is an array indexed by slice, not subslice.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
>> ---
>>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
>> b/drivers/gpu/drm/i915/intel_device_info.c
>> index 89ed3a84a4fa..ceecb5bd5226 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
>> drm_i915_private *dev_priv)
>>               u8 eu_disabled_mask;
>>               u32 n_disabled;
>>   -            if (!(sseu->subslice_mask[ss] & BIT(ss)))
>> +            if (!(sseu->subslice_mask[s] & BIT(ss)))
>>                   /* skip disabled subslice */
>>                   continue;
>>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Regards,
>
> Tvrtko
>
Thanks all, pushed.


-

Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
  2019-08-28 21:22   ` Lionel Landwerlin
@ 2019-08-29 21:02     ` Sasha Levin
  -1 siblings, 0 replies; 11+ messages in thread
From: Sasha Levin @ 2019-08-29 21:02 UTC (permalink / raw)
  To: Lionel Landwerlin
  Cc: Rodrigo Vivi, stable, intel-gfx, dmitry.v.rogozhkin,
	Chris Wilson, Tvrtko Ursulin, Joonas Lahtinen

On Thu, Aug 29, 2019 at 12:22:27AM +0300, Lionel Landwerlin wrote:
>On 29/08/2019 00:02, Rodrigo Vivi wrote:
>>From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>
>>commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.
>>
>>subslice_mask is an array indexed by slice, not subslice.
>>
>>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
>>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
>>Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com
>>(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
>>Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>Cc: <stable@vger.kernel.org> # 4.17
>
>
>Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
>it to stable.
>
>The same bug showed up on a CentOS kernel : 
>https://github.com/intel/compute-runtime/issues/200

I just queued the upstream patch for 4.19, thanks!

--
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
@ 2019-08-29 21:02     ` Sasha Levin
  0 siblings, 0 replies; 11+ messages in thread
From: Sasha Levin @ 2019-08-29 21:02 UTC (permalink / raw)
  To: Lionel Landwerlin
  Cc: Rodrigo Vivi, stable, intel-gfx, dmitry.v.rogozhkin,
	Chris Wilson, Tvrtko Ursulin, Joonas Lahtinen

On Thu, Aug 29, 2019 at 12:22:27AM +0300, Lionel Landwerlin wrote:
>On 29/08/2019 00:02, Rodrigo Vivi wrote:
>>From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>
>>commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.
>>
>>subslice_mask is an array indexed by slice, not subslice.
>>
>>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
>>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
>>Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com
>>(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
>>Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>Cc: <stable@vger.kernel.org> # 4.17
>
>
>Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
>it to stable.
>
>The same bug showed up on a CentOS kernel : 
>https://github.com/intel/compute-runtime/issues/200

I just queued the upstream patch for 4.19, thanks!

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
  2019-08-28 21:02 Rodrigo Vivi
@ 2019-08-28 21:22   ` Lionel Landwerlin
  0 siblings, 0 replies; 11+ messages in thread
From: Lionel Landwerlin @ 2019-08-28 21:22 UTC (permalink / raw)
  To: Rodrigo Vivi, stable
  Cc: intel-gfx, dmitry.v.rogozhkin, Chris Wilson, Tvrtko Ursulin,
	Joonas Lahtinen

On 29/08/2019 00:02, Rodrigo Vivi wrote:
> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.
>
> subslice_mask is an array indexed by slice, not subslice.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com
> (cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: <stable@vger.kernel.org> # 4.17


Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
it to stable.

The same bug showed up on a CentOS kernel : 
https://github.com/intel/compute-runtime/issues/200

My bad... :(


Thanks for resending!


-Lionel


> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 0ef0c6448d53..01fa98299bae 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
>   			u8 eu_disabled_mask;
>   			u32 n_disabled;
>   
> -			if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +			if (!(sseu->subslice_mask[s] & BIT(ss)))
>   				/* skip disabled subslice */
>   				continue;
>   



^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix broadwell EU computation
@ 2019-08-28 21:22   ` Lionel Landwerlin
  0 siblings, 0 replies; 11+ messages in thread
From: Lionel Landwerlin @ 2019-08-28 21:22 UTC (permalink / raw)
  To: Rodrigo Vivi, stable; +Cc: intel-gfx

On 29/08/2019 00:02, Rodrigo Vivi wrote:
> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.
>
> subslice_mask is an array indexed by slice, not subslice.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com
> (cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: <stable@vger.kernel.org> # 4.17


Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
it to stable.

The same bug showed up on a CentOS kernel : 
https://github.com/intel/compute-runtime/issues/200

My bad... :(


Thanks for resending!


-Lionel


> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 0ef0c6448d53..01fa98299bae 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
>   			u8 eu_disabled_mask;
>   			u32 n_disabled;
>   
> -			if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +			if (!(sseu->subslice_mask[s] & BIT(ss)))
>   				/* skip disabled subslice */
>   				continue;
>   


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] drm/i915: fix broadwell EU computation
@ 2019-08-28 21:02 Rodrigo Vivi
  2019-08-28 21:22   ` Lionel Landwerlin
  0 siblings, 1 reply; 11+ messages in thread
From: Rodrigo Vivi @ 2019-08-28 21:02 UTC (permalink / raw)
  To: stable
  Cc: intel-gfx, dmitry.v.rogozhkin, lionel.g.landwerlin, Chris Wilson,
	Tvrtko Ursulin, Joonas Lahtinen, Rodrigo Vivi

From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwerlin@intel.com
(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: <stable@vger.kernel.org> # 4.17
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_device_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 0ef0c6448d53..01fa98299bae 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
 			u8 eu_disabled_mask;
 			u32 n_disabled;
 
-			if (!(sseu->subslice_mask[ss] & BIT(ss)))
+			if (!(sseu->subslice_mask[s] & BIT(ss)))
 				/* skip disabled subslice */
 				continue;
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-29 21:02 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12 12:39 [PATCH] drm/i915: fix broadwell EU computation Lionel Landwerlin
2018-11-12 13:14 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-12 14:58 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-12 15:44 ` [PATCH] " Chris Wilson
2018-11-12 15:57 ` Tvrtko Ursulin
2018-11-12 17:42   ` Lionel Landwerlin
2019-08-28 21:02 Rodrigo Vivi
2019-08-28 21:22 ` Lionel Landwerlin
2019-08-28 21:22   ` Lionel Landwerlin
2019-08-29 21:02   ` Sasha Levin
2019-08-29 21:02     ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.