* [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated
@ 2018-11-12 10:00 Thomas Huth
2018-11-12 10:58 ` [Qemu-devel] [libvirt] " Peter Krempa
2018-11-12 13:14 ` [Qemu-devel] " Gerd Hoffmann
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2018-11-12 10:00 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann
Cc: libvir-list, Peter Maydell, Paolo Bonzini, Markus Armbruster,
Andrzej Zaborowski, Andrzej Zaborowski
It has been unmaintained since years, and there were only trivial or
tree-wide changes to the related files since many years, so the
code is likely very bitrotten and broken. For example the following
segfaults as soon as as you press a key:
qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -bt device:keyboard
Since we are not aware of anybody using bluetooth with the current
version of QEMU, let's mark the subsystem as deprecated, with a special
request for the users to write to the qemu-devel mailing list in case
they still use it (so we could revert the deprecation status in that
case).
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
qemu-deprecated.texi | 7 +++++++
qemu-options.hx | 4 ++++
vl.c | 4 ++++
3 files changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 5d2d7a3..cb4291f 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -128,6 +128,13 @@ The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and
The ``ivshmem'' device type is replaced by either the ``ivshmem-plain''
or ``ivshmem-doorbell`` device types.
+@subsection bluetooth (since 3.1)
+
+The bluetooth subsystem is unmaintained since many years and likely bitrotten
+quite a bit. It will be removed without replacement unless some users speaks
+up at the @email{qemu-devel@@nongnu.org} mailing list with information about
+their usecases.
+
@section System emulator machines
@subsection pc-0.10 and pc-0.11 (since 3.0)
diff --git a/qemu-options.hx b/qemu-options.hx
index 38c7a97..ee379b3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2772,6 +2772,10 @@ logic. The Transport Layer is decided by the machine type. Currently
the machines @code{n800} and @code{n810} have one HCI and all other
machines have none.
+Note: This option and the whole bluetooth subsystem is considered as deprecated.
+If you still use it, please send a mail to @email{qemu-devel@@nongnu.org} where
+you describe your usecase.
+
@anchor{bt-hcis}
The following three types are recognized:
diff --git a/vl.c b/vl.c
index 55bab00..fa25d1a 100644
--- a/vl.c
+++ b/vl.c
@@ -3269,6 +3269,10 @@ int main(int argc, char **argv, char **envp)
break;
#endif
case QEMU_OPTION_bt:
+ warn_report("The bluetooth subsystem is deprecated and will "
+ "be removed soon. If the bluetooth subsystem is "
+ "still useful for you, please send a mail to "
+ "qemu-devel@nongnu.org with your usecase.");
add_device_config(DEV_BT, optarg);
break;
case QEMU_OPTION_audio_help:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [libvirt] [PATCH] bt: Mark the bluetooth subsystem as deprecated
2018-11-12 10:00 [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated Thomas Huth
@ 2018-11-12 10:58 ` Peter Krempa
2018-11-12 13:14 ` [Qemu-devel] " Gerd Hoffmann
1 sibling, 0 replies; 4+ messages in thread
From: Peter Krempa @ 2018-11-12 10:58 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Gerd Hoffmann, Peter Maydell, libvir-list,
Andrzej Zaborowski, Paolo Bonzini, Andrzej Zaborowski
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Mon, Nov 12, 2018 at 11:00:30 +0100, Thomas Huth wrote:
> It has been unmaintained since years, and there were only trivial or
> tree-wide changes to the related files since many years, so the
> code is likely very bitrotten and broken. For example the following
> segfaults as soon as as you press a key:
>
> qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -bt device:keyboard
>
> Since we are not aware of anybody using bluetooth with the current
> version of QEMU, let's mark the subsystem as deprecated, with a special
> request for the users to write to the qemu-devel mailing list in case
> they still use it (so we could revert the deprecation status in that
> case).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qemu-deprecated.texi | 7 +++++++
> qemu-options.hx | 4 ++++
> vl.c | 4 ++++
> 3 files changed, 15 insertions(+)
libvirt never implemented any configuration option for bluetooth
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated
2018-11-12 10:00 [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated Thomas Huth
2018-11-12 10:58 ` [Qemu-devel] [libvirt] " Peter Krempa
@ 2018-11-12 13:14 ` Gerd Hoffmann
2018-11-12 13:23 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
1 sibling, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2018-11-12 13:14 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, libvir-list, Peter Maydell, Paolo Bonzini,
Markus Armbruster, Andrzej Zaborowski, Andrzej Zaborowski
On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote:
> It has been unmaintained since years, and there were only trivial or
> tree-wide changes to the related files since many years, so the
> code is likely very bitrotten and broken. For example the following
> segfaults as soon as as you press a key:
>
> qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -bt device:keyboard
>
> Since we are not aware of anybody using bluetooth with the current
> version of QEMU, let's mark the subsystem as deprecated, with a special
> request for the users to write to the qemu-devel mailing list in case
> they still use it (so we could revert the deprecation status in that
> case).
I think that settles the bluetooth debate for now. We deprecate it,
wait for feedback, possibly un-deprecate (parts of) the code. Next
year we'll actually remove the unused code.
Patch queued for 3.1.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [libvirt] [PATCH] bt: Mark the bluetooth subsystem as deprecated
2018-11-12 13:14 ` [Qemu-devel] " Gerd Hoffmann
@ 2018-11-12 13:23 ` Daniel P. Berrangé
0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2018-11-12 13:23 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Thomas Huth, Peter Maydell, libvir-list, qemu-devel,
Andrzej Zaborowski, Paolo Bonzini, Andrzej Zaborowski
On Mon, Nov 12, 2018 at 02:14:02PM +0100, Gerd Hoffmann wrote:
> On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote:
> > It has been unmaintained since years, and there were only trivial or
> > tree-wide changes to the related files since many years, so the
> > code is likely very bitrotten and broken. For example the following
> > segfaults as soon as as you press a key:
> >
> > qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -bt device:keyboard
> >
> > Since we are not aware of anybody using bluetooth with the current
> > version of QEMU, let's mark the subsystem as deprecated, with a special
> > request for the users to write to the qemu-devel mailing list in case
> > they still use it (so we could revert the deprecation status in that
> > case).
>
> I think that settles the bluetooth debate for now. We deprecate it,
> wait for feedback, possibly un-deprecate (parts of) the code. Next
> year we'll actually remove the unused code.
>
> Patch queued for 3.1.
FWIW, libvirt has never exposed any of the bluetooth functionality, so
no objections to removing it from our side.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-12 13:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12 10:00 [Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated Thomas Huth
2018-11-12 10:58 ` [Qemu-devel] [libvirt] " Peter Krempa
2018-11-12 13:14 ` [Qemu-devel] " Gerd Hoffmann
2018-11-12 13:23 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.