* Re: [RFC PATCH v1 02/10] s390/cio: Fix cleanup when unsupported IDA format is used
[not found] <9d254ea1-99f6-0a8c-3a95-b7dd9a70c262@linux.ibm.com>
@ 2018-11-12 12:43 ` Halil Pasic
0 siblings, 0 replies; 2+ messages in thread
From: Halil Pasic @ 2018-11-12 12:43 UTC (permalink / raw)
To: linux-s390, kvm
On Fri, 9 Nov 2018 03:39:29 +0100
Eric Farman <farman@linux.ibm.com> wrote:
> Direct returns from within a loop are rude, but it doesn't mean it
> gets to avoid releasing the memory acquired beforehand.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_cp.c
> b/drivers/s390/cio/vfio_ccw_cp.c index ef5ab45d94b3..70a006ba4d05
> 100644 --- a/drivers/s390/cio/vfio_ccw_cp.c
> +++ b/drivers/s390/cio/vfio_ccw_cp.c
> @@ -387,8 +387,10 @@ static int ccwchain_calc_length(u64 iova, struct
> channel_program *cp)
> * orb specified one of the unsupported formats, we
> defer
> * checking for IDAWs in unsupported formats to here.
> */
> - if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) &&
> ccw_is_idal(ccw))
> + if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) &&
> ccw_is_idal(ccw)) {
> + kfree(p);
> return -EOPNOTSUPP;
> + }
>
> if ((!ccw_is_chain(ccw)) && (!ccw_is_tic(ccw)))
> break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH v1 02/10] s390/cio: Fix cleanup when unsupported IDA format is used
@ 2018-11-09 2:39 Eric Farman
0 siblings, 0 replies; 2+ messages in thread
From: Eric Farman @ 2018-11-09 2:39 UTC (permalink / raw)
To: linux-s390
Direct returns from within a loop are rude, but it doesn't mean it gets
to avoid releasing the memory acquired beforehand.
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
drivers/s390/cio/vfio_ccw_cp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
index ef5ab45d94b3..70a006ba4d05 100644
--- a/drivers/s390/cio/vfio_ccw_cp.c
+++ b/drivers/s390/cio/vfio_ccw_cp.c
@@ -387,8 +387,10 @@ static int ccwchain_calc_length(u64 iova, struct channel_program *cp)
* orb specified one of the unsupported formats, we defer
* checking for IDAWs in unsupported formats to here.
*/
- if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) && ccw_is_idal(ccw))
+ if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) && ccw_is_idal(ccw)) {
+ kfree(p);
return -EOPNOTSUPP;
+ }
if ((!ccw_is_chain(ccw)) && (!ccw_is_tic(ccw)))
break;
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-12 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <9d254ea1-99f6-0a8c-3a95-b7dd9a70c262@linux.ibm.com>
2018-11-12 12:43 ` [RFC PATCH v1 02/10] s390/cio: Fix cleanup when unsupported IDA format is used Halil Pasic
2018-11-09 2:39 Eric Farman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.