From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Cristian Sicilia <sicilia.cristian@gmail.com> Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>, linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL. Date: Mon, 12 Nov 2018 14:46:36 -0800 [thread overview] Message-ID: <20181112224636.GA12671@kroah.com> (raw) In-Reply-To: <1542055439-24444-2-git-send-email-sicilia.cristian@gmail.com> On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> > --- > drivers/staging/erofs/unzip_vle.c | 86 +++++++++++++++++++-------------------- > 1 file changed, 43 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c > index 79d3ba6..1ffeeaa 100644 > --- a/drivers/staging/erofs/unzip_vle.c > +++ b/drivers/staging/erofs/unzip_vle.c > @@ -20,8 +20,8 @@ static struct kmem_cache *z_erofs_workgroup_cachep __read_mostly; > > void z_erofs_exit_zip_subsystem(void) > { > - BUG_ON(z_erofs_workqueue == NULL); > - BUG_ON(z_erofs_workgroup_cachep == NULL); > + BUG_ON(!z_erofs_workqueue); > + BUG_ON(!z_erofs_workgroup_cachep); Long-term, all of these BUG_ON need to be removed as they imply that the developer has no idea what went wrong and can not recover. For something like this, we "know" these will be fine and odds are they can just be removed entirely. > > destroy_workqueue(z_erofs_workqueue); > kmem_cache_destroy(z_erofs_workgroup_cachep); > @@ -39,7 +39,7 @@ static inline int init_unzip_workqueue(void) > WQ_UNBOUND | WQ_HIGHPRI | WQ_CPU_INTENSIVE, > onlinecpus + onlinecpus / 4); > > - return z_erofs_workqueue != NULL ? 0 : -ENOMEM; > + return z_erofs_workqueue ? 0 : -ENOMEM; I hate ?: notation that is not in a function parameter, any way you can just change this to: if (z_erofs_workqueue) return 0; return -ENOMEM; Christian, this isn't your fault at all, I'm not rejecting this patch, just providing hints on what else you can do here :) thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Subject: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL. Date: Mon, 12 Nov 2018 14:46:36 -0800 [thread overview] Message-ID: <20181112224636.GA12671@kroah.com> (raw) In-Reply-To: <1542055439-24444-2-git-send-email-sicilia.cristian@gmail.com> On Mon, Nov 12, 2018@09:43:57PM +0100, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia <sicilia.cristian at gmail.com> > --- > drivers/staging/erofs/unzip_vle.c | 86 +++++++++++++++++++-------------------- > 1 file changed, 43 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c > index 79d3ba6..1ffeeaa 100644 > --- a/drivers/staging/erofs/unzip_vle.c > +++ b/drivers/staging/erofs/unzip_vle.c > @@ -20,8 +20,8 @@ static struct kmem_cache *z_erofs_workgroup_cachep __read_mostly; > > void z_erofs_exit_zip_subsystem(void) > { > - BUG_ON(z_erofs_workqueue == NULL); > - BUG_ON(z_erofs_workgroup_cachep == NULL); > + BUG_ON(!z_erofs_workqueue); > + BUG_ON(!z_erofs_workgroup_cachep); Long-term, all of these BUG_ON need to be removed as they imply that the developer has no idea what went wrong and can not recover. For something like this, we "know" these will be fine and odds are they can just be removed entirely. > > destroy_workqueue(z_erofs_workqueue); > kmem_cache_destroy(z_erofs_workgroup_cachep); > @@ -39,7 +39,7 @@ static inline int init_unzip_workqueue(void) > WQ_UNBOUND | WQ_HIGHPRI | WQ_CPU_INTENSIVE, > onlinecpus + onlinecpus / 4); > > - return z_erofs_workqueue != NULL ? 0 : -ENOMEM; > + return z_erofs_workqueue ? 0 : -ENOMEM; I hate ?: notation that is not in a function parameter, any way you can just change this to: if (z_erofs_workqueue) return 0; return -ENOMEM; Christian, this isn't your fault at all, I'm not rejecting this patch, just providing hints on what else you can do here :) thanks, greg k-h
next prev parent reply other threads:[~2018-11-12 22:46 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-12 20:43 [PATCH 0/3] Clean up some syntax issue on unzip_vle.c Cristian Sicilia 2018-11-12 20:43 ` Cristian Sicilia 2018-11-12 20:43 ` [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL Cristian Sicilia 2018-11-12 20:43 ` Cristian Sicilia 2018-11-12 22:46 ` Greg Kroah-Hartman [this message] 2018-11-12 22:46 ` Greg Kroah-Hartman 2018-11-12 23:31 ` Cristian Sicilia 2018-11-12 23:46 ` Greg Kroah-Hartman 2018-11-12 23:46 ` Greg Kroah-Hartman 2018-11-13 0:38 ` Gao Xiang 2018-11-13 0:38 ` Gao Xiang 2018-11-13 0:15 ` Gao Xiang 2018-11-13 0:15 ` Gao Xiang 2018-11-16 3:07 ` Chao Yu 2018-11-16 3:07 ` Chao Yu 2018-11-12 20:43 ` [PATCH 2/3] staging: erofs: unzip_vle.c: Constant in comparison on right side Cristian Sicilia 2018-11-12 20:43 ` Cristian Sicilia 2018-11-13 0:02 ` Gao Xiang 2018-11-13 0:02 ` Gao Xiang 2018-11-16 3:07 ` Chao Yu 2018-11-16 3:07 ` Chao Yu 2018-11-12 20:43 ` [PATCH 3/3] staging: erofs: unzip_vle.c: Align parameter to the parentesis Cristian Sicilia 2018-11-12 20:43 ` Cristian Sicilia 2018-11-13 0:00 ` Gao Xiang 2018-11-13 0:00 ` Gao Xiang 2018-11-16 3:07 ` Chao Yu 2018-11-16 3:07 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181112224636.GA12671@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=devel@driverdev.osuosl.org \ --cc=gaoxiang25@huawei.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sicilia.cristian@gmail.com \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.