* [PATCH v3 2/3] drm/i915/icl: reverse uninit order
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
@ 2018-11-14 1:15 ` Lucas De Marchi
2018-11-14 8:08 ` Jani Nikula
2018-11-14 1:15 ` [PATCH v3 3/3] drm/i195: spell out reverse on for_each macros Lucas De Marchi
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Lucas De Marchi @ 2018-11-14 1:15 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
Bspec 21257 says "DDIA PHY is the comp master, so it must
not be un-initialized if other combo PHYs are in use". Here
we are shutting down all phys, so it's not strictly required.
However let's be consistent on deinitializing things in the
reversed order we initialized them.
v2: simplify protection for enum port being unsigned in future
v3: spell out reverse rather than rev
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_combo_phy.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
index 49f3a533860d..3d0271cebf99 100644
--- a/drivers/gpu/drm/i915/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/intel_combo_phy.c
@@ -9,6 +9,10 @@
for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++) \
for_each_if(intel_port_is_combophy(__dev_priv, __port))
+#define for_each_combo_port_reverse(__dev_priv, __port) \
+ for ((__port) = I915_MAX_PORTS; (__port)-- > PORT_A;) \
+ for_each_if(intel_port_is_combophy(__dev_priv, __port))
+
enum {
PROCMON_0_85V_DOT_0,
PROCMON_0_95V_DOT_0,
@@ -232,7 +236,7 @@ void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
{
enum port port;
- for_each_combo_port(dev_priv, port) {
+ for_each_combo_port_reverse(dev_priv, port) {
u32 val;
if (!icl_combo_phy_verify_state(dev_priv, port))
--
2.19.1.1.g56c4683e68
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v3 2/3] drm/i915/icl: reverse uninit order
2018-11-14 1:15 ` [PATCH v3 2/3] drm/i915/icl: reverse uninit order Lucas De Marchi
@ 2018-11-14 8:08 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2018-11-14 8:08 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Paulo Zanoni
On Tue, 13 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Bspec 21257 says "DDIA PHY is the comp master, so it must
> not be un-initialized if other combo PHYs are in use". Here
> we are shutting down all phys, so it's not strictly required.
> However let's be consistent on deinitializing things in the
> reversed order we initialized them.
>
> v2: simplify protection for enum port being unsigned in future
> v3: spell out reverse rather than rev
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_combo_phy.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
> index 49f3a533860d..3d0271cebf99 100644
> --- a/drivers/gpu/drm/i915/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/intel_combo_phy.c
> @@ -9,6 +9,10 @@
> for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++) \
> for_each_if(intel_port_is_combophy(__dev_priv, __port))
>
> +#define for_each_combo_port_reverse(__dev_priv, __port) \
> + for ((__port) = I915_MAX_PORTS; (__port)-- > PORT_A;) \
> + for_each_if(intel_port_is_combophy(__dev_priv, __port))
> +
> enum {
> PROCMON_0_85V_DOT_0,
> PROCMON_0_95V_DOT_0,
> @@ -232,7 +236,7 @@ void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
> {
> enum port port;
>
> - for_each_combo_port(dev_priv, port) {
> + for_each_combo_port_reverse(dev_priv, port) {
> u32 val;
>
> if (!icl_combo_phy_verify_state(dev_priv, port))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 3/3] drm/i195: spell out reverse on for_each macros
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
2018-11-14 1:15 ` [PATCH v3 2/3] drm/i915/icl: reverse uninit order Lucas De Marchi
@ 2018-11-14 1:15 ` Lucas De Marchi
2018-11-14 8:09 ` Jani Nikula
2018-11-14 1:20 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Lucas De Marchi @ 2018-11-14 1:15 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
Do like it's done for list.h macros, and use "reverse" suffix rather
than "rev".
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_display.h | 6 +++---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.h b/drivers/gpu/drm/i915/intel_display.h
index 5d50decbcbb5..43eb4ebbcc35 100644
--- a/drivers/gpu/drm/i915/intel_display.h
+++ b/drivers/gpu/drm/i915/intel_display.h
@@ -368,7 +368,7 @@ struct intel_link_m_n {
(__dev_priv)->power_domains.power_well_count; \
(__power_well)++)
-#define for_each_power_well_rev(__dev_priv, __power_well) \
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
(__dev_priv)->power_domains.power_well_count - 1; \
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
@@ -378,8 +378,8 @@ struct intel_link_m_n {
for_each_power_well(__dev_priv, __power_well) \
for_each_if((__power_well)->desc->domains & (__domain_mask))
-#define for_each_power_domain_well_rev(__dev_priv, __power_well, __domain_mask) \
- for_each_power_well_rev(__dev_priv, __power_well) \
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
for_each_if((__power_well)->desc->domains & (__domain_mask))
#define for_each_new_intel_plane_in_state(__state, plane, new_plane_state, __i) \
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index f945db6ea420..7aa5f07f1356 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -208,7 +208,7 @@ bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
is_enabled = true;
- for_each_power_domain_well_rev(dev_priv, power_well, BIT_ULL(domain)) {
+ for_each_power_domain_well_reverse(dev_priv, power_well, BIT_ULL(domain)) {
if (power_well->desc->always_on)
continue;
@@ -1651,7 +1651,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
intel_display_power_domain_str(domain));
power_domains->domain_use_count[domain]--;
- for_each_power_domain_well_rev(dev_priv, power_well, BIT_ULL(domain))
+ for_each_power_domain_well_reverse(dev_priv, power_well, BIT_ULL(domain))
intel_power_well_put(dev_priv, power_well);
mutex_unlock(&power_domains->lock);
--
2.19.1.1.g56c4683e68
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v3 3/3] drm/i195: spell out reverse on for_each macros
2018-11-14 1:15 ` [PATCH v3 3/3] drm/i195: spell out reverse on for_each macros Lucas De Marchi
@ 2018-11-14 8:09 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2018-11-14 8:09 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Paulo Zanoni
On Tue, 13 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Do like it's done for list.h macros, and use "reverse" suffix rather
> than "rev".
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.h | 6 +++---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.h b/drivers/gpu/drm/i915/intel_display.h
> index 5d50decbcbb5..43eb4ebbcc35 100644
> --- a/drivers/gpu/drm/i915/intel_display.h
> +++ b/drivers/gpu/drm/i915/intel_display.h
> @@ -368,7 +368,7 @@ struct intel_link_m_n {
> (__dev_priv)->power_domains.power_well_count; \
> (__power_well)++)
>
> -#define for_each_power_well_rev(__dev_priv, __power_well) \
> +#define for_each_power_well_reverse(__dev_priv, __power_well) \
> for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
> (__dev_priv)->power_domains.power_well_count - 1; \
> (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
> @@ -378,8 +378,8 @@ struct intel_link_m_n {
> for_each_power_well(__dev_priv, __power_well) \
> for_each_if((__power_well)->desc->domains & (__domain_mask))
>
> -#define for_each_power_domain_well_rev(__dev_priv, __power_well, __domain_mask) \
> - for_each_power_well_rev(__dev_priv, __power_well) \
> +#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
> + for_each_power_well_reverse(__dev_priv, __power_well) \
> for_each_if((__power_well)->desc->domains & (__domain_mask))
>
> #define for_each_new_intel_plane_in_state(__state, plane, new_plane_state, __i) \
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index f945db6ea420..7aa5f07f1356 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -208,7 +208,7 @@ bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
>
> is_enabled = true;
>
> - for_each_power_domain_well_rev(dev_priv, power_well, BIT_ULL(domain)) {
> + for_each_power_domain_well_reverse(dev_priv, power_well, BIT_ULL(domain)) {
> if (power_well->desc->always_on)
> continue;
>
> @@ -1651,7 +1651,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> intel_display_power_domain_str(domain));
> power_domains->domain_use_count[domain]--;
>
> - for_each_power_domain_well_rev(dev_priv, power_well, BIT_ULL(domain))
> + for_each_power_domain_well_reverse(dev_priv, power_well, BIT_ULL(domain))
> intel_power_well_put(dev_priv, power_well);
>
> mutex_unlock(&power_domains->lock);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
2018-11-14 1:15 ` [PATCH v3 2/3] drm/i915/icl: reverse uninit order Lucas De Marchi
2018-11-14 1:15 ` [PATCH v3 3/3] drm/i195: spell out reverse on for_each macros Lucas De Marchi
@ 2018-11-14 1:20 ` Patchwork
2018-11-14 4:40 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-11-14 1:20 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52459/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f5816a94faad drm/i915/icl: replace check for combo phy
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__port' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/intel_combo_phy.c:8:
+#define for_each_combo_port(__dev_priv, __port) \
+ for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++) \
+ for_each_if(intel_port_is_combophy(__dev_priv, __port))
total: 0 errors, 0 warnings, 1 checks, 26 lines checked
a96e90922991 drm/i915/icl: reverse uninit order
-:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__port' - possible side-effects?
#26: FILE: drivers/gpu/drm/i915/intel_combo_phy.c:12:
+#define for_each_combo_port_reverse(__dev_priv, __port) \
+ for ((__port) = I915_MAX_PORTS; (__port)-- > PORT_A;) \
+ for_each_if(intel_port_is_combophy(__dev_priv, __port))
total: 0 errors, 0 warnings, 1 checks, 18 lines checked
49663aa28220 drm/i195: spell out reverse on for_each macros
-:20: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
(__dev_priv)->power_domains.power_well_count - 1; \
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
(__dev_priv)->power_domains.power_well_count - 1; \
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
(__dev_priv)->power_domains.power_well_count - 1; \
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
-:30: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#30: FILE: drivers/gpu/drm/i915/intel_display.h:381:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
for_each_if((__power_well)->desc->domains & (__domain_mask))
-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects?
#30: FILE: drivers/gpu/drm/i915/intel_display.h:381:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
for_each_if((__power_well)->desc->domains & (__domain_mask))
total: 2 errors, 0 warnings, 3 checks, 34 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* ✓ Fi.CI.BAT: success for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
` (2 preceding siblings ...)
2018-11-14 1:20 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy Patchwork
@ 2018-11-14 4:40 ` Patchwork
2018-11-14 6:23 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-14 8:03 ` [PATCH v3 1/3] " Jani Nikula
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-11-14 4:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52459/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5134 -> Patchwork_10820 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52459/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10820 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_contexts:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#108315)
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: PASS -> FAIL (fdo#102672, fdo#103841)
igt@kms_flip@basic-flip-vs-modeset:
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#105602)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-cfl-8109u: PASS -> DMESG-WARN (fdo#107345)
==== Possible fixes ====
igt@drv_module_reload@basic-no-display:
fi-byt-clapper: WARN (fdo#108688) -> PASS
igt@drv_selftest@live_evict:
fi-bsw-kefka: DMESG-WARN (fdo#107709) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: WARN (fdo#108680) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-icl-u: INCOMPLETE (fdo#107713) -> PASS
==== Warnings ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: DMESG-WARN (fdo#107345) -> INCOMPLETE (fdo#106070, fdo#108126)
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108680 https://bugs.freedesktop.org/show_bug.cgi?id=108680
fdo#108688 https://bugs.freedesktop.org/show_bug.cgi?id=108688
== Participating hosts (51 -> 44) ==
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5134 -> Patchwork_10820
CI_DRM_5134: 76f4cff023b23764df2956ad64a0840bfebd7ca4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10820: 49663aa28220474a070f8e4ac2d4d1e549513d73 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
49663aa28220 drm/i195: spell out reverse on for_each macros
a96e90922991 drm/i915/icl: reverse uninit order
f5816a94faad drm/i915/icl: replace check for combo phy
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10820/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
` (3 preceding siblings ...)
2018-11-14 4:40 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-14 6:23 ` Patchwork
2018-11-16 0:41 ` Souza, Jose
2018-11-14 8:03 ` [PATCH v3 1/3] " Jani Nikula
5 siblings, 1 reply; 10+ messages in thread
From: Patchwork @ 2018-11-14 6:23 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52459/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5134_full -> Patchwork_10820_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10820_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10820_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10820_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10820_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
shard-kbl: PASS -> INCOMPLETE (fdo#106887, fdo#103665, fdo#106023)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-skl: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-kbl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-apl: PASS -> FAIL (fdo#103232)
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
shard-skl: NOTRUN -> FAIL (fdo#105683)
igt@kms_plane@pixel-format-pipe-b-planes:
shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
shard-skl: NOTRUN -> FAIL (fdo#103166)
igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
shard-skl: NOTRUN -> FAIL (fdo#108145) +5
igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
shard-skl: NOTRUN -> FAIL (fdo#108145, fdo#107815)
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_properties@connector-properties-legacy:
shard-kbl: PASS -> DMESG-WARN (fdo#105345, fdo#103313)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_backlight@fade_with_suspend:
shard-skl: NOTRUN -> FAIL (fdo#107847)
==== Possible fixes ====
igt@kms_flip@2x-dpms-vs-vblank-race:
shard-hsw: DMESG-WARN (fdo#102614) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-skl: FAIL (fdo#107815) -> PASS
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +1
shard-apl: FAIL (fdo#103166) -> PASS +2
igt@perf@polling:
shard-hsw: FAIL (fdo#102252) -> PASS
igt@perf_pmu@busy-start-vcs0:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS
igt@pm_rpm@debugfs-forcewake-user:
shard-skl: INCOMPLETE (fdo#107807) -> PASS
igt@pm_rpm@dpms-mode-unset-non-lpsp:
shard-skl: INCOMPLETE (fdo#107807) -> SKIP
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107847 https://bugs.freedesktop.org/show_bug.cgi?id=107847
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5134 -> Patchwork_10820
CI_DRM_5134: 76f4cff023b23764df2956ad64a0840bfebd7ca4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10820: 49663aa28220474a070f8e4ac2d4d1e549513d73 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10820/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
2018-11-14 6:23 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-16 0:41 ` Souza, Jose
0 siblings, 0 replies; 10+ messages in thread
From: Souza, Jose @ 2018-11-16 0:41 UTC (permalink / raw)
To: intel-gfx, De Marchi, Lucas
[-- Attachment #1.1: Type: text/plain, Size: 7206 bytes --]
Pushed to drm-intel-next-queued.
On Wed, 2018-11-14 at 06:23 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v3,1/3] drm/i915/icl: replace check for
> combo phy
> URL : https://patchwork.freedesktop.org/series/52459/
> State : success
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_5134_full -> Patchwork_10820_full
> =
>
> == Summary - WARNING ==
>
> Minor unknown changes coming with Patchwork_10820_full need to be
> verified
> manually.
>
> If you think the reported changes have nothing to do with the
> changes
> introduced in Patchwork_10820_full, please notify your bug team to
> allow them
> to document this new failure mode, which will reduce false
> positives in CI.
>
>
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in
> Patchwork_10820_full:
>
> === IGT changes ===
>
> ==== Warnings ====
>
> igt@perf_pmu@rc6:
> shard-kbl: PASS -> SKIP
>
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10820_full that come from
> known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@gem_ppgtt@blt-vs-render-ctx0:
> shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
> shard-kbl: PASS -> INCOMPLETE (fdo#106887, fdo#103665,
> fdo#106023)
>
> igt@kms_available_modes_crc@available_mode_test_crc:
> shard-skl: NOTRUN -> FAIL (fdo#106641)
>
> igt@kms_busy@extended-modeset-hang-newfb-render-a:
> shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +2
>
> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> shard-kbl: PASS -> DMESG-WARN (fdo#107956)
>
> igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> shard-glk: PASS -> FAIL (fdo#108145)
>
> igt@kms_cursor_crc@cursor-256x256-sliding:
> shard-apl: PASS -> FAIL (fdo#103232)
>
> igt@kms_flip@flip-vs-expired-vblank:
> shard-glk: PASS -> FAIL (fdo#105363)
>
> igt@kms
> _frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
> shard-glk: PASS -> FAIL (fdo#103167) +1
>
> igt@kms
> _frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
> shard-apl: PASS -> FAIL (fdo#103167) +2
>
> igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
> shard-skl: NOTRUN -> FAIL (fdo#105683)
>
> igt@kms_plane@pixel-format-pipe-b-planes:
> shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
>
> igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
> shard-skl: NOTRUN -> FAIL (fdo#103166)
>
> igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
> shard-skl: NOTRUN -> FAIL (fdo#108145) +5
>
> igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
> shard-skl: NOTRUN -> FAIL (fdo#108145, fdo#107815)
>
> igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
> shard-apl: PASS -> FAIL (fdo#103166)
>
> igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
> shard-glk: PASS -> FAIL (fdo#103166)
>
> igt@kms_properties@connector-properties-legacy:
> shard-kbl: PASS -> DMESG-WARN (fdo#105345, fdo#103313)
>
> igt@kms_setmode@basic:
> shard-apl: PASS -> FAIL (fdo#99912)
> shard-kbl: PASS -> FAIL (fdo#99912)
>
> igt@pm_backlight@fade_with_suspend:
> shard-skl: NOTRUN -> FAIL (fdo#107847)
>
>
> ==== Possible fixes ====
>
> igt@kms_flip@2x-dpms-vs-vblank-race:
> shard-hsw: DMESG-WARN (fdo#102614) -> PASS
>
> igt@kms
> _frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
> shard-apl: FAIL (fdo#103167) -> PASS +1
>
> igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> shard-glk: FAIL (fdo#108145) -> PASS
>
> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> shard-skl: FAIL (fdo#107815) -> PASS
>
> igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> shard-glk: FAIL (fdo#103166) -> PASS +1
> shard-apl: FAIL (fdo#103166) -> PASS +2
>
> igt@perf@polling:
> shard-hsw: FAIL (fdo#102252) -> PASS
>
> igt@perf_pmu@busy-start-vcs0:
> shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS
>
> igt@pm_rpm@debugfs-forcewake-user:
> shard-skl: INCOMPLETE (fdo#107807) -> PASS
>
> igt@pm_rpm@dpms-mode-unset-non-lpsp:
> shard-skl: INCOMPLETE (fdo#107807) -> SKIP
>
>
> fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
> fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
> fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
> fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
> fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
> fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
> fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
> fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
> fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
> fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
> fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
> fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
> fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
> fdo#107847 https://bugs.freedesktop.org/show_bug.cgi?id=107847
> fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
> fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
> fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> == Participating hosts (6 -> 6) ==
>
> No changes in participating hosts
>
>
> == Build changes ==
>
> * Linux: CI_DRM_5134 -> Patchwork_10820
>
> CI_DRM_5134: 76f4cff023b23764df2956ad64a0840bfebd7ca4 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_10820: 49663aa28220474a070f8e4ac2d4d1e549513d73 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10820/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/3] drm/i915/icl: replace check for combo phy
2018-11-14 1:15 [PATCH v3 1/3] drm/i915/icl: replace check for combo phy Lucas De Marchi
` (4 preceding siblings ...)
2018-11-14 6:23 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-14 8:03 ` Jani Nikula
5 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2018-11-14 8:03 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Paulo Zanoni
On Tue, 13 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> These are the only places that assume ports A and B are the ones with
> combo phy. Let's use intel_port_is_combophy() there to make sure
> it checks for combo phy ports the same way everywhere.
>
> v2: define for_each_combo_port() helper to check the ports
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_combo_phy.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
> index f7c16f6724f0..49f3a533860d 100644
> --- a/drivers/gpu/drm/i915/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/intel_combo_phy.c
> @@ -5,6 +5,10 @@
>
> #include "intel_drv.h"
>
> +#define for_each_combo_port(__dev_priv, __port) \
> + for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++) \
> + for_each_if(intel_port_is_combophy(__dev_priv, __port))
> +
> enum {
> PROCMON_0_85V_DOT_0,
> PROCMON_0_95V_DOT_0,
> @@ -199,7 +203,7 @@ void icl_combo_phys_init(struct drm_i915_private *dev_priv)
> {
> enum port port;
>
> - for (port = PORT_A; port <= PORT_B; port++) {
> + for_each_combo_port(dev_priv, port) {
> u32 val;
>
> if (icl_combo_phy_verify_state(dev_priv, port)) {
> @@ -228,7 +232,7 @@ void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
> {
> enum port port;
>
> - for (port = PORT_A; port <= PORT_B; port++) {
> + for_each_combo_port(dev_priv, port) {
> u32 val;
>
> if (!icl_combo_phy_verify_state(dev_priv, port))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread