[PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

[PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

[Matthias Kaehlcke]

This series adds a channel for the die temperature to the QCOM SPMI
PMIC5 ADC. It also fixes an example in the DT documentation.

Matthias Kaehlcke (2):
  dt-bindings: iio: vadc: Add unit address to ADC channel node in
    example
  arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

 .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt          | 6 +++++-
 arch/arm64/boot/dts/qcom/pm8998.dtsi                        | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

-- 
2.19.1.930.g4563a0d9d0-goog

[PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example

[Matthias Kaehlcke]

The node has a reg property, therefore its name should include a unit
address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
is the preferred name for ADC channel nodes.

Include headers for constants used in the example.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v6:
- changed node name to adc-chan@
- added includes for constants used in the example
- updated commit message
- added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag

Changes in v5:
- patch added to the series
---
 .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt          | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
index b3c86f4ac7cdb..c81993f8d8c39 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
@@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
 
 Example:
 
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
+#include <linux/irq.h>
+/* ... */
+
 	/* VADC node */
 	pmic_vadc: vadc@3100 {
 		compatible = "qcom,spmi-vadc";
@@ -151,7 +155,7 @@ Example:
 		io-channel-ranges;
 
 		/* Channel node */
-		usb_id_nopull {
+		adc-chan@VADC_LR_MUX10_USB_ID {
 			reg = <VADC_LR_MUX10_USB_ID>;
 			qcom,decimation = <512>;
 			qcom,ratiometric;
-- 
2.19.1.930.g4563a0d9d0-goog

Re: [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example

[Jonathan Cameron]

On Mon, 12 Nov 2018 14:11:25 -0800
Matthias Kaehlcke <mka@chromium.org> wrote:

> The node has a reg property, therefore its name should include a unit
> address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
> is the preferred name for ADC channel nodes.
> 
> Include headers for constants used in the example.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Looks good to me.  I'd just like to leave it a little longer
to give Rob or other device tree specialists a change
to take one last look at it.

Ping me if I seem to have forgotten about it!

Thanks,

Jonathan
> ---
> Changes in v6:
> - changed node name to adc-chan@
> - added includes for constants used in the example
> - updated commit message
> - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag
> 
> Changes in v5:
> - patch added to the series
> ---
>  .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt          | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> index b3c86f4ac7cdb..c81993f8d8c39 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
>  
>  Example:
>  
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <linux/irq.h>
> +/* ... */
> +
>  	/* VADC node */
>  	pmic_vadc: vadc@3100 {
>  		compatible = "qcom,spmi-vadc";
> @@ -151,7 +155,7 @@ Example:
>  		io-channel-ranges;
>  
>  		/* Channel node */
> -		usb_id_nopull {
> +		adc-chan@VADC_LR_MUX10_USB_ID {
>  			reg = <VADC_LR_MUX10_USB_ID>;
>  			qcom,decimation = <512>;
>  			qcom,ratiometric;

Re: [PATCH v6 1/2] dt-bindings: iio: vadc: Add unit address to ADC channel node in example

[Jonathan Cameron]

On Fri, 16 Nov 2018 18:13:38 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 12 Nov 2018 14:11:25 -0800
> Matthias Kaehlcke <mka@chromium.org> wrote:
> 
> > The node has a reg property, therefore its name should include a unit
> > address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
> > is the preferred name for ADC channel nodes.
> > 
> > Include headers for constants used in the example.
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>  
> Looks good to me.  I'd just like to leave it a little longer
> to give Rob or other device tree specialists a change
> to take one last look at it.
> 
> Ping me if I seem to have forgotten about it!
> 
Ah, I should have read on.  Already queued.  That's fine with me.

Jonathan

> Thanks,
> 
> Jonathan
> > ---
> > Changes in v6:
> > - changed node name to adc-chan@
> > - added includes for constants used in the example
> > - updated commit message
> > - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag
> > 
> > Changes in v5:
> > - patch added to the series
> > ---
> >  .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt          | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > index b3c86f4ac7cdb..c81993f8d8c39 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
> >  
> >  Example:
> >  
> > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > +#include <linux/irq.h>
> > +/* ... */
> > +
> >  	/* VADC node */
> >  	pmic_vadc: vadc@3100 {
> >  		compatible = "qcom,spmi-vadc";
> > @@ -151,7 +155,7 @@ Example:
> >  		io-channel-ranges;
> >  
> >  		/* Channel node */
> > -		usb_id_nopull {
> > +		adc-chan@VADC_LR_MUX10_USB_ID {
> >  			reg = <VADC_LR_MUX10_USB_ID>;
> >  			qcom,decimation = <512>;
> >  			qcom,ratiometric;  
> 

[PATCH v6 2/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

[Matthias Kaehlcke]

Add a channel node for the die temperature to the ADC.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v6:
- changed node name to 'adc-chan@'

Changes in v5:
- added unit address to 'die-temp' node

Changes in v4:
- none

Changes in v3:
- fixed separator in commit message
- remove duplicate 'Signed-off-by' tag

Changes in v2:
- none
---
 arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 048f19fa01504..f1025a50c227b 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -75,6 +75,11 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			#io-channel-cells = <1>;
+
+			adc-chan@ADC5_DIE_TEMP {
+				reg = <ADC5_DIE_TEMP>;
+				label = "die_temp";
+			};
 		};
 
 		rtc@6000 {
-- 
2.19.1.930.g4563a0d9d0-goog

Re: [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

[Andy Gross]

On Mon, Nov 12, 2018 at 02:11:24PM -0800, Matthias Kaehlcke wrote:
> This series adds a channel for the die temperature to the QCOM SPMI
> PMIC5 ADC. It also fixes an example in the DT documentation.
> 
> Matthias Kaehlcke (2):
>   dt-bindings: iio: vadc: Add unit address to ADC channel node in
>     example
>   arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
> 

I queued both of these.  Thanks for updating these.

Andy