[PATCH] fs/proc/util.c: include fs/proc/internal.h for name_to_int()

[PATCH] fs/proc/util.c: include fs/proc/internal.h for name_to_int()

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

name_to_int() is defined in fs/proc/util.c and declared in
fs/proc/internal.h, but the declaration isn't included at the point of
the definition.  Include the header to enforce that the definition
matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/proc/util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/proc/util.c b/fs/proc/util.c
index b161cfa0f9fa1..98f8adc173453 100644
--- a/fs/proc/util.c
+++ b/fs/proc/util.c
@@ -1,4 +1,5 @@
 #include <linux/dcache.h>
+#include "internal.h"
 
 unsigned name_to_int(const struct qstr *qstr)
 {
-- 
2.19.1.930.g4563a0d9d0-goog

Re: [PATCH] fs/proc/util.c: include fs/proc/internal.h for name_to_int()

[Alexey Dobriyan]

On Wed, Nov 14, 2018 at 04:18:33PM -0800, Eric Biggers wrote:
> --- a/fs/proc/util.c
> +++ b/fs/proc/util.c
> @@ -1,4 +1,5 @@
>  #include <linux/dcache.h>
> +#include "internal.h"

Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>