[Buildroot] [PATCH] utils/genrandconfig: add missing new line when creating the configuration

[Buildroot] [PATCH] utils/genrandconfig: add missing new line when creating the configuration

[Thomas Petazzoni]

When adding the custom BR2_WGET value in the configuration,
genrandconfig forgets to add a newline. Due to this, the next option
that is added is printed on the same line as BR2_WGET="", which causes
it to be ignored.

Due to this, in all builds, the line right after BR2_WGET was
ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX,
BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV,
BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the
randomization.

Fix that by adding a proper newline at the end of the BR2_WGET option.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 utils/genrandconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/genrandconfig b/utils/genrandconfig
index 27f84ea555..1d6ff990f5 100755
--- a/utils/genrandconfig
+++ b/utils/genrandconfig
@@ -351,7 +351,7 @@ def gen_config(args):
         configlines += minimalf.readlines()
 
     # Allow hosts with old certificates to download over https
-    configlines.append("BR2_WGET=\"wget --passive-ftp -nd -t 3 --no-check-certificate\"")
+    configlines.append("BR2_WGET=\"wget --passive-ftp -nd -t 3 --no-check-certificate\"\n")
 
     # Amend the configuration with a few things.
     if randint(0, 20) == 0:
-- 
2.19.1

[Buildroot] [PATCH] utils/genrandconfig: add missing new line when creating the configuration

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > When adding the custom BR2_WGET value in the configuration,
 > genrandconfig forgets to add a newline. Due to this, the next option
 > that is added is printed on the same line as BR2_WGET="", which causes
 > it to be ignored.

 > Due to this, in all builds, the line right after BR2_WGET was
 > ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX,
 > BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV,
 > BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the
 > randomization.

 > Fix that by adding a proper newline at the end of the BR2_WGET option.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] utils/genrandconfig: add missing new line when creating the configuration

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > When adding the custom BR2_WGET value in the configuration,
 > genrandconfig forgets to add a newline. Due to this, the next option
 > that is added is printed on the same line as BR2_WGET="", which causes
 > it to be ignored.

 > Due to this, in all builds, the line right after BR2_WGET was
 > ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX,
 > BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV,
 > BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the
 > randomization.

 > Fix that by adding a proper newline at the end of the BR2_WGET option.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard