* [PATCH 1/3] dm: move dm_stats_account_io before generic_end_io_acct
@ 2018-11-16 0:04 ` Mikulas Patocka
0 siblings, 0 replies; 2+ messages in thread
From: Mikulas Patocka @ 2018-11-16 0:04 UTC (permalink / raw)
To: Mike Snitzer
Cc: dm-devel, linux-block, Jens Axboe, Alasdair G. Kergon,
Christoph Hellwig, Mikulas Patocka
[-- Attachment #1: dm-stats-ordering.patch --]
[-- Type: text/plain, Size: 1367 bytes --]
Make sure that the statistics are not updated while the device is
suspended. So, we move statistics update before generic_end_io_acct.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-dm/drivers/md/dm.c
===================================================================
--- linux-dm.orig/drivers/md/dm.c 2018-11-15 21:56:36.000000000 +0100
+++ linux-dm/drivers/md/dm.c 2018-11-15 21:56:36.000000000 +0100
@@ -674,6 +674,11 @@ static void end_io_acct(struct dm_io *io
struct bio *bio = io->orig_bio;
unsigned long duration = jiffies - io->start_time;
+ if (unlikely(dm_stats_used(&md->stats)))
+ dm_stats_account_io(&md->stats, bio_data_dir(bio),
+ bio->bi_iter.bi_sector, bio_sectors(bio),
+ true, duration, &io->stats_aux);
+
/*
* make sure that atomic_dec in generic_end_io_acct is not reordered
* with previous writes
@@ -687,11 +692,6 @@ static void end_io_acct(struct dm_io *io
*/
smp_mb__after_atomic();
- if (unlikely(dm_stats_used(&md->stats)))
- dm_stats_account_io(&md->stats, bio_data_dir(bio),
- bio->bi_iter.bi_sector, bio_sectors(bio),
- true, duration, &io->stats_aux);
-
/* nudge anyone waiting on suspend queue */
if (unlikely(waitqueue_active(&md->wait))) {
if (!md_in_flight(md))
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/3] dm: move dm_stats_account_io before generic_end_io_acct
@ 2018-11-16 0:04 ` Mikulas Patocka
0 siblings, 0 replies; 2+ messages in thread
From: Mikulas Patocka @ 2018-11-16 0:04 UTC (permalink / raw)
To: Mike Snitzer
Cc: Jens Axboe, Christoph Hellwig, linux-block, dm-devel,
Mikulas Patocka, Alasdair G. Kergon
[-- Attachment #1: dm-stats-ordering.patch --]
[-- Type: text/plain, Size: 1366 bytes --]
Make sure that the statistics are not updated while the device is
suspended. So, we move statistics update before generic_end_io_acct.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-dm/drivers/md/dm.c
===================================================================
--- linux-dm.orig/drivers/md/dm.c 2018-11-15 21:56:36.000000000 +0100
+++ linux-dm/drivers/md/dm.c 2018-11-15 21:56:36.000000000 +0100
@@ -674,6 +674,11 @@ static void end_io_acct(struct dm_io *io
struct bio *bio = io->orig_bio;
unsigned long duration = jiffies - io->start_time;
+ if (unlikely(dm_stats_used(&md->stats)))
+ dm_stats_account_io(&md->stats, bio_data_dir(bio),
+ bio->bi_iter.bi_sector, bio_sectors(bio),
+ true, duration, &io->stats_aux);
+
/*
* make sure that atomic_dec in generic_end_io_acct is not reordered
* with previous writes
@@ -687,11 +692,6 @@ static void end_io_acct(struct dm_io *io
*/
smp_mb__after_atomic();
- if (unlikely(dm_stats_used(&md->stats)))
- dm_stats_account_io(&md->stats, bio_data_dir(bio),
- bio->bi_iter.bi_sector, bio_sectors(bio),
- true, duration, &io->stats_aux);
-
/* nudge anyone waiting on suspend queue */
if (unlikely(waitqueue_active(&md->wait))) {
if (!md_in_flight(md))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-16 0:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 0:04 [PATCH 1/3] dm: move dm_stats_account_io before generic_end_io_acct Mikulas Patocka
2018-11-16 0:04 ` Mikulas Patocka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.