* [PATCH] drm/amdgpu/psp: use define rather than magic number for mode1 reset @ 2018-11-16 18:25 Alex Deucher [not found] ` <20181116182507.12709-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Alex Deucher @ 2018-11-16 18:25 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher Use the define rather than hardcoded value. Signed-off-by: Alex Deucher <alexander.deucher@amd.com> --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c index e1ebf770c303..940894e8c67e 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c @@ -593,7 +593,7 @@ static int psp_v3_1_mode1_reset(struct psp_context *psp) } /*send the mode 1 reset command*/ - WREG32(offset, 0x70000); + WREG32(offset, GFX_CTRL_CMD_ID_MODE1_RST); mdelay(1000); -- 2.13.6 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20181116182507.12709-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu/psp: use define rather than magic number for mode1 reset [not found] ` <20181116182507.12709-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> @ 2018-11-19 8:59 ` Christian König 2018-11-19 9:57 ` Huang, Ray 1 sibling, 0 replies; 3+ messages in thread From: Christian König @ 2018-11-19 8:59 UTC (permalink / raw) To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher Am 16.11.18 um 19:25 schrieb Alex Deucher: > Use the define rather than hardcoded value. > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > index e1ebf770c303..940894e8c67e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > @@ -593,7 +593,7 @@ static int psp_v3_1_mode1_reset(struct psp_context *psp) > } > > /*send the mode 1 reset command*/ > - WREG32(offset, 0x70000); > + WREG32(offset, GFX_CTRL_CMD_ID_MODE1_RST); > > mdelay(1000); > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu/psp: use define rather than magic number for mode1 reset [not found] ` <20181116182507.12709-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> 2018-11-19 8:59 ` Christian König @ 2018-11-19 9:57 ` Huang, Ray 1 sibling, 0 replies; 3+ messages in thread From: Huang, Ray @ 2018-11-19 9:57 UTC (permalink / raw) To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Deucher, Alexander > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Saturday, November 17, 2018 2:25 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander <Alexander.Deucher@amd.com> > Subject: [PATCH] drm/amdgpu/psp: use define rather than magic number > for mode1 reset > > Use the define rather than hardcoded value. > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Reviewed-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > index e1ebf770c303..940894e8c67e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > @@ -593,7 +593,7 @@ static int psp_v3_1_mode1_reset(struct psp_context > *psp) > } > > /*send the mode 1 reset command*/ > - WREG32(offset, 0x70000); > + WREG32(offset, GFX_CTRL_CMD_ID_MODE1_RST); > > mdelay(1000); > > -- > 2.13.6 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-19 9:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-11-16 18:25 [PATCH] drm/amdgpu/psp: use define rather than magic number for mode1 reset Alex Deucher [not found] ` <20181116182507.12709-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> 2018-11-19 8:59 ` Christian König 2018-11-19 9:57 ` Huang, Ray
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.