* [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen
@ 2018-11-17 0:42 Lucas De Marchi
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Lucas De Marchi @ 2018-11-17 0:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Before commit d8a5b7d79fb7 ("drm/i915/csr: keep max firmware size together
with firmare name and version") it was possible to load the firmware for
testing purposes via parameter. Let's use the size of the last known
platform to recover that behavior.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index c1ca6596ff5c..b4476d891fa3 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -34,6 +34,8 @@
* low-power state and comes back to normal.
*/
+#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
+
#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define ICL_CSR_MAX_FW_SIZE 0x6000
@@ -467,7 +469,10 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
*/
intel_display_power_get(dev_priv, POWER_DOMAIN_INIT);
- if (IS_ICELAKE(dev_priv)) {
+ if (INTEL_GEN(dev_priv) >= 12) {
+ /* Allow to load fw via parameter using the last known size */
+ csr->max_fw_size = GEN12_CSR_MAX_FW_SIZE;
+ } else if (IS_ICELAKE(dev_priv)) {
csr->fw_path = ICL_CSR_PATH;
csr->required_version = ICL_CSR_VERSION_REQUIRED;
csr->max_fw_size = ICL_CSR_MAX_FW_SIZE;
--
2.19.1.1.g56c4683e68
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
@ 2018-11-17 0:42 ` Lucas De Marchi
2018-11-18 22:01 ` Chris Wilson
2018-11-21 9:29 ` Jani Nikula
2018-11-17 1:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen Patchwork
` (5 subsequent siblings)
6 siblings, 2 replies; 14+ messages in thread
From: Lucas De Marchi @ 2018-11-17 0:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
we have released no firmware yet for a platform, stop scaring the
consumer and merely note its expected absence.
By simply removing the warning and early return we hit the condition
with the appropriate message.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index b4476d891fa3..a516697bf57d 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
csr->fw_path = BXT_CSR_PATH;
csr->required_version = BXT_CSR_VERSION_REQUIRED;
csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
- } else {
- MISSING_CASE(INTEL_REVID(dev_priv));
- return;
}
if (i915_modparams.dmc_firmware_path) {
--
2.19.1.1.g56c4683e68
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
@ 2018-11-17 1:15 ` Patchwork
2018-11-18 21:24 ` ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-11-17 1:15 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
URL : https://patchwork.freedesktop.org/series/52639/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5154 -> Patchwork_10845 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10845 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10845, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52639/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10845:
=== IGT changes ===
==== Possible regressions ====
igt@i915_selftest@live_gtt:
fi-kbl-7560u: PASS -> INCOMPLETE
== Known issues ==
Here are the changes found in Patchwork_10845 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
==== Possible fixes ====
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (50 -> 46) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_5154 -> Patchwork_10845
CI_DRM_5154: 2ba924da1cb3a684f538e0c25e2409b942a5a35a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10845: 0ba6788d0bf95c105ec437f6bc649c2c0885eeea @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0ba6788d0bf9 drm/i915: Downgrade unknown CSR firmware warnings
ac7ff8ccff7a drm/i915: allow to load DMC firmware on next gen
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10845/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
2018-11-17 1:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen Patchwork
@ 2018-11-18 21:24 ` Patchwork
2018-11-18 22:41 ` ✗ Fi.CI.IGT: failure " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-11-18 21:24 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
URL : https://patchwork.freedesktop.org/series/52639/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5154 -> Patchwork_10846 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52639/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10846:
=== IGT changes ===
==== Possible regressions ====
{igt@runner@aborted}:
fi-icl-u: NOTRUN -> FAIL
== Known issues ==
Here are the changes found in Patchwork_10846 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
igt@i915_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@i915_selftest@live_contexts:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#108315)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
fi-bsw-kefka: FAIL (fdo#108656) -> PASS
igt@i915_module_load@reload:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (50 -> 44) ==
Additional (1): fi-icl-u
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bwr-2160 fi-ctg-p8600 fi-pnv-d510 fi-skl-6700k2
== Build changes ==
* Linux: CI_DRM_5154 -> Patchwork_10846
CI_DRM_5154: 2ba924da1cb3a684f538e0c25e2409b942a5a35a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10846: a37f20f415bd7c47b5ee84c2ae3a8156f90c8673 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a37f20f415bd drm/i915: Downgrade unknown CSR firmware warnings
8ed9055bee37 drm/i915: allow to load DMC firmware on next gen
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10846/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
@ 2018-11-18 22:01 ` Chris Wilson
2018-11-19 10:43 ` Joonas Lahtinen
2018-11-21 9:29 ` Jani Nikula
1 sibling, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2018-11-18 22:01 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Quoting Lucas De Marchi (2018-11-17 00:42:34)
> Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> we have released no firmware yet for a platform, stop scaring the
> consumer and merely note its expected absence.
>
> By simply removing the warning and early return we hit the condition
> with the appropriate message.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index b4476d891fa3..a516697bf57d 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> csr->fw_path = BXT_CSR_PATH;
> csr->required_version = BXT_CSR_VERSION_REQUIRED;
> csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> - } else {
> - MISSING_CASE(INTEL_REVID(dev_priv));
Wider question would be if MISSING_CASE should be CI only. It's meant to
be a warning for us to fix before alpha_support=0, and so should never
reach users or any production system, so the question is moot.
As we have a warning message then the MISSING_CASE is indeed
superfluous here, and the firmware has a different release schedule to
alpha_support so doesn't merit the tight coupling implied by
MISSING_CASE (imo).
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
` (2 preceding siblings ...)
2018-11-18 21:24 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-18 22:41 ` Patchwork
2018-11-19 17:50 ` [PATCH 1/2] " Rodrigo Vivi
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-11-18 22:41 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
URL : https://patchwork.freedesktop.org/series/52639/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5154_full -> Patchwork_10846_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10846_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10846_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10846_full:
=== IGT changes ===
==== Possible regressions ====
igt@gem_eio@suspend:
shard-apl: PASS -> FAIL
igt@gem_tiled_swapping@non-threaded:
shard-kbl: PASS -> DMESG-WARN
igt@pm_rps@waitboost:
shard-skl: PASS -> FAIL
==== Warnings ====
igt@i915_suspend@shrink:
shard-skl: INCOMPLETE (fdo#106886) -> DMESG-WARN
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-wc:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10846_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drm_import_export@import-close-race-flink:
shard-skl: NOTRUN -> TIMEOUT (fdo#108667)
igt@gem_ctx_isolation@vcs0-s3:
shard-apl: PASS -> FAIL (fdo#103375)
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
igt@gem_softpin@noreloc-s3:
shard-skl: NOTRUN -> INCOMPLETE (fdo#104108, fdo#107773)
igt@kms_chv_cursor_fail@pipe-a-128x128-left-edge:
shard-skl: NOTRUN -> FAIL (fdo#104671)
igt@kms_color@pipe-b-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-256x256-offscreen:
shard-skl: NOTRUN -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-glk: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-64x64-onscreen:
shard-apl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538)
igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
shard-glk: PASS -> FAIL (fdo#103184)
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-skl: NOTRUN -> FAIL (fdo#103167) +4
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
shard-glk: PASS -> FAIL (fdo#103167) +3
igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy:
shard-skl: NOTRUN -> FAIL (fdo#105682)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
shard-hsw: PASS -> FAIL (fdo#103375) +1
igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
shard-skl: NOTRUN -> FAIL (fdo#108145) +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_properties@connector-properties-atomic:
shard-skl: NOTRUN -> FAIL (fdo#108642)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_sysfs_edid_timing:
shard-skl: NOTRUN -> FAIL (fdo#100047)
igt@pm_rpm@gem-execbuf:
shard-skl: NOTRUN -> INCOMPLETE (fdo#107807, fdo#107803)
igt@pm_rpm@universal-planes:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
igt@pm_rps@waitboost:
shard-apl: PASS -> FAIL (fdo#102250)
==== Possible fixes ====
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: FAIL (fdo#103232) -> PASS +3
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-skl: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS +2
igt@kms_universal_plane@universal-plane-pipe-a-functional:
shard-glk: FAIL (fdo#103166) -> PASS
igt@pm_rpm@gem-execbuf-stress-pc8:
shard-skl: INCOMPLETE (fdo#107807) -> SKIP
igt@pm_rps@waitboost:
shard-glk: FAIL (fdo#102250) -> PASS
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107803 https://bugs.freedesktop.org/show_bug.cgi?id=107803
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108642 https://bugs.freedesktop.org/show_bug.cgi?id=108642
fdo#108667 https://bugs.freedesktop.org/show_bug.cgi?id=108667
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (7 -> 6) ==
Missing (1): shard-iclb
== Build changes ==
* Linux: CI_DRM_5154 -> Patchwork_10846
CI_DRM_5154: 2ba924da1cb3a684f538e0c25e2409b942a5a35a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10846: a37f20f415bd7c47b5ee84c2ae3a8156f90c8673 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10846/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-18 22:01 ` Chris Wilson
@ 2018-11-19 10:43 ` Joonas Lahtinen
2018-11-19 17:52 ` Rodrigo Vivi
0 siblings, 1 reply; 14+ messages in thread
From: Joonas Lahtinen @ 2018-11-19 10:43 UTC (permalink / raw)
To: Chris Wilson, Lucas De Marchi, intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Quoting Chris Wilson (2018-11-19 00:01:57)
> Quoting Lucas De Marchi (2018-11-17 00:42:34)
> > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> > we have released no firmware yet for a platform, stop scaring the
> > consumer and merely note its expected absence.
> >
> > By simply removing the warning and early return we hit the condition
> > with the appropriate message.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_csr.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index b4476d891fa3..a516697bf57d 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> > csr->fw_path = BXT_CSR_PATH;
> > csr->required_version = BXT_CSR_VERSION_REQUIRED;
> > csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> > - } else {
> > - MISSING_CASE(INTEL_REVID(dev_priv));
>
> Wider question would be if MISSING_CASE should be CI only. It's meant to
> be a warning for us to fix before alpha_support=0, and so should never
> reach users or any production system, so the question is moot.
Especially with the changes into CI log level reporting, we'd have to
actually notice the MISSING_CASE triggers from the inflow of other IGT
warn levels.
MISSING_CASE triggering BUG if alpha_support flag is lifted might be
enough of a hammer to drive the point home if we've missed some?
Regards, Joonas
>
> As we have a warning message then the MISSING_CASE is indeed
> superfluous here, and the firmware has a different release schedule to
> alpha_support so doesn't merit the tight coupling implied by
> MISSING_CASE (imo).
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
` (3 preceding siblings ...)
2018-11-18 22:41 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-11-19 17:50 ` Rodrigo Vivi
2018-11-19 18:24 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-11-20 0:04 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2018-11-19 17:50 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: Jani Nikula, intel-gfx
On Fri, Nov 16, 2018 at 04:42:33PM -0800, Lucas De Marchi wrote:
> Before commit d8a5b7d79fb7 ("drm/i915/csr: keep max firmware size together
> with firmare name and version") it was possible to load the firmware for
> testing purposes via parameter. Let's use the size of the last known
> platform to recover that behavior.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index c1ca6596ff5c..b4476d891fa3 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -34,6 +34,8 @@
> * low-power state and comes back to normal.
> */
>
> +#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
> +
> #define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> @@ -467,7 +469,10 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> */
> intel_display_power_get(dev_priv, POWER_DOMAIN_INIT);
>
> - if (IS_ICELAKE(dev_priv)) {
> + if (INTEL_GEN(dev_priv) >= 12) {
> + /* Allow to load fw via parameter using the last known size */
> + csr->max_fw_size = GEN12_CSR_MAX_FW_SIZE;
> + } else if (IS_ICELAKE(dev_priv)) {
> csr->fw_path = ICL_CSR_PATH;
> csr->required_version = ICL_CSR_VERSION_REQUIRED;
> csr->max_fw_size = ICL_CSR_MAX_FW_SIZE;
> --
> 2.19.1.1.g56c4683e68
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-19 10:43 ` Joonas Lahtinen
@ 2018-11-19 17:52 ` Rodrigo Vivi
0 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2018-11-19 17:52 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: Jani Nikula, intel-gfx, Lucas De Marchi
On Mon, Nov 19, 2018 at 12:43:56PM +0200, Joonas Lahtinen wrote:
> Quoting Chris Wilson (2018-11-19 00:01:57)
> > Quoting Lucas De Marchi (2018-11-17 00:42:34)
> > > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> > > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> > > we have released no firmware yet for a platform, stop scaring the
> > > consumer and merely note its expected absence.
> > >
> > > By simply removing the warning and early return we hit the condition
> > > with the appropriate message.
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_csr.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > > index b4476d891fa3..a516697bf57d 100644
> > > --- a/drivers/gpu/drm/i915/intel_csr.c
> > > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > > @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> > > csr->fw_path = BXT_CSR_PATH;
> > > csr->required_version = BXT_CSR_VERSION_REQUIRED;
> > > csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> > > - } else {
> > > - MISSING_CASE(INTEL_REVID(dev_priv));
> >
> > Wider question would be if MISSING_CASE should be CI only. It's meant to
> > be a warning for us to fix before alpha_support=0, and so should never
> > reach users or any production system, so the question is moot.
>
> Especially with the changes into CI log level reporting, we'd have to
> actually notice the MISSING_CASE triggers from the inflow of other IGT
> warn levels.
>
> MISSING_CASE triggering BUG if alpha_support flag is lifted might be
> enough of a hammer to drive the point home if we've missed some?
I believe that would be too noise that we would never have a reliable CI.
maybe even a chicken and egg for lifting alpha_support...
But for this patch:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Regards, Joonas
>
> >
> > As we have a warning message then the MISSING_CASE is indeed
> > superfluous here, and the firmware has a different release schedule to
> > alpha_support so doesn't merit the tight coupling implied by
> > MISSING_CASE (imo).
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
` (4 preceding siblings ...)
2018-11-19 17:50 ` [PATCH 1/2] " Rodrigo Vivi
@ 2018-11-19 18:24 ` Patchwork
2018-11-20 0:04 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-11-19 18:24 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
URL : https://patchwork.freedesktop.org/series/52639/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5162 -> Patchwork_10850 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52639/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10850 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@i915_selftest@live_contexts:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#108315)
igt@i915_selftest@live_hangcheck:
fi-bwr-2160: PASS -> DMESG-FAIL (fdo#108735)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-skl-6700k2: PASS -> INCOMPLETE (k.org#199541, fdo#105524, fdo#104108)
==== Possible fixes ====
igt@i915_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@i915_selftest@live_contexts:
fi-bsw-kefka: DMESG-FAIL (fdo#108656) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
fdo#108735 https://bugs.freedesktop.org/show_bug.cgi?id=108735
k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541
== Participating hosts (53 -> 47) ==
Additional (1): fi-icl-u
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3
== Build changes ==
* Linux: CI_DRM_5162 -> Patchwork_10850
CI_DRM_5162: 30290ec858904adcb173a94adad2bf2052f95f50 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4720: c27aaca295d3ca2a38521e571c012449371e4bb5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10850: acc22f91ce0fdce184a3a8454ebebebbc711e02a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
acc22f91ce0f drm/i915: Downgrade unknown CSR firmware warnings
ac52df57c52a drm/i915: allow to load DMC firmware on next gen
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10850/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
` (5 preceding siblings ...)
2018-11-19 18:24 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
@ 2018-11-20 0:04 ` Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-11-20 0:04 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next gen
URL : https://patchwork.freedesktop.org/series/52639/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5162_full -> Patchwork_10850_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10850_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10850_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10850_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10850_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@i915_suspend@shrink:
shard-snb: NOTRUN -> DMESG-WARN (fdo#108784)
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#108784)
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-skl: PASS -> FAIL (fdo#108228, fdo#108470)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_ccs@pipe-c-crc-primary-basic:
{shard-iclb}: NOTRUN -> FAIL (fdo#107725)
igt@kms_color@pipe-a-ctm-max:
shard-apl: PASS -> FAIL (fdo#108147)
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
igt@kms_cursor_crc@cursor-256x256-dpms:
shard-skl: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-256x256-random:
shard-apl: PASS -> FAIL (fdo#103232) +3
igt@kms_cursor_crc@cursor-64x64-suspend:
{shard-iclb}: NOTRUN -> FAIL (fdo#103232) +4
igt@kms_cursor_crc@cursor-size-change:
shard-glk: PASS -> FAIL (fdo#103232)
igt@kms_fbcon_fbt@psr:
{shard-iclb}: NOTRUN -> FAIL (fdo#107882)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
shard-apl: PASS -> FAIL (fdo#103167) +1
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu:
shard-skl: PASS -> FAIL (fdo#103167) +5
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
shard-skl: PASS -> FAIL (fdo#105682)
igt@kms_hdmi_inject@inject-audio:
{shard-iclb}: NOTRUN -> FAIL (fdo#102370)
igt@kms_panel_fitting@legacy:
shard-skl: NOTRUN -> FAIL (fdo#105456)
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
shard-skl: NOTRUN -> INCOMPLETE (fdo#104108)
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-glk: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
shard-skl: PASS -> FAIL (fdo#107815, fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#108145)
igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
shard-skl: PASS -> FAIL (fdo#107815)
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +4
igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#107724) +2
igt@pm_backlight@fade_with_suspend:
shard-skl: NOTRUN -> FAIL (fdo#107847)
igt@pm_rpm@i2c:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
igt@pm_rpm@legacy-planes:
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#108654)
igt@pm_rpm@modeset-non-lpsp-stress-no-wait:
shard-skl: SKIP -> INCOMPLETE (fdo#107807)
{igt@runner@aborted}:
{shard-iclb}: NOTRUN -> ( 17 FAIL ) (fdo#108756, fdo#108763)
==== Possible fixes ====
igt@gem_ctx_isolation@rcs0-s3:
shard-kbl: DMESG-WARN (fdo#108566) -> PASS
igt@gem_exec_async@concurrent-writes-vebox:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS +1
igt@gem_workarounds@suspend-resume-fd:
shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS
igt@kms_chv_cursor_fail@pipe-a-128x128-left-edge:
shard-skl: FAIL (fdo#104671) -> PASS
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-skl: INCOMPLETE (fdo#104108) -> PASS
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: FAIL (fdo#106509, fdo#105454) -> PASS
igt@kms_flip@flip-vs-absolute-wf_vblank:
shard-apl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +26
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363, fdo#102887) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
shard-glk: DMESG-FAIL (fdo#105763, fdo#106538, fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
shard-skl: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
{shard-iclb}: FAIL (fdo#103166) -> PASS
igt@pm_rpm@basic-rte:
shard-skl: INCOMPLETE (fdo#107807) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102370 https://bugs.freedesktop.org/show_bug.cgi?id=102370
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105456 https://bugs.freedesktop.org/show_bug.cgi?id=105456
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107725 https://bugs.freedesktop.org/show_bug.cgi?id=107725
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107847 https://bugs.freedesktop.org/show_bug.cgi?id=107847
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
fdo#108470 https://bugs.freedesktop.org/show_bug.cgi?id=108470
fdo#108566 https://bugs.freedesktop.org/show_bug.cgi?id=108566
fdo#108654 https://bugs.freedesktop.org/show_bug.cgi?id=108654
fdo#108756 https://bugs.freedesktop.org/show_bug.cgi?id=108756
fdo#108763 https://bugs.freedesktop.org/show_bug.cgi?id=108763
fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (7 -> 7) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5162 -> Patchwork_10850
CI_DRM_5162: 30290ec858904adcb173a94adad2bf2052f95f50 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4720: c27aaca295d3ca2a38521e571c012449371e4bb5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10850: acc22f91ce0fdce184a3a8454ebebebbc711e02a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10850/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
2018-11-18 22:01 ` Chris Wilson
@ 2018-11-21 9:29 ` Jani Nikula
2018-11-21 17:20 ` Rodrigo Vivi
2018-11-22 0:14 ` Lucas De Marchi
1 sibling, 2 replies; 14+ messages in thread
From: Jani Nikula @ 2018-11-21 9:29 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Rodrigo Vivi
On Fri, 16 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> we have released no firmware yet for a platform, stop scaring the
> consumer and merely note its expected absence.
>
> By simply removing the warning and early return we hit the condition
> with the appropriate message.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
*sigh*
This patch would not have been needed at all with patch 1/2.
The point was that we shouldn't proceed without the max fw size
set. Even with the module parameter. Because that would fail at the
firmware loading stage later.
If the warn was such a big deal, it should've been changed to a debug
message with an early return, not removed.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_csr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index b4476d891fa3..a516697bf57d 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> csr->fw_path = BXT_CSR_PATH;
> csr->required_version = BXT_CSR_VERSION_REQUIRED;
> csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> - } else {
> - MISSING_CASE(INTEL_REVID(dev_priv));
> - return;
> }
>
> if (i915_modparams.dmc_firmware_path) {
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-21 9:29 ` Jani Nikula
@ 2018-11-21 17:20 ` Rodrigo Vivi
2018-11-22 0:14 ` Lucas De Marchi
1 sibling, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2018-11-21 17:20 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Lucas De Marchi
On Wed, Nov 21, 2018 at 11:29:02AM +0200, Jani Nikula wrote:
> On Fri, 16 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> > we have released no firmware yet for a platform, stop scaring the
> > consumer and merely note its expected absence.
> >
> > By simply removing the warning and early return we hit the condition
> > with the appropriate message.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> *sigh*
ops, I just noticed that I forgot to reply here yesterday after
merging these to dinq. :/
>
> This patch would not have been needed at all with patch 1/2.
>
> The point was that we shouldn't proceed without the max fw size
> set. Even with the module parameter. Because that would fail at the
> firmware loading stage later.
>
> If the warn was such a big deal, it should've been changed to a debug
> message with an early return, not removed.
hmmm... that's a good point...
>
> BR,
> Jani.
>
>
> > ---
> > drivers/gpu/drm/i915/intel_csr.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index b4476d891fa3..a516697bf57d 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> > csr->fw_path = BXT_CSR_PATH;
> > csr->required_version = BXT_CSR_VERSION_REQUIRED;
> > csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> > - } else {
> > - MISSING_CASE(INTEL_REVID(dev_priv));
> > - return;
> > }
> >
> > if (i915_modparams.dmc_firmware_path) {
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings
2018-11-21 9:29 ` Jani Nikula
2018-11-21 17:20 ` Rodrigo Vivi
@ 2018-11-22 0:14 ` Lucas De Marchi
1 sibling, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2018-11-22 0:14 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Rodrigo Vivi
On Wed, Nov 21, 2018 at 11:29:02AM +0200, Jani Nikula wrote:
> On Fri, 16 Nov 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
> > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
> > we have released no firmware yet for a platform, stop scaring the
> > consumer and merely note its expected absence.
> >
> > By simply removing the warning and early return we hit the condition
> > with the appropriate message.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> *sigh*
>
> This patch would not have been needed at all with patch 1/2.
>
> The point was that we shouldn't proceed without the max fw size
> set. Even with the module parameter. Because that would fail at the
> firmware loading stage later.
>
> If the warn was such a big deal, it should've been changed to a debug
> message with an early return, not removed.
This was only done to make the code similar to the huc/guc. As I see
this would only be a problem in case we did pass a firmware via param
and not being gen >= 12.
Otherwise the warning (for !alpha) and debug message is unified in a
single place, down a few lines in the same function.
Lucas De Marchi
>
> BR,
> Jani.
>
>
> > ---
> > drivers/gpu/drm/i915/intel_csr.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index b4476d891fa3..a516697bf57d 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -496,9 +496,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
> > csr->fw_path = BXT_CSR_PATH;
> > csr->required_version = BXT_CSR_VERSION_REQUIRED;
> > csr->max_fw_size = BXT_CSR_MAX_FW_SIZE;
> > - } else {
> > - MISSING_CASE(INTEL_REVID(dev_priv));
> > - return;
> > }
> >
> > if (i915_modparams.dmc_firmware_path) {
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-11-22 0:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-17 0:42 [PATCH 1/2] drm/i915: allow to load DMC firmware on next gen Lucas De Marchi
2018-11-17 0:42 ` [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings Lucas De Marchi
2018-11-18 22:01 ` Chris Wilson
2018-11-19 10:43 ` Joonas Lahtinen
2018-11-19 17:52 ` Rodrigo Vivi
2018-11-21 9:29 ` Jani Nikula
2018-11-21 17:20 ` Rodrigo Vivi
2018-11-22 0:14 ` Lucas De Marchi
2018-11-17 1:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: allow to load DMC firmware on next gen Patchwork
2018-11-18 21:24 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-18 22:41 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-19 17:50 ` [PATCH 1/2] " Rodrigo Vivi
2018-11-19 18:24 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-11-20 0:04 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.