[PATCH v2] drm/panel: Set max rate for Innolux p079x panels

[PATCH v2] drm/panel: Set max rate for Innolux p079x panels

[Linus Walleij]

After adding the hs_rate and lp_rate fields to the DSI device
we need to populate these accordingly so display drivers can
respect them.

Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Collect Heiko's Test tag
---
 drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index ca4ae45dd307..2013cd3c58ba 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -518,6 +518,9 @@ static int innolux_panel_probe(struct mipi_dsi_device *dsi)
 	dsi->mode_flags = desc->flags;
 	dsi->format = desc->format;
 	dsi->lanes = desc->lanes;
+	/* This is presumably the HS rate */
+	dsi->hs_rate = desc->mode->clock * 1000;
+	/* FIXME: LP rate not specified */
 
 	err = innolux_panel_add(dsi, desc);
 	if (err < 0)
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/panel: Set max rate for Innolux p079x panels

[Andrzej Hajda]

On 18.11.2018 22:36, Linus Walleij wrote:
> After adding the hs_rate and lp_rate fields to the DSI device
> we need to populate these accordingly so display drivers can
> respect them.
>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Chris Zhong <zyw@rock-chips.com>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Collect Heiko's Test tag
> ---
>  drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index ca4ae45dd307..2013cd3c58ba 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -518,6 +518,9 @@ static int innolux_panel_probe(struct mipi_dsi_device *dsi)
>  	dsi->mode_flags = desc->flags;
>  	dsi->format = desc->format;
>  	dsi->lanes = desc->lanes;
> +	/* This is presumably the HS rate */
> +	dsi->hs_rate = desc->mode->clock * 1000;
> +	/* FIXME: LP rate not specified */


Hmm specs says explicitly 10MHz [1], table 3.6.1.2, symbol FDSICLK_LP.

[1]: http://sqkj.splcd.com/Img/Spec/P079ZCZ-3Z2(V06)2015-06-10.pdf

--
Regards
Andrzej


>  
>  	err = innolux_panel_add(dsi, desc);
>  	if (err < 0)


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel