* [PATCH v3] drm/panel: Set max rate for Innolux p079x panels
@ 2018-11-19 9:15 ` Linus Walleij
2018-11-20 16:28 ` Thierry Reding
2018-11-21 7:04 ` Andrzej Hajda
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2018-11-19 9:15 UTC (permalink / raw)
To: Thierry Reding, dri-devel; +Cc: Chris Zhong, Lin Huang
After adding the hs_rate and lp_rate fields to the DSI device
we need to populate these accordingly so display drivers can
respect them.
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v2->v3:
- Add the 10MHz LP speed.
ChangeLog v1->v2:
- Collect Heiko's Test tag
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index ca4ae45dd307..cca3f3b7710e 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -518,6 +518,10 @@ static int innolux_panel_probe(struct mipi_dsi_device *dsi)
dsi->mode_flags = desc->flags;
dsi->format = desc->format;
dsi->lanes = desc->lanes;
+ /* This is presumably the HS rate */
+ dsi->hs_rate = desc->mode->clock * 1000;
+ /* 10MHz according to table 3.6.1.2, symbol FDSICLK_LP */
+ dsi->lp_rate = 10000000;
err = innolux_panel_add(dsi, desc);
if (err < 0)
--
2.19.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] drm/panel: Set max rate for Innolux p079x panels
2018-11-19 9:15 ` [PATCH v3] drm/panel: Set max rate for Innolux p079x panels Linus Walleij
@ 2018-11-20 16:28 ` Thierry Reding
2018-11-21 7:04 ` Andrzej Hajda
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2018-11-20 16:28 UTC (permalink / raw)
To: Linus Walleij; +Cc: Chris Zhong, Lin Huang, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 739 bytes --]
On Mon, Nov 19, 2018 at 10:15:28AM +0100, Linus Walleij wrote:
> After adding the hs_rate and lp_rate fields to the DSI device
> we need to populate these accordingly so display drivers can
> respect them.
>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Chris Zhong <zyw@rock-chips.com>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v2->v3:
> - Add the 10MHz LP speed.
> ChangeLog v1->v2:
> - Collect Heiko's Test tag
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] drm/panel: Set max rate for Innolux p079x panels
2018-11-19 9:15 ` [PATCH v3] drm/panel: Set max rate for Innolux p079x panels Linus Walleij
2018-11-20 16:28 ` Thierry Reding
@ 2018-11-21 7:04 ` Andrzej Hajda
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2018-11-21 7:04 UTC (permalink / raw)
To: Linus Walleij, Thierry Reding, dri-devel; +Cc: Chris Zhong, Lin Huang
On 19.11.2018 10:15, Linus Walleij wrote:
> After adding the hs_rate and lp_rate fields to the DSI device
> we need to populate these accordingly so display drivers can
> respect them.
>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Chris Zhong <zyw@rock-chips.com>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v2->v3:
> - Add the 10MHz LP speed.
> ChangeLog v1->v2:
> - Collect Heiko's Test tag
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index ca4ae45dd307..cca3f3b7710e 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -518,6 +518,10 @@ static int innolux_panel_probe(struct mipi_dsi_device *dsi)
> dsi->mode_flags = desc->flags;
> dsi->format = desc->format;
> dsi->lanes = desc->lanes;
> + /* This is presumably the HS rate */
> + dsi->hs_rate = desc->mode->clock * 1000;
Again, not true.
hs_rate = pixel_clock * bits_per_pixel / lane / 2;
'/ 2' is due to Double Data Rate' - two bits are transmitted per one tick.
Regards
Andrzej
> + /* 10MHz according to table 3.6.1.2, symbol FDSICLK_LP */
> + dsi->lp_rate = 10000000;
>
> err = innolux_panel_add(dsi, desc);
> if (err < 0)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-21 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20181119091612epcas5p15c28647882e9880f7aea5e4af80a6f35@epcas5p1.samsung.com>
2018-11-19 9:15 ` [PATCH v3] drm/panel: Set max rate for Innolux p079x panels Linus Walleij
2018-11-20 16:28 ` Thierry Reding
2018-11-21 7:04 ` Andrzej Hajda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.