* [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output
@ 2018-11-19 23:01 José Roberto de Souza
2018-11-19 23:32 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: José Roberto de Souza @ 2018-11-19 23:01 UTC (permalink / raw)
To: intel-gfx
When there is no output no one will hold a runtime_pm reference
causing a warning when trying to read emom_status in debugfs.
[22.756480] ------------[ cut here ]------------
[22.756489] RPM wakelock ref not held during HW access
[22.756578] WARNING: CPU: 0 PID: 1058 at drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0 [i915]
[22.756580] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core e1000e snd_pcm mei_me prime_numbers mei lpc_ich
[22.756595] CPU: 0 PID: 1058 Comm: debugfs_test Not tainted 4.20.0-rc1-CI-Trybot_3219+ #1
[22.756597] Hardware name: Hewlett-Packard HP Compaq 8100 Elite SFF PC/304Ah, BIOS 786H1 v01.13 07/14/2011
[22.756634] RIP: 0010:gen5_read32+0x16b/0x1a0 [i915]
[22.756637] Code: a4 ea e0 0f 0b e9 d2 fe ff ff 80 3d a5 71 19 00 00 0f 85 d3 fe ff ff 48 c7 c7 48 d0 2d a0 c6 05 91 71 19 00 01 e8 35 a4 ea e0 <0f> 0b e9 b9 fe ff ff e8 69 c6 f2 e0 85 c0 75 92 48 c7 c2 78 d0 2d
[22.756639] RSP: 0018:ffffc90000f1fd38 EFLAGS: 00010282
[22.756642] RAX: 0000000000000000 RBX: ffff8801f7ab0000 RCX: 0000000000000006
[22.756643] RDX: 0000000000000006 RSI: ffffffff8212886a RDI: ffffffff820d6d57
[22.756645] RBP: 0000000000011020 R08: 0000000043e3d1a8 R09: 0000000000000000
[22.756647] R10: ffffc90000f1fd80 R11: 0000000000000000 R12: 0000000000000001
[22.756649] R13: ffff8801f7ab0068 R14: 0000000000000001 R15: ffff88020d53d188
[22.756651] FS: 00007f2878849980(0000) GS:ffff880213a00000(0000) knlGS:0000000000000000
[22.756653] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[22.756655] CR2: 00005638deedf028 CR3: 0000000203292001 CR4: 00000000000206f0
[22.756657] Call Trace:
[22.756689] i915_mch_val+0x1b/0x60 [i915]
[22.756721] i915_emon_status+0x45/0xd0 [i915]
[22.756730] seq_read+0xdb/0x3c0
[22.756736] ? lockdep_hardirqs_off+0x94/0xd0
[22.756740] ? __slab_free+0x24e/0x510
[22.756746] full_proxy_read+0x52/0x90
[22.756752] __vfs_read+0x31/0x170
[22.756759] ? do_sys_open+0x13b/0x240
[22.756763] ? rcu_read_lock_sched_held+0x6f/0x80
[22.756766] vfs_read+0x9e/0x140
[22.756770] ksys_read+0x50/0xc0
[22.756775] do_syscall_64+0x55/0x190
[22.756781] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[22.756783] RIP: 0033:0x7f28781dc34e
[22.756786] Code: 00 00 00 00 48 8b 15 71 8c 20 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff c3 0f 1f 40 00 8b 05 ba d0 20 00 85 c0 75 16 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5a f3 c3 0f 1f 84 00 00 00 00 00 41 54 55 49
[22.756787] RSP: 002b:00007ffd33fa0d08 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
[22.756790] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f28781dc34e
[22.756792] RDX: 0000000000000200 RSI: 00007ffd33fa0d50 RDI: 0000000000000008
[22.756794] RBP: 00007ffd33fa0f60 R08: 0000000000000000 R09: 0000000000000020
[22.756796] R10: 0000000000000000 R11: 0000000000000246 R12: 00005638de45c2c0
[22.756797] R13: 00007ffd33fa14b0 R14: 0000000000000000 R15: 0000000000000000
[22.756806] irq event stamp: 47950
[22.756811] hardirqs last enabled at (47949): [<ffffffff810fba74>] vprintk_emit+0x124/0x320
[22.756813] hardirqs last disabled at (47950): [<ffffffff810019b0>] trace_hardirqs_off_thunk+0x1a/0x1c
[22.756816] softirqs last enabled at (47518): [<ffffffff81c0033a>] __do_softirq+0x33a/0x4b9
[22.756820] softirqs last disabled at (47479): [<ffffffff8108df29>] irq_exit+0xa9/0xc0
[22.756858] WARNING: CPU: 0 PID: 1058 at drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0 [i915]
[22.756860] ---[ end trace bf56fa7d6a3cbf7a ]
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 670db5073d70..69447c68b9af 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1788,6 +1788,8 @@ static int i915_emon_status(struct seq_file *m, void *unused)
if (!IS_GEN5(dev_priv))
return -ENODEV;
+ intel_runtime_pm_get(dev_priv);
+
ret = mutex_lock_interruptible(&dev->struct_mutex);
if (ret)
return ret;
@@ -1802,6 +1804,8 @@ static int i915_emon_status(struct seq_file *m, void *unused)
seq_printf(m, "GFX power: %ld\n", gfx);
seq_printf(m, "Total power: %ld\n", chipset + gfx);
+ intel_runtime_pm_put(dev_priv);
+
return 0;
}
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/ilk: Fix warning when reading emon_status with no output
2018-11-19 23:01 [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output José Roberto de Souza
@ 2018-11-19 23:32 ` Patchwork
2018-11-20 1:05 ` [PATCH] " Rodrigo Vivi
2018-11-20 7:51 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-19 23:32 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/ilk: Fix warning when reading emon_status with no output
URL : https://patchwork.freedesktop.org/series/52721/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5166 -> Patchwork_10856 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52721/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10856 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-skl-6700k2: PASS -> FAIL (fdo#103375) +3
==== Possible fixes ====
igt@i915_selftest@live_hangcheck:
fi-glk-dsi: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (54 -> 45) ==
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-ctg-p8600 fi-icl-u3 fi-icl-u
== Build changes ==
* Linux: CI_DRM_5166 -> Patchwork_10856
CI_DRM_5166: 75e2b62553fff801c8f2c283d69677c0e3175cb8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4720: c27aaca295d3ca2a38521e571c012449371e4bb5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10856: eeeb25d8a48697ed3bb93ea550a13b55b0edf972 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
eeeb25d8a486 drm/i915/ilk: Fix warning when reading emon_status with no output
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10856/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output
2018-11-19 23:01 [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output José Roberto de Souza
2018-11-19 23:32 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-20 1:05 ` Rodrigo Vivi
2018-11-20 22:07 ` Souza, Jose
2018-11-20 7:51 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2018-11-20 1:05 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Mon, Nov 19, 2018 at 03:01:01PM -0800, José Roberto de Souza wrote:
> When there is no output no one will hold a runtime_pm reference
> causing a warning when trying to read emom_status in debugfs.
>
> [22.756480] ------------[ cut here ]------------
> [22.756489] RPM wakelock ref not held during HW access
> [22.756578] WARNING: CPU: 0 PID: 1058 at drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0 [i915]
> [22.756580] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core e1000e snd_pcm mei_me prime_numbers mei lpc_ich
> [22.756595] CPU: 0 PID: 1058 Comm: debugfs_test Not tainted 4.20.0-rc1-CI-Trybot_3219+ #1
> [22.756597] Hardware name: Hewlett-Packard HP Compaq 8100 Elite SFF PC/304Ah, BIOS 786H1 v01.13 07/14/2011
> [22.756634] RIP: 0010:gen5_read32+0x16b/0x1a0 [i915]
> [22.756637] Code: a4 ea e0 0f 0b e9 d2 fe ff ff 80 3d a5 71 19 00 00 0f 85 d3 fe ff ff 48 c7 c7 48 d0 2d a0 c6 05 91 71 19 00 01 e8 35 a4 ea e0 <0f> 0b e9 b9 fe ff ff e8 69 c6 f2 e0 85 c0 75 92 48 c7 c2 78 d0 2d
> [22.756639] RSP: 0018:ffffc90000f1fd38 EFLAGS: 00010282
> [22.756642] RAX: 0000000000000000 RBX: ffff8801f7ab0000 RCX: 0000000000000006
> [22.756643] RDX: 0000000000000006 RSI: ffffffff8212886a RDI: ffffffff820d6d57
> [22.756645] RBP: 0000000000011020 R08: 0000000043e3d1a8 R09: 0000000000000000
> [22.756647] R10: ffffc90000f1fd80 R11: 0000000000000000 R12: 0000000000000001
> [22.756649] R13: ffff8801f7ab0068 R14: 0000000000000001 R15: ffff88020d53d188
> [22.756651] FS: 00007f2878849980(0000) GS:ffff880213a00000(0000) knlGS:0000000000000000
> [22.756653] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [22.756655] CR2: 00005638deedf028 CR3: 0000000203292001 CR4: 00000000000206f0
> [22.756657] Call Trace:
> [22.756689] i915_mch_val+0x1b/0x60 [i915]
> [22.756721] i915_emon_status+0x45/0xd0 [i915]
> [22.756730] seq_read+0xdb/0x3c0
> [22.756736] ? lockdep_hardirqs_off+0x94/0xd0
> [22.756740] ? __slab_free+0x24e/0x510
> [22.756746] full_proxy_read+0x52/0x90
> [22.756752] __vfs_read+0x31/0x170
> [22.756759] ? do_sys_open+0x13b/0x240
> [22.756763] ? rcu_read_lock_sched_held+0x6f/0x80
> [22.756766] vfs_read+0x9e/0x140
> [22.756770] ksys_read+0x50/0xc0
> [22.756775] do_syscall_64+0x55/0x190
> [22.756781] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> [22.756783] RIP: 0033:0x7f28781dc34e
> [22.756786] Code: 00 00 00 00 48 8b 15 71 8c 20 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff c3 0f 1f 40 00 8b 05 ba d0 20 00 85 c0 75 16 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5a f3 c3 0f 1f 84 00 00 00 00 00 41 54 55 49
> [22.756787] RSP: 002b:00007ffd33fa0d08 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
> [22.756790] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f28781dc34e
> [22.756792] RDX: 0000000000000200 RSI: 00007ffd33fa0d50 RDI: 0000000000000008
> [22.756794] RBP: 00007ffd33fa0f60 R08: 0000000000000000 R09: 0000000000000020
> [22.756796] R10: 0000000000000000 R11: 0000000000000246 R12: 00005638de45c2c0
> [22.756797] R13: 00007ffd33fa14b0 R14: 0000000000000000 R15: 0000000000000000
> [22.756806] irq event stamp: 47950
> [22.756811] hardirqs last enabled at (47949): [<ffffffff810fba74>] vprintk_emit+0x124/0x320
> [22.756813] hardirqs last disabled at (47950): [<ffffffff810019b0>] trace_hardirqs_off_thunk+0x1a/0x1c
> [22.756816] softirqs last enabled at (47518): [<ffffffff81c0033a>] __do_softirq+0x33a/0x4b9
> [22.756820] softirqs last disabled at (47479): [<ffffffff8108df29>] irq_exit+0xa9/0xc0
> [22.756858] WARNING: CPU: 0 PID: 1058 at drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0 [i915]
> [22.756860] ---[ end trace bf56fa7d6a3cbf7a ]
>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 670db5073d70..69447c68b9af 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1788,6 +1788,8 @@ static int i915_emon_status(struct seq_file *m, void *unused)
> if (!IS_GEN5(dev_priv))
> return -ENODEV;
>
> + intel_runtime_pm_get(dev_priv);
> +
> ret = mutex_lock_interruptible(&dev->struct_mutex);
> if (ret)
> return ret;
> @@ -1802,6 +1804,8 @@ static int i915_emon_status(struct seq_file *m, void *unused)
> seq_printf(m, "GFX power: %ld\n", gfx);
> seq_printf(m, "Total power: %ld\n", chipset + gfx);
>
> + intel_runtime_pm_put(dev_priv);
> +
> return 0;
> }
>
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/ilk: Fix warning when reading emon_status with no output
2018-11-19 23:01 [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output José Roberto de Souza
2018-11-19 23:32 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-20 1:05 ` [PATCH] " Rodrigo Vivi
@ 2018-11-20 7:51 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-20 7:51 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/ilk: Fix warning when reading emon_status with no output
URL : https://patchwork.freedesktop.org/series/52721/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5166_full -> Patchwork_10856_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10856_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10856_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10856_full:
=== IGT changes ===
==== Warnings ====
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-snb: SKIP -> PASS +2
== Known issues ==
Here are the changes found in Patchwork_10856_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@in-flight-1us:
shard-glk: PASS -> FAIL (fdo#107799)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@i915_suspend@fence-restore-untiled:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_chv_cursor_fail@pipe-b-256x256-top-edge:
shard-skl: NOTRUN -> FAIL (fdo#104671)
igt@kms_color@pipe-a-ctm-max:
shard-apl: PASS -> FAIL (fdo#108147)
igt@kms_color@pipe-a-degamma:
shard-apl: PASS -> FAIL (fdo#104782, fdo#108145)
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-glk: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: PASS -> FAIL (fdo#103232) +4
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-apl: PASS -> FAIL (fdo#103191, fdo#103232)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#105454, fdo#106509)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-stridechange:
shard-skl: NOTRUN -> FAIL (fdo#105683)
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
shard-skl: NOTRUN -> FAIL (fdo#105682)
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move:
{shard-iclb}: NOTRUN -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
shard-skl: NOTRUN -> FAIL (fdo#103167) +2
igt@kms_pipe_crc_basic@read-crc-pipe-b:
shard-skl: NOTRUN -> FAIL (fdo#107362)
igt@kms_plane@pixel-format-pipe-c-planes:
shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: PASS -> FAIL (fdo#103166) +1
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +2
igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
shard-skl: NOTRUN -> FAIL (fdo#108145) +2
igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
shard-skl: NOTRUN -> FAIL (fdo#107815) +1
igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
{shard-iclb}: PASS -> FAIL (fdo#103166)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@dpms-lpsp:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@gem_softpin@noreloc-s3:
shard-skl: INCOMPLETE (fdo#104108, fdo#107773) -> PASS
igt@kms_chv_cursor_fail@pipe-a-128x128-left-edge:
shard-skl: FAIL (fdo#104671) -> PASS
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-size-change:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_flip@flip-vs-modeset-interruptible:
shard-hsw: DMESG-WARN (fdo#102614) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
shard-skl: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-apl: FAIL (fdo#103166) -> PASS +3
{shard-iclb}: FAIL (fdo#103166) -> PASS
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@pm_rpm@gem-execbuf-stress:
shard-skl: INCOMPLETE (fdo#107803, fdo#107807) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107799 https://bugs.freedesktop.org/show_bug.cgi?id=107799
fdo#107803 https://bugs.freedesktop.org/show_bug.cgi?id=107803
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (7 -> 7) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5166 -> Patchwork_10856
CI_DRM_5166: 75e2b62553fff801c8f2c283d69677c0e3175cb8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4720: c27aaca295d3ca2a38521e571c012449371e4bb5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10856: eeeb25d8a48697ed3bb93ea550a13b55b0edf972 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10856/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output
2018-11-20 1:05 ` [PATCH] " Rodrigo Vivi
@ 2018-11-20 22:07 ` Souza, Jose
2018-11-21 9:26 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Souza, Jose @ 2018-11-20 22:07 UTC (permalink / raw)
To: intel-gfx; +Cc: Vivi, Rodrigo
[-- Attachment #1.1: Type: text/plain, Size: 5448 bytes --]
On Mon, 2018-11-19 at 17:05 -0800, Rodrigo Vivi wrote:
> On Mon, Nov 19, 2018 at 03:01:01PM -0800, José Roberto de Souza
> wrote:
> > When there is no output no one will hold a runtime_pm reference
> > causing a warning when trying to read emom_status in debugfs.
> >
> > [22.756480] ------------[ cut here ]------------
> > [22.756489] RPM wakelock ref not held during HW access
> > [22.756578] WARNING: CPU: 0 PID: 1058 at
> > drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0
> > [i915]
> > [22.756580] Modules linked in: snd_hda_codec_hdmi
> > snd_hda_codec_realtek snd_hda_codec_generic i915 coretemp
> > crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_intel
> > snd_hda_codec snd_hwdep snd_hda_core e1000e snd_pcm mei_me
> > prime_numbers mei lpc_ich
> > [22.756595] CPU: 0 PID: 1058 Comm: debugfs_test Not tainted 4.20.0-
> > rc1-CI-Trybot_3219+ #1
> > [22.756597] Hardware name: Hewlett-Packard HP Compaq 8100 Elite SFF
> > PC/304Ah, BIOS 786H1 v01.13 07/14/2011
> > [22.756634] RIP: 0010:gen5_read32+0x16b/0x1a0 [i915]
> > [22.756637] Code: a4 ea e0 0f 0b e9 d2 fe ff ff 80 3d a5 71 19 00
> > 00 0f 85 d3 fe ff ff 48 c7 c7 48 d0 2d a0 c6 05 91 71 19 00 01 e8
> > 35 a4 ea e0 <0f> 0b e9 b9 fe ff ff e8 69 c6 f2 e0 85 c0 75 92 48 c7
> > c2 78 d0 2d
> > [22.756639] RSP: 0018:ffffc90000f1fd38 EFLAGS: 00010282
> > [22.756642] RAX: 0000000000000000 RBX: ffff8801f7ab0000 RCX:
> > 0000000000000006
> > [22.756643] RDX: 0000000000000006 RSI: ffffffff8212886a RDI:
> > ffffffff820d6d57
> > [22.756645] RBP: 0000000000011020 R08: 0000000043e3d1a8 R09:
> > 0000000000000000
> > [22.756647] R10: ffffc90000f1fd80 R11: 0000000000000000 R12:
> > 0000000000000001
> > [22.756649] R13: ffff8801f7ab0068 R14: 0000000000000001 R15:
> > ffff88020d53d188
> > [22.756651] FS: 00007f2878849980(0000) GS:ffff880213a00000(0000)
> > knlGS:0000000000000000
> > [22.756653] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [22.756655] CR2: 00005638deedf028 CR3: 0000000203292001 CR4:
> > 00000000000206f0
> > [22.756657] Call Trace:
> > [22.756689] i915_mch_val+0x1b/0x60 [i915]
> > [22.756721] i915_emon_status+0x45/0xd0 [i915]
> > [22.756730] seq_read+0xdb/0x3c0
> > [22.756736] ? lockdep_hardirqs_off+0x94/0xd0
> > [22.756740] ? __slab_free+0x24e/0x510
> > [22.756746] full_proxy_read+0x52/0x90
> > [22.756752] __vfs_read+0x31/0x170
> > [22.756759] ? do_sys_open+0x13b/0x240
> > [22.756763] ? rcu_read_lock_sched_held+0x6f/0x80
> > [22.756766] vfs_read+0x9e/0x140
> > [22.756770] ksys_read+0x50/0xc0
> > [22.756775] do_syscall_64+0x55/0x190
> > [22.756781] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> > [22.756783] RIP: 0033:0x7f28781dc34e
> > [22.756786] Code: 00 00 00 00 48 8b 15 71 8c 20 00 f7 d8 64 89 02
> > 48 c7 c0 ff ff ff ff c3 0f 1f 40 00 8b 05 ba d0 20 00 85 c0 75 16
> > 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5a f3 c3 0f 1f 84 00 00 00 00 00
> > 41 54 55 49
> > [22.756787] RSP: 002b:00007ffd33fa0d08 EFLAGS: 00000246 ORIG_RAX:
> > 0000000000000000
> > [22.756790] RAX: ffffffffffffffda RBX: 0000000000000000 RCX:
> > 00007f28781dc34e
> > [22.756792] RDX: 0000000000000200 RSI: 00007ffd33fa0d50 RDI:
> > 0000000000000008
> > [22.756794] RBP: 00007ffd33fa0f60 R08: 0000000000000000 R09:
> > 0000000000000020
> > [22.756796] R10: 0000000000000000 R11: 0000000000000246 R12:
> > 00005638de45c2c0
> > [22.756797] R13: 00007ffd33fa14b0 R14: 0000000000000000 R15:
> > 0000000000000000
> > [22.756806] irq event stamp: 47950
> > [22.756811] hardirqs last enabled at (47949): [<ffffffff810fba74>]
> > vprintk_emit+0x124/0x320
> > [22.756813] hardirqs last disabled at (47950): [<ffffffff810019b0>]
> > trace_hardirqs_off_thunk+0x1a/0x1c
> > [22.756816] softirqs last enabled at (47518): [<ffffffff81c0033a>]
> > __do_softirq+0x33a/0x4b9
> > [22.756820] softirqs last disabled at (47479): [<ffffffff8108df29>]
> > irq_exit+0xa9/0xc0
> > [22.756858] WARNING: CPU: 0 PID: 1058 at
> > drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0
> > [i915]
> > [22.756860] ---[ end trace bf56fa7d6a3cbf7a ]
> >
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks for the review, pushed to drm-intel-next-queued.
>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 670db5073d70..69447c68b9af 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1788,6 +1788,8 @@ static int i915_emon_status(struct seq_file
> > *m, void *unused)
> > if (!IS_GEN5(dev_priv))
> > return -ENODEV;
> >
> > + intel_runtime_pm_get(dev_priv);
> > +
> > ret = mutex_lock_interruptible(&dev->struct_mutex);
> > if (ret)
> > return ret;
> > @@ -1802,6 +1804,8 @@ static int i915_emon_status(struct seq_file
> > *m, void *unused)
> > seq_printf(m, "GFX power: %ld\n", gfx);
> > seq_printf(m, "Total power: %ld\n", chipset + gfx);
> >
> > + intel_runtime_pm_put(dev_priv);
> > +
> > return 0;
> > }
> >
> > --
> > 2.19.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output
2018-11-20 22:07 ` Souza, Jose
@ 2018-11-21 9:26 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-11-21 9:26 UTC (permalink / raw)
To: Souza, Jose, intel-gfx; +Cc: Vivi, Rodrigo
Quoting Souza, Jose (2018-11-20 22:07:14)
> On Mon, 2018-11-19 at 17:05 -0800, Rodrigo Vivi wrote:
> > On Mon, Nov 19, 2018 at 03:01:01PM -0800, José Roberto de Souza
> > wrote:
> > > When there is no output no one will hold a runtime_pm reference
> > > causing a warning when trying to read emom_status in debugfs.
> > >
> > > [22.756480] ------------[ cut here ]------------
> > > [22.756489] RPM wakelock ref not held during HW access
> > > [22.756578] WARNING: CPU: 0 PID: 1058 at
> > > drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0
> > > [i915]
> > > [22.756580] Modules linked in: snd_hda_codec_hdmi
> > > snd_hda_codec_realtek snd_hda_codec_generic i915 coretemp
> > > crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_intel
> > > snd_hda_codec snd_hwdep snd_hda_core e1000e snd_pcm mei_me
> > > prime_numbers mei lpc_ich
> > > [22.756595] CPU: 0 PID: 1058 Comm: debugfs_test Not tainted 4.20.0-
> > > rc1-CI-Trybot_3219+ #1
> > > [22.756597] Hardware name: Hewlett-Packard HP Compaq 8100 Elite SFF
> > > PC/304Ah, BIOS 786H1 v01.13 07/14/2011
> > > [22.756634] RIP: 0010:gen5_read32+0x16b/0x1a0 [i915]
> > > [22.756637] Code: a4 ea e0 0f 0b e9 d2 fe ff ff 80 3d a5 71 19 00
> > > 00 0f 85 d3 fe ff ff 48 c7 c7 48 d0 2d a0 c6 05 91 71 19 00 01 e8
> > > 35 a4 ea e0 <0f> 0b e9 b9 fe ff ff e8 69 c6 f2 e0 85 c0 75 92 48 c7
> > > c2 78 d0 2d
> > > [22.756639] RSP: 0018:ffffc90000f1fd38 EFLAGS: 00010282
> > > [22.756642] RAX: 0000000000000000 RBX: ffff8801f7ab0000 RCX:
> > > 0000000000000006
> > > [22.756643] RDX: 0000000000000006 RSI: ffffffff8212886a RDI:
> > > ffffffff820d6d57
> > > [22.756645] RBP: 0000000000011020 R08: 0000000043e3d1a8 R09:
> > > 0000000000000000
> > > [22.756647] R10: ffffc90000f1fd80 R11: 0000000000000000 R12:
> > > 0000000000000001
> > > [22.756649] R13: ffff8801f7ab0068 R14: 0000000000000001 R15:
> > > ffff88020d53d188
> > > [22.756651] FS: 00007f2878849980(0000) GS:ffff880213a00000(0000)
> > > knlGS:0000000000000000
> > > [22.756653] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [22.756655] CR2: 00005638deedf028 CR3: 0000000203292001 CR4:
> > > 00000000000206f0
> > > [22.756657] Call Trace:
> > > [22.756689] i915_mch_val+0x1b/0x60 [i915]
> > > [22.756721] i915_emon_status+0x45/0xd0 [i915]
> > > [22.756730] seq_read+0xdb/0x3c0
> > > [22.756736] ? lockdep_hardirqs_off+0x94/0xd0
> > > [22.756740] ? __slab_free+0x24e/0x510
> > > [22.756746] full_proxy_read+0x52/0x90
> > > [22.756752] __vfs_read+0x31/0x170
> > > [22.756759] ? do_sys_open+0x13b/0x240
> > > [22.756763] ? rcu_read_lock_sched_held+0x6f/0x80
> > > [22.756766] vfs_read+0x9e/0x140
> > > [22.756770] ksys_read+0x50/0xc0
> > > [22.756775] do_syscall_64+0x55/0x190
> > > [22.756781] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> > > [22.756783] RIP: 0033:0x7f28781dc34e
> > > [22.756786] Code: 00 00 00 00 48 8b 15 71 8c 20 00 f7 d8 64 89 02
> > > 48 c7 c0 ff ff ff ff c3 0f 1f 40 00 8b 05 ba d0 20 00 85 c0 75 16
> > > 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5a f3 c3 0f 1f 84 00 00 00 00 00
> > > 41 54 55 49
> > > [22.756787] RSP: 002b:00007ffd33fa0d08 EFLAGS: 00000246 ORIG_RAX:
> > > 0000000000000000
> > > [22.756790] RAX: ffffffffffffffda RBX: 0000000000000000 RCX:
> > > 00007f28781dc34e
> > > [22.756792] RDX: 0000000000000200 RSI: 00007ffd33fa0d50 RDI:
> > > 0000000000000008
> > > [22.756794] RBP: 00007ffd33fa0f60 R08: 0000000000000000 R09:
> > > 0000000000000020
> > > [22.756796] R10: 0000000000000000 R11: 0000000000000246 R12:
> > > 00005638de45c2c0
> > > [22.756797] R13: 00007ffd33fa14b0 R14: 0000000000000000 R15:
> > > 0000000000000000
> > > [22.756806] irq event stamp: 47950
> > > [22.756811] hardirqs last enabled at (47949): [<ffffffff810fba74>]
> > > vprintk_emit+0x124/0x320
> > > [22.756813] hardirqs last disabled at (47950): [<ffffffff810019b0>]
> > > trace_hardirqs_off_thunk+0x1a/0x1c
> > > [22.756816] softirqs last enabled at (47518): [<ffffffff81c0033a>]
> > > __do_softirq+0x33a/0x4b9
> > > [22.756820] softirqs last disabled at (47479): [<ffffffff8108df29>]
> > > irq_exit+0xa9/0xc0
> > > [22.756858] WARNING: CPU: 0 PID: 1058 at
> > > drivers/gpu/drm/i915/intel_drv.h:2104 gen5_read32+0x16b/0x1a0
> > > [i915]
> > > [22.756860] ---[ end trace bf56fa7d6a3cbf7a ]
> > >
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Thanks for the review, pushed to drm-intel-next-queued.
I have been posting the fix for this for a few years. Cheers.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-21 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 23:01 [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output José Roberto de Souza
2018-11-19 23:32 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-20 1:05 ` [PATCH] " Rodrigo Vivi
2018-11-20 22:07 ` Souza, Jose
2018-11-21 9:26 ` Chris Wilson
2018-11-20 7:51 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.