From: Sagi Grimberg <sagi@grimberg.me> To: linux-nvme@lists.infradead.org Cc: linux-block@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Keith Busch <keith.busch@intel.com>, Christoph Hellwig <hch@lst.de> Subject: [PATCH v2 06/14] datagram: introduce skb_copy_and_hash_datagram_iter helper Date: Mon, 19 Nov 2018 19:00:08 -0800 [thread overview] Message-ID: <20181120030019.31738-8-sagi@grimberg.me> (raw) In-Reply-To: <20181120030019.31738-1-sagi@grimberg.me> Introduce a helper to copy datagram into an iovec iterator but also update a predefined hash. This is useful for consumers of skb_copy_datagram_iter to also support inflight data digest without having to finish to copy and only then traverse the iovec and calculate the digest hash. Signed-off-by: Sagi Grimberg <sagi@grimberg.me> --- include/linux/skbuff.h | 3 +++ net/core/datagram.c | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 0ba687454267..b0b8d5653f0d 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3309,6 +3309,9 @@ static inline int skb_copy_datagram_msg(const struct sk_buff *from, int offset, } int skb_copy_and_csum_datagram_msg(struct sk_buff *skb, int hlen, struct msghdr *msg); +int skb_copy_and_hash_datagram_iter(const struct sk_buff *skb, int offset, + struct iov_iter *to, int len, + struct ahash_request *hash); int skb_copy_datagram_from_iter(struct sk_buff *skb, int offset, struct iov_iter *from, int len); int zerocopy_sg_from_iter(struct sk_buff *skb, struct iov_iter *frm); diff --git a/net/core/datagram.c b/net/core/datagram.c index 382543302ae5..e6a4fc845f72 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -492,6 +492,23 @@ int __skb_datagram_iter(const struct sk_buff *skb, int offset, return 0; } +/** + * skb_copy_and_hash_datagram_iter - Copy datagram to an iovec iterator + * and update a hash. + * @skb: buffer to copy + * @offset: offset in the buffer to start copying from + * @to: iovec iterator to copy to + * @len: amount of data to copy from buffer to iovec + * @hash: hash request to update + */ +int skb_copy_and_hash_datagram_iter(const struct sk_buff *skb, int offset, + struct iov_iter *to, int len, + struct ahash_request *hash) +{ + return __skb_datagram_iter(skb, offset, to, len, true, + hash_and_copy_to_iter, hash); +} + static size_t simple_copy_to_iter(const void *addr, size_t bytes, void *data __always_unused, struct iov_iter *i) { -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg) Subject: [PATCH v2 06/14] datagram: introduce skb_copy_and_hash_datagram_iter helper Date: Mon, 19 Nov 2018 19:00:08 -0800 [thread overview] Message-ID: <20181120030019.31738-8-sagi@grimberg.me> (raw) In-Reply-To: <20181120030019.31738-1-sagi@grimberg.me> Introduce a helper to copy datagram into an iovec iterator but also update a predefined hash. This is useful for consumers of skb_copy_datagram_iter to also support inflight data digest without having to finish to copy and only then traverse the iovec and calculate the digest hash. Signed-off-by: Sagi Grimberg <sagi at grimberg.me> --- include/linux/skbuff.h | 3 +++ net/core/datagram.c | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 0ba687454267..b0b8d5653f0d 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3309,6 +3309,9 @@ static inline int skb_copy_datagram_msg(const struct sk_buff *from, int offset, } int skb_copy_and_csum_datagram_msg(struct sk_buff *skb, int hlen, struct msghdr *msg); +int skb_copy_and_hash_datagram_iter(const struct sk_buff *skb, int offset, + struct iov_iter *to, int len, + struct ahash_request *hash); int skb_copy_datagram_from_iter(struct sk_buff *skb, int offset, struct iov_iter *from, int len); int zerocopy_sg_from_iter(struct sk_buff *skb, struct iov_iter *frm); diff --git a/net/core/datagram.c b/net/core/datagram.c index 382543302ae5..e6a4fc845f72 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -492,6 +492,23 @@ int __skb_datagram_iter(const struct sk_buff *skb, int offset, return 0; } +/** + * skb_copy_and_hash_datagram_iter - Copy datagram to an iovec iterator + * and update a hash. + * @skb: buffer to copy + * @offset: offset in the buffer to start copying from + * @to: iovec iterator to copy to + * @len: amount of data to copy from buffer to iovec + * @hash: hash request to update + */ +int skb_copy_and_hash_datagram_iter(const struct sk_buff *skb, int offset, + struct iov_iter *to, int len, + struct ahash_request *hash) +{ + return __skb_datagram_iter(skb, offset, to, len, true, + hash_and_copy_to_iter, hash); +} + static size_t simple_copy_to_iter(const void *addr, size_t bytes, void *data __always_unused, struct iov_iter *i) { -- 2.17.1
next prev parent reply other threads:[~2018-11-20 3:01 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-20 3:00 [PATCH v2 00/14] TCP transport binding for NVMe over Fabrics Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 01/14] ath6kl: add ath6kl_ prefix to crypto_type Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 02/14] datagram: open-code copy_page_to_iter Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 03/14] iov_iter: pass void csum pointer to csum_and_copy_to_iter Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 04/14] datagram: consolidate datagram copy to iter helpers Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 04/14] net/datagram: " Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 05/14] iov_iter: introduce hash_and_copy_to_iter helper Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg [this message] 2018-11-20 3:00 ` [PATCH v2 06/14] datagram: introduce skb_copy_and_hash_datagram_iter helper Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 07/14] nvme-core: add work elements to struct nvme_ctrl Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:04 ` Christoph Hellwig 2018-11-21 13:04 ` Christoph Hellwig 2018-11-21 22:28 ` Sagi Grimberg 2018-11-21 22:28 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 08/14] nvmet: Add install_queue callout Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:05 ` Christoph Hellwig 2018-11-21 13:05 ` Christoph Hellwig 2018-11-20 3:00 ` [PATCH v2 09/14] nvmet: allow configfs tcp trtype configuration Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:05 ` Christoph Hellwig 2018-11-21 13:05 ` Christoph Hellwig 2018-11-20 3:00 ` [PATCH v2 10/14] nvme-fabrics: allow user passing header digest Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:06 ` Christoph Hellwig 2018-11-21 13:06 ` Christoph Hellwig 2018-11-20 3:00 ` [PATCH v2 11/14] nvme-fabrics: allow user passing data digest Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:06 ` Christoph Hellwig 2018-11-21 13:06 ` Christoph Hellwig 2018-11-20 3:00 ` [PATCH v2 12/14] nvme-tcp: Add protocol header Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 13/14] nvmet-tcp: add NVMe over TCP target driver Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-21 13:07 ` Christoph Hellwig 2018-11-21 13:07 ` Christoph Hellwig 2018-11-21 22:29 ` Sagi Grimberg 2018-11-21 22:29 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 23:34 ` Narayan Ayalasomayajula 2018-11-20 23:34 ` Narayan Ayalasomayajula 2018-11-20 23:34 ` Narayan Ayalasomayajula 2018-11-21 0:10 ` Sagi Grimberg 2018-11-21 0:10 ` Sagi Grimberg 2018-11-21 0:10 ` Sagi Grimberg 2018-11-21 0:41 ` Ethan Weidman 2018-11-21 0:41 ` Ethan Weidman 2018-11-21 5:43 ` Sagi Grimberg 2018-11-21 5:43 ` Sagi Grimberg 2018-11-21 8:56 ` Christoph Hellwig 2018-11-21 8:56 ` Christoph Hellwig 2018-11-21 22:27 ` Sagi Grimberg 2018-11-21 22:27 ` Sagi Grimberg 2018-11-21 12:01 ` Mikhail Skorzhinskii 2018-11-21 12:01 ` Mikhail Skorzhinskii 2018-11-21 22:28 ` Sagi Grimberg 2018-11-21 22:28 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH nvme-cli v2 15/14] nvme: Add TCP transport Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 9:36 ` Arend van Spriel 2018-11-20 9:36 ` Arend van Spriel 2018-11-20 22:56 ` Sagi Grimberg 2018-11-20 22:56 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH nvme-cli v2 16/14] fabrics: add tcp port tsas decoding Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg 2018-11-20 3:00 ` [PATCH nvme-cli v2 17/14] fabrics: add transport header and data digest Sagi Grimberg 2018-11-20 3:00 ` Sagi Grimberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181120030019.31738-8-sagi@grimberg.me \ --to=sagi@grimberg.me \ --cc=davem@davemloft.net \ --cc=hch@lst.de \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.