[U-Boot] [PATCH 1/2] armv8: ls1043ardb: Add the nand_bootcmd definition

[U-Boot] [PATCH 1/2] armv8: ls1043ardb: Add the nand_bootcmd definition

[Wen He]

nand_bootcmd doest not exist, it should be support
for nand auto boot up.

Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 include/configs/ls1043a_common.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h
index 3d6ce2c..795e904 100644
--- a/include/configs/ls1043a_common.h
+++ b/include/configs/ls1043a_common.h
@@ -258,6 +258,8 @@
 	"fdtheader_addr_r=0x80100000\0"		\
 	"kernelheader_addr_r=0x80200000\0"	\
 	"kernel_addr_r=0x81000000\0"		\
+	"kernel_start=0x1000000\0"		\
+	"kernelheader_start=0x800000\0"		\
 	"fdt_addr_r=0x90000000\0"		\
 	"load_addr=0xa0000000\0"		\
 	"kernelheader_addr=0x60800000\0"	\
@@ -310,6 +312,12 @@
 		"&& cp.b $kernelheader_addr $kernelheader_addr_r "	\
 		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
 		"bootm $load_addr#$board\0"	    \
+	"nand_bootcmd=echo Trying load from NAND..;"	\
+		"nand info; nand read $load_addr "	\
+		"$kernel_start $kernel_size; env exists secureboot "	\
+		"&& nand read $kernelheader_addr_r $kernelheader_start "	\
+		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
+		"bootm $load_addr#$board\0"	\
 	"sd_bootcmd=echo Trying load from SD ..;"       \
 		"mmcinfo; mmc read $load_addr "         \
 		"$kernel_addr_sd $kernel_size_sd && "     \
-- 
2.7.4

[U-Boot] [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd definition

[Wen He]

Fix the kernel offset of qspi_bootcmd scripts, followed
the qoriq_memory_layout definition.

Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 include/configs/ls1043a_common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h
index 795e904..7b2f31c 100644
--- a/include/configs/ls1043a_common.h
+++ b/include/configs/ls1043a_common.h
@@ -302,8 +302,8 @@
 		"source ${scriptaddr}\0"			\
 	"qspi_bootcmd=echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
-		"$kernel_addr $kernel_size; env exists secureboot "	\
-		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
+		"$kernel_start $kernel_size; env exists secureboot "	\
+		"&& sf read $kernelheader_addr_r $kernelheader_start "	\
 		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
 		"bootm $load_addr#$board\0"	\
 	"nor_bootcmd=echo Trying load from nor..;"	\
-- 
2.7.4

[U-Boot] [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd definition

[York Sun]

On 11/20/18 12:55 AM, Wen He wrote:
> Fix the kernel offset of qspi_bootcmd scripts, followed
> the qoriq_memory_layout definition.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  include/configs/ls1043a_common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h
> index 795e904..7b2f31c 100644
> --- a/include/configs/ls1043a_common.h
> +++ b/include/configs/ls1043a_common.h
> @@ -302,8 +302,8 @@
>  		"source ${scriptaddr}\0"			\
>  	"qspi_bootcmd=echo Trying load from qspi..;"	\
>  		"sf probe && sf read $load_addr "	\
> -		"$kernel_addr $kernel_size; env exists secureboot "	\
> -		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
> +		"$kernel_start $kernel_size; env exists secureboot "	\
> +		"&& sf read $kernelheader_addr_r $kernelheader_start "	\
>  		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
>  		"bootm $load_addr#$board\0"	\
>  	"nor_bootcmd=echo Trying load from nor..;"	\
> 

Why do you need to copy the images from QSPI flash? It is directly
readable. It has been this way and it is not your fault. Can you fix it?

York

[U-Boot] [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd definition

[Wen He]

> -----Original Message-----
> From: York Sun
> Sent: 2018年11月21日 0:58
> To: Wen He <wen.he_1@nxp.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Alison Wang
> <alison.wang@nxp.com>
> Subject: Re: [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd
> definition
> 
> On 11/20/18 12:55 AM, Wen He wrote:
> > Fix the kernel offset of qspi_bootcmd scripts, followed the
> > qoriq_memory_layout definition.
> >
> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > ---
> >  include/configs/ls1043a_common.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/configs/ls1043a_common.h
> > b/include/configs/ls1043a_common.h
> > index 795e904..7b2f31c 100644
> > --- a/include/configs/ls1043a_common.h
> > +++ b/include/configs/ls1043a_common.h
> > @@ -302,8 +302,8 @@
> >  		"source ${scriptaddr}\0"			\
> >  	"qspi_bootcmd=echo Trying load from qspi..;"	\
> >  		"sf probe && sf read $load_addr "	\
> > -		"$kernel_addr $kernel_size; env exists secureboot "	\
> > -		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
> > +		"$kernel_start $kernel_size; env exists secureboot "	\
> > +		"&& sf read $kernelheader_addr_r $kernelheader_start "	\
> >  		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
> >  		"bootm $load_addr#$board\0"	\
> >  	"nor_bootcmd=echo Trying load from nor..;"	\
> >
> 
> Why do you need to copy the images from QSPI flash? It is directly readable. It
> has been this way and it is not your fault. Can you fix it?
> 

For now, we only supported DDR loading that need copy the images from QSPI/NAND/SD/NOR flash.
Will add support directly readable from QSPI and NOR flash in next LSDK.

Best Regards,
Wen

> York

[U-Boot] [PATCH 1/2] armv8: ls1043ardb: Add the nand_bootcmd definition

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Wen He <wen.he_1@nxp.com>
> Sent: Tuesday, November 20, 2018 2:34 PM
> To: u-boot at lists.denx.de; York Sun <york.sun@nxp.com>
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Alison Wang
> <alison.wang@nxp.com>; Wen He <wen.he_1@nxp.com>
> Subject: [PATCH 1/2] armv8: ls1043ardb: Add the nand_bootcmd definition
> 
> nand_bootcmd doest not exist, it should be support for nand auto boot up.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>

This patch been applied to fsl-qoriq master, awaiting upstream.

--pk