* [PATCH] sched/rt: Fix -Wmissing-prototypes warnings
@ 2018-11-13 0:54 Yi Wang
2018-11-20 12:16 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2018-11-13 0:54 UTC (permalink / raw)
To: mingo; +Cc: peterz, bp, linux-kernel, zhong.weidong, Yi Wang
We get a warning when building kernel with W=1:
kernel/sched/rt.c:626:6: warning: no previous prototype for ‘sched_rt_bandwidth_account’ [-Wmissing-prototypes]
bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
Add the missing declaration to fix this.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
kernel/sched/sched.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 618577f..f5f29fc 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -442,6 +442,7 @@ extern void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq,
extern void free_rt_sched_group(struct task_group *tg);
extern int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent);
+extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
extern void init_tg_rt_entry(struct task_group *tg, struct rt_rq *rt_rq,
struct sched_rt_entity *rt_se, int cpu,
struct sched_rt_entity *parent);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched/rt: Fix -Wmissing-prototypes warnings
2018-11-13 0:54 [PATCH] sched/rt: Fix -Wmissing-prototypes warnings Yi Wang
@ 2018-11-20 12:16 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2018-11-20 12:16 UTC (permalink / raw)
To: Yi Wang; +Cc: mingo, bp, linux-kernel, zhong.weidong
On Tue, Nov 13, 2018 at 08:54:34AM +0800, Yi Wang wrote:
> We get a warning when building kernel with W=1:
> kernel/sched/rt.c:626:6: warning: no previous prototype for ‘sched_rt_bandwidth_account’ [-Wmissing-prototypes]
> bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
>
> Add the missing declaration to fix this.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
> kernel/sched/sched.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 618577f..f5f29fc 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -442,6 +442,7 @@ extern void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq,
>
> extern void free_rt_sched_group(struct task_group *tg);
> extern int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent);
> +extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
> extern void init_tg_rt_entry(struct task_group *tg, struct rt_rq *rt_rq,
> struct sched_rt_entity *rt_se, int cpu,
> struct sched_rt_entity *parent);
This would then also render the declaration in sched/deadline.c
redundant.
Or am I missing something?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-20 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 0:54 [PATCH] sched/rt: Fix -Wmissing-prototypes warnings Yi Wang
2018-11-20 12:16 ` Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.