From: Niklas Cassel <niklas.cassel@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>,
viresh.kumar@linaro.org, sboyd@kernel.org, andy.gross@linaro.org,
ulf.hansson@linaro.org, collinsd@codeaurora.org,
mka@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR
Date: Tue, 20 Nov 2018 17:14:57 +0100 [thread overview]
Message-ID: <20181120161457.GA12783@centauri.lan> (raw)
In-Reply-To: <eab94dd1-1d8f-4306-cced-1e34171ef1e7@codeaurora.org>
On Tue, Nov 20, 2018 at 09:42:05AM +0530, Rajendra Nayak wrote:
>
>
> On 11/9/2018 10:09 PM, Niklas Cassel wrote:
> > On Mon, Nov 05, 2018 at 05:17:45PM -0600, Rob Herring wrote:
> > > On Mon, Oct 15, 2018 at 02:47:49PM +0200, Niklas Cassel wrote:
> > > > Extend qcom-opp bindings with properties needed for Core Power Reduction
> > > > (CPR).
> > > >
> > > > CPR is included in a great variety of Qualcomm SoC, e.g. msm8916 and
> > > > msm8996, and was first introduced in msm8974.
> > > >
> > > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> > > > ---
> > > > Hello Rob, Rajendra,
> > > >
> > > > Sorry for not replying sooner.
> > > > Since Rob wanted the binding to be complete before merging,
> > > > this is my proposal to extend the OPP binding with properties
> > > > needed to support CPR (both for msm8916 and msm8996).
> > > > I've discussed the proposal with Viresh, and this proposal
> > > > seems better than what I previously suggested here:
> > > > https://lore.kernel.org/lkml/20181005204424.GA29500@centauri.lan/
> > > >
> > > > .../devicetree/bindings/opp/qcom-opp.txt | 19 +++++++++++++++++++
> > > > 1 file changed, 19 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/opp/qcom-opp.txt b/Documentation/devicetree/bindings/opp/qcom-opp.txt
> > > > index db4d970c7ec7..3ab5dd84de86 100644
> > > > --- a/Documentation/devicetree/bindings/opp/qcom-opp.txt
> > > > +++ b/Documentation/devicetree/bindings/opp/qcom-opp.txt
> > > > @@ -23,3 +23,22 @@ Required properties:
> > > > representing a corner/level that's communicated with a remote microprocessor
> > > > (usually called the RPM) which then translates it into a certain voltage on
> > > > a voltage rail.
> > >
> > > I've lost the context here. Please send this all together.
> >
> > Will do, as soon as I've gotten your feedback on this mail.
>
> Niklas, are you still waiting for feedback on this mail from Rob?
Yes.
Rajendra, I realize that your patches have been ready for merging for
a long time, and this fuse-level is quite complex, so the discussion
has been taken longer than expected. Sorry for that.
Hopefully Rob will reply soon, or perhaps he could agree to merge your
binding as is, and I could extend it later, when we have reached a
consensus.
Kind regards,
Niklas
next prev parent reply other threads:[~2018-11-20 16:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 4:52 [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 1/6] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-07-03 22:35 ` Rob Herring
2018-07-04 5:57 ` Viresh Kumar
2018-08-30 6:31 ` Rajendra Nayak
2018-09-20 18:51 ` Rob Herring
2018-09-25 10:25 ` Rajendra Nayak
2018-09-25 19:43 ` Rob Herring
2018-10-04 8:36 ` Viresh Kumar
2018-10-04 15:18 ` Rob Herring
2018-10-04 19:17 ` Niklas Cassel
2018-10-04 22:17 ` Rob Herring
2018-10-05 20:44 ` Niklas Cassel
2018-10-15 12:47 ` [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR Niklas Cassel
2018-10-22 5:45 ` Viresh Kumar
2018-11-05 23:17 ` Rob Herring
2018-11-09 16:39 ` Niklas Cassel
2018-11-20 4:12 ` Rajendra Nayak
2018-11-20 16:14 ` Niklas Cassel [this message]
2018-11-27 5:04 ` Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 3/6] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 4/6] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 5/6] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 6/6] soc: qcom: rpmhpd: Add RPMh Power domain driver Rajendra Nayak
2018-08-30 6:35 ` [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-08-30 8:21 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120161457.GA12783@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.