All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajendra Nayak <rnayak@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Andy Gross <andy.gross@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	David Collins <collinsd@codeaurora.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	devicetree@vger.kernel.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings
Date: Tue, 25 Sep 2018 15:55:05 +0530	[thread overview]
Message-ID: <271db7b1-f65b-f42d-b00b-9362429b3749@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqJe+m4hD3nxQDjOT1JzRoSMXppy1r6APV1w=NtgCr-X_A@mail.gmail.com>

Hi Rob,

[]...
>>>>> +   rpmhpd_opp_table: opp-table {
>>>>> +           compatible = "operating-points-v2-qcom-level";
>>>>> +
>>>>> +           rpmhpd_opp_ret: opp1 {
>>>>> +                   qcom,level = <RPMH_REGULATOR_LEVEL_RETENTION>;
>>>>> +           };
>>>>
>>>> I don't see the point in using the OPP binding here when you aren't
>>>> using *any* of the properties from it.
>>>
>>> Yeah, that's the case for now. But there are cases (as Stephen
>>> mentioned earlier [1]) where the voltage values (and maybe other
>>> values like current, etc) would be known and filled in DT. And that's
>>> why we all agreed to use OPP tables for PM domains as well, as these
>>> are really "operating performance points" of these PM domains.
>>
>> Rob, are you fine with these bindings then?
> 
> Okay, my only thought is whether we should just use 'reg' here, or do
> we need 'level' for anything else and should make it common?

I am not quite sure I understood what you are suggesting here :(

  reply	other threads:[~2018-09-25 10:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  4:52 [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 1/6] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-07-03 22:35   ` Rob Herring
2018-07-04  5:57     ` Viresh Kumar
2018-08-30  6:31       ` Rajendra Nayak
2018-09-20 18:51         ` Rob Herring
2018-09-25 10:25           ` Rajendra Nayak [this message]
2018-09-25 19:43             ` Rob Herring
2018-10-04  8:36               ` Viresh Kumar
2018-10-04 15:18                 ` Rob Herring
2018-10-04 19:17                   ` Niklas Cassel
2018-10-04 22:17                     ` Rob Herring
2018-10-05 20:44                       ` Niklas Cassel
2018-10-15 12:47   ` [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR Niklas Cassel
2018-10-22  5:45     ` Viresh Kumar
2018-11-05 23:17     ` Rob Herring
2018-11-09 16:39       ` Niklas Cassel
2018-11-20  4:12         ` Rajendra Nayak
2018-11-20 16:14           ` Niklas Cassel
2018-11-27  5:04             ` Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 3/6] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 4/6] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 5/6] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-06-27  4:52 ` [PATCH v4 6/6] soc: qcom: rpmhpd: Add RPMh Power domain driver Rajendra Nayak
2018-08-30  6:35 ` [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-08-30  8:21   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=271db7b1-f65b-f42d-b00b-9362429b3749@codeaurora.org \
    --to=rnayak@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.