* [PATCH] mtd: spi-nor: Add support for mx25u12835f
@ 2018-07-13 13:06 Alexander Sverdlin
2018-11-20 16:28 ` Tudor.Ambarus
2018-11-21 13:09 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2018-07-13 13:06 UTC (permalink / raw)
To: linux-mtd
Cc: Alexander Sverdlin, Marek Vasut, David Woodhouse, Brian Norris,
Boris Brezillon, Richard Weinberger
This chip supports dual and quad read and uniform 4K-byte erase.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
Based on spi-nor/next branch of git://git.infradead.org/l2-mtd.git
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d9c368c44194..f9832293b689 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1088,6 +1088,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
+ { "mx25u12835f", INFO(0xc22538, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for mx25u12835f
2018-07-13 13:06 [PATCH] mtd: spi-nor: Add support for mx25u12835f Alexander Sverdlin
@ 2018-11-20 16:28 ` Tudor.Ambarus
2018-11-21 13:09 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Tudor.Ambarus @ 2018-11-20 16:28 UTC (permalink / raw)
To: alexander.sverdlin, linux-mtd
Cc: marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
On 07/13/2018 04:06 PM, Alexander Sverdlin wrote:
> This chip supports dual and quad read and uniform 4K-byte erase.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Based on spi-nor/next branch of git://git.infradead.org/l2-mtd.git
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d9c368c44194..f9832293b689 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1088,6 +1088,7 @@ static const struct flash_info spi_nor_ids[] = {
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> + { "mx25u12835f", INFO(0xc22538, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
nit on style: I find easier to read the declarations when they fit in the
80-chars limit. There are 2 styles that meet this in spi_nor_ids[]:
{
"gd25q16", INFO(0xc84015, 0, 64 * 1024, 32,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
and
{ "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 512,
SECT_4K | SPI_NOR_DUAL_READ) },
we should choose one and be consistent across flash_info declarations.
The info in patch is good, so:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
> { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mtd: spi-nor: Add support for mx25u12835f
2018-07-13 13:06 [PATCH] mtd: spi-nor: Add support for mx25u12835f Alexander Sverdlin
2018-11-20 16:28 ` Tudor.Ambarus
@ 2018-11-21 13:09 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-11-21 13:09 UTC (permalink / raw)
To: Alexander Sverdlin, linux-mtd
Cc: Boris Brezillon, Richard Weinberger, Marek Vasut, Brian Norris,
David Woodhouse
On Fri, 2018-07-13 at 13:06:46 UTC, Alexander Sverdlin wrote:
> This chip supports dual and quad read and uniform 4K-byte erase.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-21 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 13:06 [PATCH] mtd: spi-nor: Add support for mx25u12835f Alexander Sverdlin
2018-11-20 16:28 ` Tudor.Ambarus
2018-11-21 13:09 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.