[PATCH] automation: git clean between builds

[PATCH] automation: git clean between builds

[Wei Liu]

Currently randconfig tests are more likely to fail than to succeed
because of a bug in xen's build system: symbols-dummy.o's dependency
is wrong, which causes it to not get rebuild between runs, which
eventually causes linking to fail. There may also be other corner
cases we haven't discovered.

The fix is not straightforward. For now, make sure the tree is cleaned
properly between builds so we don't see random failures in Gitlab CI.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 automation/scripts/build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index e3672a3626..9d82e1d612 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -42,7 +42,7 @@ esac
 cfg_dir="automation/configs/${arch}"
 for cfg in `ls ${cfg_dir}`; do
     echo "Building $cfg"
-    rm -f xen/.config
+    git clean -fdxq
     make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig
     make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y
 done
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: git clean between builds

[Doug Goldstein]

> On Nov 21, 2018, at 10:32 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> Currently randconfig tests are more likely to fail than to succeed
> because of a bug in xen's build system: symbols-dummy.o's dependency
> is wrong, which causes it to not get rebuild between runs, which
> eventually causes linking to fail. There may also be other corner
> cases we haven't discovered.
> 
> The fix is not straightforward. For now, make sure the tree is cleaned
> properly between builds so we don't see random failures in Gitlab CI.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 

Sounds good as a fix for now to get us going. 

Acked-by: Doug Goldstein <cardoe@cardoe.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: git clean between builds

[Wei Liu]

On Wed, Nov 21, 2018 at 10:51:55AM -0600, Doug Goldstein wrote:
> 
> > On Nov 21, 2018, at 10:32 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> > 
> > Currently randconfig tests are more likely to fail than to succeed
> > because of a bug in xen's build system: symbols-dummy.o's dependency
> > is wrong, which causes it to not get rebuild between runs, which
> > eventually causes linking to fail. There may also be other corner
> > cases we haven't discovered.
> > 
> > The fix is not straightforward. For now, make sure the tree is cleaned
> > properly between builds so we don't see random failures in Gitlab CI.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> 
> Sounds good as a fix for now to get us going. 
> 
> Acked-by: Doug Goldstein <cardoe@cardoe.com>

I think I will need to switch from git clean to make clean to avoid
wiping out all the artifacts. Does your ack still stand?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: git clean between builds

[Doug Goldstein]

> On Nov 21, 2018, at 11:07 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> 
>> On Wed, Nov 21, 2018 at 10:51:55AM -0600, Doug Goldstein wrote:
>> 
>>> On Nov 21, 2018, at 10:32 AM, Wei Liu <wei.liu2@citrix.com> wrote:
>>> 
>>> Currently randconfig tests are more likely to fail than to succeed
>>> because of a bug in xen's build system: symbols-dummy.o's dependency
>>> is wrong, which causes it to not get rebuild between runs, which
>>> eventually causes linking to fail. There may also be other corner
>>> cases we haven't discovered.
>>> 
>>> The fix is not straightforward. For now, make sure the tree is cleaned
>>> properly between builds so we don't see random failures in Gitlab CI.
>>> 
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> 
>> 
>> Sounds good as a fix for now to get us going. 
>> 
>> Acked-by: Doug Goldstein <cardoe@cardoe.com>
> 
> I think I will need to switch from git clean to make clean to avoid
> wiping out all the artifacts. Does your ack still stand?
> 
> Wei.

Yes. 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel