All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use
@ 2018-11-23  6:46 linzhecheng
  2018-11-26 10:10 ` Gerd Hoffmann
  0 siblings, 1 reply; 2+ messages in thread
From: linzhecheng @ 2018-11-23  6:46 UTC (permalink / raw)
  To: qemu-devel; +Cc: kraxel, maoming.maoming, Wang Xin

From: Wang Xin <wangxinxin.wang@huawei.com>

The cirrus bank0/1 offset should be updated before we update the vram's alias
offset.

Signed-off-by: Wang Xin <wangxinxin.wang@huawei.com>

diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index d9b854d..a0e7146 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -2746,11 +2746,12 @@ static int cirrus_post_load(void *opaque, int version_id)
     s->vga.gr[0x00] = s->cirrus_shadow_gr0 & 0x0f;
     s->vga.gr[0x01] = s->cirrus_shadow_gr1 & 0x0f;
 
+    cirrus_update_bank_ptr(s, 0);
+    cirrus_update_bank_ptr(s, 1);
     cirrus_update_memory_access(s);
     /* force refresh */
     s->vga.graphic_mode = -1;
-    cirrus_update_bank_ptr(s, 0);
-    cirrus_update_bank_ptr(s, 1);
+
     return 0;
 }
 
-- 
2.8.1.windows.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use
  2018-11-23  6:46 [Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use linzhecheng
@ 2018-11-26 10:10 ` Gerd Hoffmann
  0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2018-11-26 10:10 UTC (permalink / raw)
  To: linzhecheng; +Cc: qemu-devel, maoming.maoming, Wang Xin

On Fri, Nov 23, 2018 at 02:46:46PM +0800, linzhecheng wrote:
> From: Wang Xin <wangxinxin.wang@huawei.com>
> 
> The cirrus bank0/1 offset should be updated before we update the vram's alias
> offset.

Queued for 3.1

thanks,
  Gerd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-26 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23  6:46 [Qemu-devel] [PATCH] cirrus_vga/migration: update the bank offset before use linzhecheng
2018-11-26 10:10 ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.