From: Michal Hocko <mhocko@kernel.org> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Pavel Tatashin <pasha.tatashin@oracle.com>, Alexander Duyck <alexander.h.duyck@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: debug: Fix a width vs precision bug in printk Date: Fri, 23 Nov 2018 09:01:25 +0000 [thread overview] Message-ID: <20181123090125.GC8625@dhcp22.suse.cz> (raw) In-Reply-To: <20181123072135.gqvblm2vdujbvfjs@kili.mountain> On Fri 23-11-18 10:21:35, Dan Carpenter wrote: > We had intended to only print dentry->d_name.len characters but there is > a width vs precision typo so if the name isn't NUL terminated it will > read past the end of the buffer. OK, it took me quite some time to grasp what you mean here. The code works as expected because d_name.len and dname.name are in sync so there no spacing going to happen. Anyway what you propose is formally more correct I guess. > Fixes: 408ddbc22be3 ("mm: print more information about mapping in __dump_page") This sha is an unstable sha for mmotm patch. > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Michal Hocko <mhocko@suse.com> Thanks! > --- > mm/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug.c b/mm/debug.c > index d18c5cea3320..faf856b652b6 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -80,7 +80,7 @@ void __dump_page(struct page *page, const char *reason) > if (mapping->host->i_dentry.first) { > struct dentry *dentry; > dentry = container_of(mapping->host->i_dentry.first, struct dentry, d_u.d_alias); > - pr_warn("name:\"%*s\" ", dentry->d_name.len, dentry->d_name.name); > + pr_warn("name:\"%.*s\" ", dentry->d_name.len, dentry->d_name.name); > } > } > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > -- > 2.11.0 > -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Pavel Tatashin <pasha.tatashin@oracle.com>, Alexander Duyck <alexander.h.duyck@linux.intel.com>, Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: debug: Fix a width vs precision bug in printk Date: Fri, 23 Nov 2018 10:01:25 +0100 [thread overview] Message-ID: <20181123090125.GC8625@dhcp22.suse.cz> (raw) In-Reply-To: <20181123072135.gqvblm2vdujbvfjs@kili.mountain> On Fri 23-11-18 10:21:35, Dan Carpenter wrote: > We had intended to only print dentry->d_name.len characters but there is > a width vs precision typo so if the name isn't NUL terminated it will > read past the end of the buffer. OK, it took me quite some time to grasp what you mean here. The code works as expected because d_name.len and dname.name are in sync so there no spacing going to happen. Anyway what you propose is formally more correct I guess. > Fixes: 408ddbc22be3 ("mm: print more information about mapping in __dump_page") This sha is an unstable sha for mmotm patch. > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Michal Hocko <mhocko@suse.com> Thanks! > --- > mm/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug.c b/mm/debug.c > index d18c5cea3320..faf856b652b6 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -80,7 +80,7 @@ void __dump_page(struct page *page, const char *reason) > if (mapping->host->i_dentry.first) { > struct dentry *dentry; > dentry = container_of(mapping->host->i_dentry.first, struct dentry, d_u.d_alias); > - pr_warn("name:\"%*s\" ", dentry->d_name.len, dentry->d_name.name); > + pr_warn("name:\"%.*s\" ", dentry->d_name.len, dentry->d_name.name); > } > } > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > -- > 2.11.0 > -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2018-11-23 9:01 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-23 7:21 [PATCH] mm: debug: Fix a width vs precision bug in printk Dan Carpenter 2018-11-23 7:21 ` Dan Carpenter 2018-11-23 7:47 ` Anshuman Khandual 2018-11-23 7:59 ` Anshuman Khandual 2018-11-23 9:01 ` Michal Hocko [this message] 2018-11-23 9:01 ` Michal Hocko 2018-11-23 14:36 ` Dan Carpenter 2018-11-23 14:36 ` Dan Carpenter 2018-11-23 14:48 ` Tetsuo Handa 2018-11-23 14:48 ` Tetsuo Handa 2018-11-24 0:08 ` Andrew Morton 2018-11-24 0:08 ` Andrew Morton 2018-11-25 8:08 ` Michal Hocko 2018-11-25 8:08 ` Michal Hocko 2018-11-23 10:37 ` David Hildenbrand 2018-11-23 10:37 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181123090125.GC8625@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=alexander.h.duyck@linux.intel.com \ --cc=dan.carpenter@oracle.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=pasha.tatashin@oracle.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.