All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful
@ 2018-11-26 10:08 Daniel Vetter
  2018-11-26 12:10 ` Jani Nikula
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-11-26 10:08 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter

Some tests assume that close on an unopened fd is fine, except it's
not just unopened but actually stack garbage. There's a good chance we
end up running close(0), which wreaks the testcase enumeration. Fix
this.

Not sure there's a better way to catch this than git grep plus lots of
manual auditing ... The unit tests only catch it by accident (x86
works fine, I hit it in one testcase only cross-building to aarch64).

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/i915/gem_pread_after_blit.c  | 3 ++-
 tests/i915/gem_tiled_fence_blits.c | 3 ++-
 tests/i915/gem_tiled_swapping.c    | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/i915/gem_pread_after_blit.c b/tests/i915/gem_pread_after_blit.c
index 6ef3ca200776..cee9212749d6 100644
--- a/tests/i915/gem_pread_after_blit.c
+++ b/tests/i915/gem_pread_after_blit.c
@@ -248,5 +248,6 @@ igt_main
 		drm_intel_bufmgr_destroy(bufmgr);
 	}
 
-	close(fd);
+	igt_fixture
+		close(fd);
 }
diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
index c02e35a5fe4c..2453bcc0b271 100644
--- a/tests/i915/gem_tiled_fence_blits.c
+++ b/tests/i915/gem_tiled_fence_blits.c
@@ -230,5 +230,6 @@ igt_main
 		run_test(fd, count);
 	}
 
-	close(fd);
+	igt_fixture
+		close(fd);
 }
diff --git a/tests/i915/gem_tiled_swapping.c b/tests/i915/gem_tiled_swapping.c
index dce668063014..ddf2a748fc84 100644
--- a/tests/i915/gem_tiled_swapping.c
+++ b/tests/i915/gem_tiled_swapping.c
@@ -235,5 +235,6 @@ igt_main
 			thread_fini(&threads[n]);
 	}
 
-	close(fd);
+	igt_fixture
+		close(fd);
 }
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful
  2018-11-26 10:08 [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful Daniel Vetter
@ 2018-11-26 12:10 ` Jani Nikula
  2018-11-26 14:26   ` Daniel Vetter
  2018-11-26 12:55 ` Petri Latvala
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2018-11-26 12:10 UTC (permalink / raw)
  To: Daniel Vetter, IGT development; +Cc: Daniel Vetter

On Mon, 26 Nov 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Some tests assume that close on an unopened fd is fine, except it's
> not just unopened but actually stack garbage. There's a good chance we
> end up running close(0), which wreaks the testcase enumeration. Fix
> this.
>
> Not sure there's a better way to catch this than git grep plus lots of
> manual auditing ... The unit tests only catch it by accident (x86
> works fine, I hit it in one testcase only cross-building to aarch64).
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  tests/i915/gem_pread_after_blit.c  | 3 ++-
>  tests/i915/gem_tiled_fence_blits.c | 3 ++-
>  tests/i915/gem_tiled_swapping.c    | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_pread_after_blit.c b/tests/i915/gem_pread_after_blit.c
> index 6ef3ca200776..cee9212749d6 100644
> --- a/tests/i915/gem_pread_after_blit.c
> +++ b/tests/i915/gem_pread_after_blit.c
> @@ -248,5 +248,6 @@ igt_main
>  		drm_intel_bufmgr_destroy(bufmgr);
>  	}
>  
> -	close(fd);

This one isn't stack garbage, it's guaranteed to be 0 for
!igt_fixture. The other two are garbage on stack.

The change is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

but please update the commit message.

> +	igt_fixture
> +		close(fd);
>  }
> diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> index c02e35a5fe4c..2453bcc0b271 100644
> --- a/tests/i915/gem_tiled_fence_blits.c
> +++ b/tests/i915/gem_tiled_fence_blits.c
> @@ -230,5 +230,6 @@ igt_main
>  		run_test(fd, count);
>  	}
>  
> -	close(fd);
> +	igt_fixture
> +		close(fd);
>  }
> diff --git a/tests/i915/gem_tiled_swapping.c b/tests/i915/gem_tiled_swapping.c
> index dce668063014..ddf2a748fc84 100644
> --- a/tests/i915/gem_tiled_swapping.c
> +++ b/tests/i915/gem_tiled_swapping.c
> @@ -235,5 +235,6 @@ igt_main
>  			thread_fini(&threads[n]);
>  	}
>  
> -	close(fd);
> +	igt_fixture
> +		close(fd);
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful
  2018-11-26 10:08 [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful Daniel Vetter
  2018-11-26 12:10 ` Jani Nikula
@ 2018-11-26 12:55 ` Petri Latvala
  2018-11-26 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-11-26 17:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Petri Latvala @ 2018-11-26 12:55 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: IGT development, Daniel Vetter

On Mon, Nov 26, 2018 at 11:08:24AM +0100, Daniel Vetter wrote:
> Some tests assume that close on an unopened fd is fine, except it's
> not just unopened but actually stack garbage. There's a good chance we
> end up running close(0), which wreaks the testcase enumeration. Fix
> this.
> 
> Not sure there's a better way to catch this than git grep plus lots of
> manual auditing ... The unit tests only catch it by accident (x86
> works fine, I hit it in one testcase only cross-building to aarch64).


Not sure if this is better... At least it's a doublecheck:

# for a in `find -maxdepth 1 -executable -type f`; do valgrind --log-file=${a}.valgrind $a --list-subtests; done

...

# grep 'close(fd)' *.valgrind
gem_tiled_fence_blits.valgrind:==32746== Syscall param close(fd) contains uninitialised byte(s)
gem_tiled_swapping.valgrind:==32441== Syscall param close(fd) contains uninitialised byte(s)



For a bonus missing igt_fixture,
gem_ctx_param.valgrind:==32483== Syscall param ioctl(fd) contains uninitialised byte(s)



-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests: close(fd) without igt_fixture considered harmful
  2018-11-26 10:08 [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful Daniel Vetter
  2018-11-26 12:10 ` Jani Nikula
  2018-11-26 12:55 ` Petri Latvala
@ 2018-11-26 13:41 ` Patchwork
  2018-11-26 17:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-26 13:41 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: tests: close(fd) without igt_fixture considered harmful
URL   : https://patchwork.freedesktop.org/series/53006/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4726 -> IGTPW_2091 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53006/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2091 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@i915_selftest@live_hangcheck:
      {fi-icl-u3}:        PASS -> INCOMPLETE (fdo#108315)

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)

    
    ==== Possible fixes ====

    igt@gem_ctx_create@basic-files:
      {fi-icl-u3}:        DMESG-WARN (fdo#107724) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-WARN (fdo#102614) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@pm_rpm@module-reload:
      fi-skl-iommu:       INCOMPLETE (fdo#107807) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315


== Participating hosts (48 -> 44) ==

  Additional (3): fi-ivb-3520m fi-skl-6260u fi-kbl-r 
  Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4726 -> IGTPW_2091

  CI_DRM_5195: b6df470d38bf4580c00e3f5008d795ec2a901066 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2091: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2091/
  IGT_4726: f48bebb15d3d2c1e6382e1f11b0aeac06fae6082 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2091/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful
  2018-11-26 12:10 ` Jani Nikula
@ 2018-11-26 14:26   ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-11-26 14:26 UTC (permalink / raw)
  To: Jani Nikula; +Cc: IGT development, Daniel Vetter

On Mon, Nov 26, 2018 at 02:10:08PM +0200, Jani Nikula wrote:
> On Mon, 26 Nov 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Some tests assume that close on an unopened fd is fine, except it's
> > not just unopened but actually stack garbage. There's a good chance we
> > end up running close(0), which wreaks the testcase enumeration. Fix
> > this.
> >
> > Not sure there's a better way to catch this than git grep plus lots of
> > manual auditing ... The unit tests only catch it by accident (x86
> > works fine, I hit it in one testcase only cross-building to aarch64).
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  tests/i915/gem_pread_after_blit.c  | 3 ++-
> >  tests/i915/gem_tiled_fence_blits.c | 3 ++-
> >  tests/i915/gem_tiled_swapping.c    | 3 ++-
> >  3 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/i915/gem_pread_after_blit.c b/tests/i915/gem_pread_after_blit.c
> > index 6ef3ca200776..cee9212749d6 100644
> > --- a/tests/i915/gem_pread_after_blit.c
> > +++ b/tests/i915/gem_pread_after_blit.c
> > @@ -248,5 +248,6 @@ igt_main
> >  		drm_intel_bufmgr_destroy(bufmgr);
> >  	}
> >  
> > -	close(fd);
> 
> This one isn't stack garbage, it's guaranteed to be 0 for
> !igt_fixture. The other two are garbage on stack.
> 
> The change is
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> but please update the commit message.

Indeed! Noted in the commit message and pushed, thanks for your review.
-Daniel

> 
> > +	igt_fixture
> > +		close(fd);
> >  }
> > diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> > index c02e35a5fe4c..2453bcc0b271 100644
> > --- a/tests/i915/gem_tiled_fence_blits.c
> > +++ b/tests/i915/gem_tiled_fence_blits.c
> > @@ -230,5 +230,6 @@ igt_main
> >  		run_test(fd, count);
> >  	}
> >  
> > -	close(fd);
> > +	igt_fixture
> > +		close(fd);
> >  }
> > diff --git a/tests/i915/gem_tiled_swapping.c b/tests/i915/gem_tiled_swapping.c
> > index dce668063014..ddf2a748fc84 100644
> > --- a/tests/i915/gem_tiled_swapping.c
> > +++ b/tests/i915/gem_tiled_swapping.c
> > @@ -235,5 +235,6 @@ igt_main
> >  			thread_fini(&threads[n]);
> >  	}
> >  
> > -	close(fd);
> > +	igt_fixture
> > +		close(fd);
> >  }
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests: close(fd) without igt_fixture considered harmful
  2018-11-26 10:08 [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful Daniel Vetter
                   ` (2 preceding siblings ...)
  2018-11-26 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-26 17:30 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-26 17:30 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: tests: close(fd) without igt_fixture considered harmful
URL   : https://patchwork.freedesktop.org/series/53006/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4726_full -> IGTPW_2091_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_2091_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2091_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53006/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2091_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

    igt@tools_test@sysfs_l3_parity:
      shard-hsw:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_2091_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL (fdo#106641)

    igt@kms_busy@extended-pageflip-hang-newfb-render-b:
      shard-apl:          NOTRUN -> DMESG-WARN (fdo#107956) +1

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-kbl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      shard-apl:          NOTRUN -> FAIL (fdo#105458, fdo#106510)

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-glk:          PASS -> FAIL (fdo#103232) +5

    igt@kms_cursor_crc@cursor-256x85-sliding:
      shard-apl:          PASS -> FAIL (fdo#103232) +3

    igt@kms_cursor_crc@cursor-64x21-random:
      shard-kbl:          PASS -> FAIL (fdo#103232) +1

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-apl:          PASS -> FAIL (fdo#103232, fdo#103191)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
      shard-apl:          PASS -> FAIL (fdo#103167) +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
      shard-kbl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-apl:          NOTRUN -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167) +7

    igt@kms_plane@pixel-format-pipe-c-planes:
      shard-apl:          PASS -> FAIL (fdo#103166) +5

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          PASS -> FAIL (fdo#103166) +6

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          PASS -> FAIL (fdo#108145) +1
      shard-kbl:          PASS -> FAIL (fdo#108145)
      shard-apl:          PASS -> FAIL (fdo#108145)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-kbl:          PASS -> FAIL (fdo#103166)

    igt@kms_setmode@basic:
      shard-hsw:          PASS -> FAIL (fdo#99912)

    igt@kms_universal_plane@universal-plane-pipe-a-functional:
      shard-kbl:          NOTRUN -> FAIL (fdo#103166)

    igt@perf@polling:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023, fdo#106887) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-glk:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_color@pipe-a-ctm-0-5:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_cursor_crc@cursor-128x128-sliding:
      shard-hsw:          DMESG-FAIL (fdo#102614, fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-apl:          FAIL (fdo#103232, fdo#103191) -> PASS

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled:
      shard-glk:          FAIL (fdo#107791) -> PASS

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-hsw:          DMESG-FAIL (fdo#102614, fdo#103060) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-kbl:          FAIL (fdo#105363, fdo#102887) -> PASS
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-kbl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
      shard-apl:          FAIL (fdo#103167) -> PASS +1
      shard-glk:          FAIL (fdo#103167) -> PASS +3

    igt@kms_plane@plane-position-hole-dpms-pipe-c-planes:
      shard-hsw:          FAIL (fdo#107814) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105458 https://bugs.freedesktop.org/show_bug.cgi?id=105458
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106510 https://bugs.freedesktop.org/show_bug.cgi?id=106510
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
  fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
  fdo#107814 https://bugs.freedesktop.org/show_bug.cgi?id=107814
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (7 -> 5) ==

  Missing    (2): shard-skl shard-iclb 


== Build changes ==

    * IGT: IGT_4726 -> IGTPW_2091

  CI_DRM_5195: b6df470d38bf4580c00e3f5008d795ec2a901066 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2091: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2091/
  IGT_4726: f48bebb15d3d2c1e6382e1f11b0aeac06fae6082 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2091/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-26 17:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 10:08 [igt-dev] [PATCH i-g-t] tests: close(fd) without igt_fixture considered harmful Daniel Vetter
2018-11-26 12:10 ` Jani Nikula
2018-11-26 14:26   ` Daniel Vetter
2018-11-26 12:55 ` Petri Latvala
2018-11-26 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-11-26 17:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.