* [PATCH] x86emul: fix test harness 32-bit "clean" target handling
@ 2018-11-26 14:13 Jan Beulich
2018-11-26 14:16 ` Andrew Cooper
2018-11-26 14:24 ` Wei Liu
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2018-11-26 14:13 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Paul Durrant, Wei Liu, Roger Pau Monne
When preparing what is now 52c37f7ab9 ("x86emul: also allow running the
32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH
instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also
switch around the use in the expression controlling the rule
dependencies, causing "make distclean" to fail on 64-bit distros.
Reported-by: Paul Durrant <Paul.Durrant@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Paul Durrant <Paul.Durrant@citrix.com>
--- a/tools/tests/x86_emulator/Makefile
+++ b/tools/tests/x86_emulator/Makefile
@@ -185,7 +185,7 @@ distclean: clean
install uninstall:
.PHONY: run32 clean32
-ifeq ($(XEN_TARGET_ARCH),x86_64)
+ifeq ($(XEN_COMPILE_ARCH),x86_64)
run32: $(addsuffix .h,$(TESTCASES)) $(addsuffix -opmask.h,$(OPMASK))
run32 clean32: %32:
$(MAKE) -C 32 $*
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86emul: fix test harness 32-bit "clean" target handling
2018-11-26 14:13 [PATCH] x86emul: fix test harness 32-bit "clean" target handling Jan Beulich
@ 2018-11-26 14:16 ` Andrew Cooper
2018-11-26 14:24 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2018-11-26 14:16 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Paul Durrant, Wei Liu, Roger Pau Monne
On 26/11/2018 14:13, Jan Beulich wrote:
> When preparing what is now 52c37f7ab9 ("x86emul: also allow running the
> 32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH
> instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also
> switch around the use in the expression controlling the rule
> dependencies, causing "make distclean" to fail on 64-bit distros.
>
> Reported-by: Paul Durrant <Paul.Durrant@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Paul Durrant <Paul.Durrant@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86emul: fix test harness 32-bit "clean" target handling
2018-11-26 14:13 [PATCH] x86emul: fix test harness 32-bit "clean" target handling Jan Beulich
2018-11-26 14:16 ` Andrew Cooper
@ 2018-11-26 14:24 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2018-11-26 14:24 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel, Paul Durrant, Wei Liu, Roger Pau Monne, Andrew Cooper
On Mon, Nov 26, 2018 at 07:13:33AM -0700, Jan Beulich wrote:
> When preparing what is now 52c37f7ab9 ("x86emul: also allow running the
> 32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH
> instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also
> switch around the use in the expression controlling the rule
> dependencies, causing "make distclean" to fail on 64-bit distros.
>
> Reported-by: Paul Durrant <Paul.Durrant@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Paul Durrant <Paul.Durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-26 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 14:13 [PATCH] x86emul: fix test harness 32-bit "clean" target handling Jan Beulich
2018-11-26 14:16 ` Andrew Cooper
2018-11-26 14:24 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.