From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: [PATCHSET 0/8] block plugging improvements
Date: Mon, 26 Nov 2018 09:35:48 -0700 [thread overview]
Message-ID: <20181126163556.5181-1-axboe@kernel.dk> (raw)
Series improving plugging for fast devices, but some fixes in here too.
1-2 are improvements around plugging accounting. Changes the behavior
a bit, but works fine for me.
3-6 add a ->commit_rqs() hook and implement it in drivers that use (or
will use) bd->last to optimize IO submission. If a driver currently uses
bd->last to know if it's needed to kick the hardware into action, there
are cases where we flag bd->last == false, but then fail to submit any
further IO due to other resource constraints. We probably get saved by
the fact that this happens for the case where we have pending IO and
that will eventually guarantee forward progress, but we really should
kick IO into gear at that point.
7-8 improve plugging for blk-mq.
In terms of improvements, for virtualized nvme, I've seen a 2-x IOPS
improvement with proper handling of bd->last with this series.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCHSET 0/8] block plugging improvements
Date: Mon, 26 Nov 2018 09:35:48 -0700 [thread overview]
Message-ID: <20181126163556.5181-1-axboe@kernel.dk> (raw)
Series improving plugging for fast devices, but some fixes in here too.
1-2 are improvements around plugging accounting. Changes the behavior
a bit, but works fine for me.
3-6 add a ->commit_rqs() hook and implement it in drivers that use (or
will use) bd->last to optimize IO submission. If a driver currently uses
bd->last to know if it's needed to kick the hardware into action, there
are cases where we flag bd->last == false, but then fail to submit any
further IO due to other resource constraints. We probably get saved by
the fact that this happens for the case where we have pending IO and
that will eventually guarantee forward progress, but we really should
kick IO into gear at that point.
7-8 improve plugging for blk-mq.
In terms of improvements, for virtualized nvme, I've seen a 2-x IOPS
improvement with proper handling of bd->last with this series.
--
Jens Axboe
next reply other threads:[~2018-11-26 16:36 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:35 Jens Axboe [this message]
2018-11-26 16:35 ` [PATCHSET 0/8] block plugging improvements Jens Axboe
2018-11-26 16:35 ` [PATCH 1/8] block: sum requests in the plug structure Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-26 17:02 ` Christoph Hellwig
2018-11-26 17:02 ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 2/8] block: improve logic around when to sort a plug list Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-27 23:31 ` Omar Sandoval
2018-11-27 23:31 ` Omar Sandoval
2018-11-27 23:49 ` Jens Axboe
2018-11-27 23:49 ` Jens Axboe
2018-11-27 23:55 ` Omar Sandoval
2018-11-27 23:55 ` Omar Sandoval
2018-11-27 23:59 ` Jens Axboe
2018-11-27 23:59 ` Jens Axboe
2018-11-28 0:05 ` Omar Sandoval
2018-11-28 0:05 ` Omar Sandoval
2018-11-28 0:16 ` Jens Axboe
2018-11-28 0:16 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 3/8] blk-mq: add mq_ops->commit_rqs() Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-27 23:43 ` Omar Sandoval
2018-11-27 23:43 ` Omar Sandoval
2018-11-28 1:38 ` Ming Lei
2018-11-28 1:38 ` Ming Lei
2018-11-28 7:16 ` Christoph Hellwig
2018-11-28 7:16 ` Christoph Hellwig
2018-11-28 12:54 ` Jens Axboe
2018-11-28 12:54 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 4/8] nvme: implement mq_ops->commit_rqs() hook Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-28 7:20 ` Christoph Hellwig
2018-11-28 7:20 ` Christoph Hellwig
2018-11-28 13:07 ` Jens Axboe
2018-11-28 13:07 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 5/8] virtio_blk: " Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-27 23:45 ` Omar Sandoval
2018-11-27 23:45 ` Omar Sandoval
2018-11-28 3:05 ` Michael S. Tsirkin
2018-11-28 3:05 ` Michael S. Tsirkin
2018-11-28 2:10 ` Ming Lei
2018-11-28 2:10 ` Ming Lei
2018-11-28 2:34 ` Jens Axboe
2018-11-28 2:34 ` Jens Axboe
2018-11-29 1:23 ` Ming Lei
2018-11-29 1:23 ` Ming Lei
2018-11-29 2:19 ` Jens Axboe
2018-11-29 2:19 ` Jens Axboe
2018-11-29 2:51 ` Ming Lei
2018-11-29 2:51 ` Ming Lei
2018-11-29 3:13 ` Jens Axboe
2018-11-29 3:13 ` Jens Axboe
2018-11-29 3:27 ` Ming Lei
2018-11-29 3:27 ` Ming Lei
2018-11-29 3:53 ` Jens Axboe
2018-11-29 3:53 ` Jens Axboe
2018-11-28 7:21 ` Christoph Hellwig
2018-11-28 7:21 ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 6/8] ataflop: " Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-27 23:46 ` Omar Sandoval
2018-11-27 23:46 ` Omar Sandoval
2018-11-28 7:22 ` Christoph Hellwig
2018-11-28 7:22 ` Christoph Hellwig
2018-11-28 13:09 ` Jens Axboe
2018-11-28 13:09 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 7/8] blk-mq: use bd->last == true for list inserts Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-27 23:49 ` Omar Sandoval
2018-11-27 23:49 ` Omar Sandoval
2018-11-27 23:51 ` Jens Axboe
2018-11-27 23:51 ` Jens Axboe
2018-11-28 1:49 ` Ming Lei
2018-11-28 1:49 ` Ming Lei
2018-11-28 2:37 ` Jens Axboe
2018-11-28 2:37 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 8/8] blk-mq: add plug case for devices that implement ->commits_rqs() Jens Axboe
2018-11-26 16:35 ` Jens Axboe
2018-11-28 7:26 ` Christoph Hellwig
2018-11-28 7:26 ` Christoph Hellwig
2018-11-28 13:11 ` Jens Axboe
2018-11-28 13:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126163556.5181-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.