Re: [PATCH] mv88e6060 station roaming

Re: [PATCH] mv88e6060 station roaming

[Andrew Lunn]

On Mon, Nov 26, 2018 at 09:31:02PM -0200, Alacn wrote:
> hello,
> 
> I'm sending a patch for Marvell 88e6060 driver.
> 
> Problem description:
> Multiple APs with inter-AP roaming connected to different ports,
> when station moves from one AP on one port to another AP on another port,
> traffic flow breaks down because the learning table is not updated.
> 
> 
> When Marvell's mac learning is enabled it drops all frames that
> arrive from a MAC address that is on a different port at learning table.
> It doesn't update learning table and breaks station roaming.
> 
> 
> This patch disable Marvell 88E6060 hardware level mac learning and let it
> be handled by the kernel.

Hi Anderson.

> @@ -145,8 +144,7 @@

        /* Enable automatic address learning, set the address
         * database size to 1024 entries, and set the default aging
         * time to 5 minutes.
         */


>   * time to 5 minutes.
>   */
>   REG_WRITE(REG_GLOBAL, GLOBAL_ATU_CONTROL,
> -   GLOBAL_ATU_CONTROL_ATUSIZE_1024 |
> -   GLOBAL_ATU_CONTROL_ATE_AGE_5MIN);
> +   GLOBAL_ATU_CONTROL_LEARNDIS);

Please update the comment as well.

       Thanks
	Andrew

Re: [PATCH] mv88e6060 station roaming

[Andrew Lunn]

On Mon, Nov 26, 2018 at 09:31:02PM -0200, Alacn wrote:
> hello,
> 
> I'm sending a patch for Marvell 88e6060 driver.
> 
> Problem description:
> Multiple APs with inter-AP roaming connected to different ports,
> when station moves from one AP on one port to another AP on another port,
> traffic flow breaks down because the learning table is not updated.
> 
> 
> When Marvell's mac learning is enabled it drops all frames that
> arrive from a MAC address that is on a different port at learning table.
> It doesn't update learning table and breaks station roaming.
> 
> 
> This patch disable Marvell 88E6060 hardware level mac learning and let it
> be handled by the kernel.

Hi Anderson.

Please take a look at
https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html

In particular the text about Signed-off-by:.

Also, the complete contents above going into the commit message, so
please make the text formal. No hello, etc.

   Andrew