* [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally
@ 2018-11-27 10:16 Baruch Siach
2018-11-27 10:35 ` Thomas Petazzoni
2018-11-28 20:54 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2018-11-27 10:16 UTC (permalink / raw)
To: buildroot
strace-graph is a perl script. This script is removed unconditionally
since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in
format") from 2008. Since then Buildroot added support for perl on
target. Don't remove strace-graph when perl is built for target.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/strace/strace.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/strace/strace.mk b/package/strace/strace.mk
index 471dbc2e1dd3..10869453d146 100644
--- a/package/strace/strace.mk
+++ b/package/strace/strace.mk
@@ -38,6 +38,8 @@ define STRACE_REMOVE_STRACE_GRAPH
rm -f $(TARGET_DIR)/usr/bin/strace-graph
endef
+ifeq ($(BR2_PACKAGE_PERL),)
STRACE_POST_INSTALL_TARGET_HOOKS += STRACE_REMOVE_STRACE_GRAPH
+endif
$(eval $(autotools-package))
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally
2018-11-27 10:16 [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally Baruch Siach
@ 2018-11-27 10:35 ` Thomas Petazzoni
2018-11-28 20:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-27 10:35 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 27 Nov 2018 12:16:56 +0200, Baruch Siach wrote:
> strace-graph is a perl script. This script is removed unconditionally
> since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in
> format") from 2008. Since then Buildroot added support for perl on
> target. Don't remove strace-graph when perl is built for target.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Would be nice to enclose the STRACE_REMOVE_STRACE_GRAPH function into
the condition. No need to resend just for that, it can be fixed when
applying.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally
2018-11-27 10:16 [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally Baruch Siach
2018-11-27 10:35 ` Thomas Petazzoni
@ 2018-11-28 20:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-28 20:54 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 27 Nov 2018 12:16:56 +0200, Baruch Siach wrote:
> strace-graph is a perl script. This script is removed unconditionally
> since commit 720c0ca5ba7 ("strace: convert to makefile.autotools.in
> format") from 2008. Since then Buildroot added support for perl on
> target. Don't remove strace-graph when perl is built for target.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/strace/strace.mk | 2 ++
> 1 file changed, 2 insertions(+)
Applied to next after moving the hook definition inside the condition.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-28 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 10:16 [Buildroot] [PATCH] strace: don't remove strace-graph unconditionally Baruch Siach
2018-11-27 10:35 ` Thomas Petazzoni
2018-11-28 20:54 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.