* [igt-dev] [PATCH i-g-t] runner: Flip kill args
@ 2018-11-27 12:22 Chris Wilson
2018-11-27 12:42 ` Petri Latvala
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2018-11-27 12:22 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
int kill(pid_t pid, int sig)!
Fixes: a6b514d242bd ("runner: Be patient for processes to die")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
runner/executor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/runner/executor.c b/runner/executor.c
index 62901d86a..f75efbbc4 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -545,7 +545,7 @@ static int monitor_output(pid_t child,
* forward progress towards exiting (i.e. still
* freeing all of its resources).
*/
- if (kill(0, child) == 0 && !tainted(&taints)) {
+ if (kill(child, 0) == 0 && !tainted(&taints)) {
intervals_left = 1;
break;
}
--
2.20.0.rc1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] runner: Flip kill args
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
@ 2018-11-27 12:42 ` Petri Latvala
2018-11-27 12:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Petri Latvala @ 2018-11-27 12:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Tue, Nov 27, 2018 at 12:22:55PM +0000, Chris Wilson wrote:
> int kill(pid_t pid, int sig)!
>
> Fixes: a6b514d242bd ("runner: Be patient for processes to die")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> runner/executor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index 62901d86a..f75efbbc4 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -545,7 +545,7 @@ static int monitor_output(pid_t child,
> * forward progress towards exiting (i.e. still
> * freeing all of its resources).
> */
> - if (kill(0, child) == 0 && !tainted(&taints)) {
> + if (kill(child, 0) == 0 && !tainted(&taints)) {
> intervals_left = 1;
> break;
> }
> --
> 2.20.0.rc1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for runner: Flip kill args
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
2018-11-27 12:42 ` Petri Latvala
@ 2018-11-27 12:52 ` Patchwork
2018-11-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-27 15:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-11-27 12:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: runner: Flip kill args
URL : https://patchwork.freedesktop.org/series/53077/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4730 -> IGTPW_2100 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_2100 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2100, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53077/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2100:
=== IGT changes ===
==== Possible regressions ====
igt@gem_exec_suspend@basic-s4-devices:
fi-ivb-3520m: PASS -> FAIL
== Known issues ==
Here are the changes found in IGTPW_2100 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: NOTRUN -> INCOMPLETE (fdo#107187, fdo#108126)
igt@kms_frontbuffer_tracking@basic:
{fi-icl-u3}: PASS -> FAIL (fdo#103167)
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362) +1
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@i915_selftest@live_contexts:
fi-bsw-kefka: DMESG-FAIL (fdo#108656, fdo#108626) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
fdo#108626 https://bugs.freedesktop.org/show_bug.cgi?id=108626
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (50 -> 46) ==
Additional (2): fi-cfl-8109u fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4730 -> IGTPW_2100
CI_DRM_5208: e556a1602bef92792a069e4fe1cb2c851efb2294 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2100: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/
IGT_4730: a6b514d242bddd9457f04bb25cde0ddf85032b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for runner: Flip kill args
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
2018-11-27 12:42 ` Petri Latvala
2018-11-27 12:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-11-27 14:05 ` Patchwork
2018-11-27 15:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-11-27 14:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: runner: Flip kill args
URL : https://patchwork.freedesktop.org/series/53077/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4730 -> IGTPW_2100 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53077/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_2100 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: NOTRUN -> INCOMPLETE (fdo#107187, fdo#108126)
igt@gem_exec_suspend@basic-s4-devices:
fi-ivb-3520m: PASS -> FAIL (fdo#108880)
igt@kms_frontbuffer_tracking@basic:
{fi-icl-u3}: PASS -> FAIL (fdo#103167)
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362) +1
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@i915_selftest@live_contexts:
fi-bsw-kefka: DMESG-FAIL (fdo#108656, fdo#108626) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
fdo#108626 https://bugs.freedesktop.org/show_bug.cgi?id=108626
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
fdo#108880 https://bugs.freedesktop.org/show_bug.cgi?id=108880
== Participating hosts (50 -> 46) ==
Additional (2): fi-cfl-8109u fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4730 -> IGTPW_2100
CI_DRM_5208: e556a1602bef92792a069e4fe1cb2c851efb2294 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2100: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/
IGT_4730: a6b514d242bddd9457f04bb25cde0ddf85032b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for runner: Flip kill args
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
` (2 preceding siblings ...)
2018-11-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-27 15:55 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-11-27 15:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: runner: Flip kill args
URL : https://patchwork.freedesktop.org/series/53077/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4730_full -> IGTPW_2100_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_2100_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2100_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53077/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_2100_full:
=== IGT changes ===
==== Warnings ====
igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
shard-snb: SKIP -> PASS +3
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: SKIP -> PASS
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_2100_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@i915_suspend@shrink:
shard-snb: NOTRUN -> DMESG-WARN (fdo#108784)
shard-hsw: NOTRUN -> DMESG-WARN (fdo#108784)
igt@kms_busy@basic-flip-c:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-snb: SKIP -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
shard-kbl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: PASS -> FAIL (fdo#103191, fdo#103232) +1
igt@kms_cursor_crc@cursor-256x256-dpms:
shard-glk: PASS -> FAIL (fdo#103232) +5
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-glk: NOTRUN -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-kbl: PASS -> FAIL (fdo#103191, fdo#103232)
igt@kms_cursor_legacy@pipe-c-torture-bo:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
shard-glk: PASS -> FAIL (fdo#103167) +3
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-kbl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-glk: PASS -> FAIL (fdo#105682, fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: NOTRUN -> FAIL (fdo#103167)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: PASS -> FAIL (fdo#103166) +2
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: PASS -> FAIL (fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
shard-glk: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +5
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-kbl: PASS -> FAIL (fdo#103166) +3
igt@kms_properties@connector-properties-atomic:
shard-hsw: NOTRUN -> FAIL (fdo#108642)
==== Possible fixes ====
igt@gem_ctx_isolation@bcs0-s3:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@gem_exec_flush@basic-uc-pro-default:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-kbl: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-kbl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-snb: DMESG-WARN (fdo#107956) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_color@pipe-b-gamma:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-glk: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-apl: FAIL (fdo#103191, fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-kbl: FAIL (fdo#103232) -> PASS +4
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: FAIL (fdo#103232) -> PASS +6
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
shard-hsw: FAIL (fdo#105767) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-kbl: FAIL (fdo#103167) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-glk: FAIL (fdo#103167) -> PASS +2
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-glk: FAIL (fdo#108145) -> PASS +1
shard-apl: FAIL (fdo#108145) -> PASS
shard-kbl: FAIL (fdo#108145) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: FAIL (fdo#103166) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108642 https://bugs.freedesktop.org/show_bug.cgi?id=108642
fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (7 -> 5) ==
Missing (2): shard-skl shard-iclb
== Build changes ==
* IGT: IGT_4730 -> IGTPW_2100
CI_DRM_5208: e556a1602bef92792a069e4fe1cb2c851efb2294 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2100: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/
IGT_4730: a6b514d242bddd9457f04bb25cde0ddf85032b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2100/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-27 15:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 12:22 [igt-dev] [PATCH i-g-t] runner: Flip kill args Chris Wilson
2018-11-27 12:42 ` Petri Latvala
2018-11-27 12:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-11-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-27 15:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.