* EDAC, skx: clean up a debug printk
@ 2018-11-27 11:32 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 11:32 UTC (permalink / raw)
To: Tony Luck, Qiuxu Zhuo
Cc: Borislav Petkov, Mauro Carvalho Chehab, linux-edac, kernel-janitors
I've removed the 0x prefix for the row and col because the %#x format
already adds a 0x.
Fixes: e235dd43d8b0 ("EDAC, skx: Prepend hex formatting with '0x'")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/edac/skx_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c
index 93ef161bb5e1..354d2a4b2c64 100644
--- a/drivers/edac/skx_edac.c
+++ b/drivers/edac/skx_edac.c
@@ -389,7 +389,7 @@ static int get_dimm_info(u32 mtr, u32 amap, struct dimm_info *dimm,
size = ((1ull << (rows + cols + ranks)) * banks) >> (20 - 3);
npages = MiB_TO_PAGES(size);
- edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: 0x%#x, col: 0x%#x\n",
+ edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: %#x, col: %#x\n",
imc->mc, chan, dimmno, size, npages,
banks, 1 << ranks, rows, cols);
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 11:32 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 11:32 UTC (permalink / raw)
To: Tony Luck, Qiuxu Zhuo
Cc: Borislav Petkov, Mauro Carvalho Chehab, linux-edac, kernel-janitors
I've removed the 0x prefix for the row and col because the %#x format
already adds a 0x.
Fixes: e235dd43d8b0 ("EDAC, skx: Prepend hex formatting with '0x'")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/edac/skx_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c
index 93ef161bb5e1..354d2a4b2c64 100644
--- a/drivers/edac/skx_edac.c
+++ b/drivers/edac/skx_edac.c
@@ -389,7 +389,7 @@ static int get_dimm_info(u32 mtr, u32 amap, struct dimm_info *dimm,
size = ((1ull << (rows + cols + ranks)) * banks) >> (20 - 3);
npages = MiB_TO_PAGES(size);
- edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: 0x%#x, col: 0x%#x\n",
+ edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: %#x, col: %#x\n",
imc->mc, chan, dimmno, size, npages,
banks, 1 << ranks, rows, cols);
--
2.11.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 12:49 ` Borislav Petkov
-1 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 12:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote:
> I've removed the 0x prefix for the row and col because the %#x format
> already adds a 0x.
Pls use passive tone in your commit message: no "we" or "I", etc.
Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 12:49 ` Borislav Petkov
0 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 12:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote:
> I've removed the 0x prefix for the row and col because the %#x format
> already adds a 0x.
Pls use passive tone in your commit message: no "we" or "I", etc.
Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 13:24 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:24 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 01:49:15PM +0100, Borislav Petkov wrote:
> On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote:
> > I've removed the 0x prefix for the row and col because the %#x format
> > already adds a 0x.
>
> Pls use passive tone in your commit message: no "we" or "I", etc.
>
> Also, pls read section "2) Describe your changes" in
> Documentation/process/submitting-patches.rst.
>
I don't agree with all the style nit-picking these days. I think a
competent programmer can understand the commit message so it's fine.
I'm not going to resend, sorry.
Just give me the Reported-by tag and re-write it how you want.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 13:24 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:24 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 01:49:15PM +0100, Borislav Petkov wrote:
> On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote:
> > I've removed the 0x prefix for the row and col because the %#x format
> > already adds a 0x.
>
> Pls use passive tone in your commit message: no "we" or "I", etc.
>
> Also, pls read section "2) Describe your changes" in
> Documentation/process/submitting-patches.rst.
>
I don't agree with all the style nit-picking these days. I think a
competent programmer can understand the commit message so it's fine.
I'm not going to resend, sorry.
Just give me the Reported-by tag and re-write it how you want.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 13:27 ` Borislav Petkov
-1 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 13:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> I don't agree with all the style nit-picking these days. I think a
> competent programmer can understand the commit message so it's fine.
> I'm not going to resend, sorry.
That is your choice, of course.
> Just give me the Reported-by tag and re-write it how you want.
Well, it is my choice to not do the work for you so if anyone else
rewrites it, I'll pick it up.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 13:27 ` Borislav Petkov
0 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 13:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> I don't agree with all the style nit-picking these days. I think a
> competent programmer can understand the commit message so it's fine.
> I'm not going to resend, sorry.
That is your choice, of course.
> Just give me the Reported-by tag and re-write it how you want.
Well, it is my choice to not do the work for you so if anyone else
rewrites it, I'll pick it up.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 13:31 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:31 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote:
> On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> > I don't agree with all the style nit-picking these days. I think a
> > competent programmer can understand the commit message so it's fine.
> > I'm not going to resend, sorry.
>
> That is your choice, of course.
>
> > Just give me the Reported-by tag and re-write it how you want.
>
> Well, it is my choice to not do the work for you so if anyone else
> rewrites it, I'll pick it up.
>
Qiuxu, can you take care of this?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 13:31 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:31 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote:
> On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> > I don't agree with all the style nit-picking these days. I think a
> > competent programmer can understand the commit message so it's fine.
> > I'm not going to resend, sorry.
>
> That is your choice, of course.
>
> > Just give me the Reported-by tag and re-write it how you want.
>
> Well, it is my choice to not do the work for you so if anyone else
> rewrites it, I'll pick it up.
>
Qiuxu, can you take care of this?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 13:53 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:53 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:31:52PM +0300, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote:
> > On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> > > I don't agree with all the style nit-picking these days. I think a
> > > competent programmer can understand the commit message so it's fine.
> > > I'm not going to resend, sorry.
> >
> > That is your choice, of course.
> >
> > > Just give me the Reported-by tag and re-write it how you want.
> >
> > Well, it is my choice to not do the work for you so if anyone else
> > rewrites it, I'll pick it up.
> >
>
> Qiuxu, can you take care of this?
>
Qiuxu, it's not fair for me to involve you in this stupid spat with
Boris. I appologize. I will resend tomorrow.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 13:53 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2018-11-27 13:53 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:31:52PM +0300, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote:
> > On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote:
> > > I don't agree with all the style nit-picking these days. I think a
> > > competent programmer can understand the commit message so it's fine.
> > > I'm not going to resend, sorry.
> >
> > That is your choice, of course.
> >
> > > Just give me the Reported-by tag and re-write it how you want.
> >
> > Well, it is my choice to not do the work for you so if anyone else
> > rewrites it, I'll pick it up.
> >
>
> Qiuxu, can you take care of this?
>
Qiuxu, it's not fair for me to involve you in this stupid spat with
Boris. I appologize. I will resend tomorrow.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* EDAC, skx: clean up a debug printk
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
@ 2018-11-27 14:01 ` Borislav Petkov
-1 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 14:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:53:35PM +0300, Dan Carpenter wrote:
> Qiuxu, it's not fair for me to involve you in this stupid spat with
> Boris.
That's not a spat - it is simply a difference of opinions.
And I accept your opinion - I just don't agree with it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] EDAC, skx: clean up a debug printk
@ 2018-11-27 14:01 ` Borislav Petkov
0 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2018-11-27 14:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, linux-edac,
kernel-janitors
On Tue, Nov 27, 2018 at 04:53:35PM +0300, Dan Carpenter wrote:
> Qiuxu, it's not fair for me to involve you in this stupid spat with
> Boris.
That's not a spat - it is simply a difference of opinions.
And I accept your opinion - I just don't agree with it.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-11-27 14:01 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 13:31 EDAC, skx: clean up a debug printk Dan Carpenter
2018-11-27 13:31 ` [PATCH] " Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2018-11-27 14:01 Borislav Petkov
2018-11-27 14:01 ` [PATCH] " Borislav Petkov
2018-11-27 13:53 Dan Carpenter
2018-11-27 13:53 ` [PATCH] " Dan Carpenter
2018-11-27 13:27 Borislav Petkov
2018-11-27 13:27 ` [PATCH] " Borislav Petkov
2018-11-27 13:24 Dan Carpenter
2018-11-27 13:24 ` [PATCH] " Dan Carpenter
2018-11-27 12:49 Borislav Petkov
2018-11-27 12:49 ` [PATCH] " Borislav Petkov
2018-11-27 11:32 Dan Carpenter
2018-11-27 11:32 ` [PATCH] " Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.