* [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
@ 2018-11-27 14:02 ` Ramalingam C
2018-11-27 15:15 ` Ville Syrjälä
` (2 more replies)
2018-11-27 14:02 ` [PATCH 2/4] drm/i915: Fix platform coverage for HDCP1.4 Ramalingam C
` (7 subsequent siblings)
8 siblings, 3 replies; 17+ messages in thread
From: Ramalingam C @ 2018-11-27 14:02 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
HDCP1.4 key load process varies between Intel platform to platform.
For Gen9 platforms except BXT and GLK, HDCP1.4 key is loaded using
the GT Driver Mailbox interface. Instead of listing all the platforms
for this method, adopted this method for all Gen9 platforms with
exceptions. In this way we need not extent check for new GEN9 platforms
like CFL.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index 1bf487f94254..beacfbb6e5e1 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -157,10 +157,12 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
/*
* Initiate loading the HDCP key from fuses.
*
- * BXT+ platforms, HDCP key needs to be loaded by SW. Only SKL and KBL
- * differ in the key load trigger process from other platforms.
+ * BXT+ platforms, HDCP key needs to be loaded by SW. Only Gen 9
+ * platforms except BXT and GLK, differ in the key load trigger process
+ * from other platforms.
*/
- if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
+ if (IS_GEN9(dev_priv) &&
+ (!IS_BROXTON(dev_priv) && !IS_GEMINILAKE(dev_priv))) {
mutex_lock(&dev_priv->pcu_lock);
ret = sandybridge_pcode_write(dev_priv,
SKL_PCODE_LOAD_HDCP_KEYS, 1);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process
2018-11-27 14:02 ` [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
@ 2018-11-27 15:15 ` Ville Syrjälä
2018-11-27 16:27 ` [Intel-gfx] " C, Ramalingam
2018-11-28 14:00 ` [PATCH v2 " Ramalingam C
2018-12-03 14:23 ` [PATCH " Sean Paul
2 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2018-11-27 15:15 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
On Tue, Nov 27, 2018 at 07:32:56PM +0530, Ramalingam C wrote:
> HDCP1.4 key load process varies between Intel platform to platform.
>
> For Gen9 platforms except BXT and GLK, HDCP1.4 key is loaded using
> the GT Driver Mailbox interface. Instead of listing all the platforms
> for this method, adopted this method for all Gen9 platforms with
> exceptions. In this way we need not extent check for new GEN9 platforms
> like CFL.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 1bf487f94254..beacfbb6e5e1 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -157,10 +157,12 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
> /*
> * Initiate loading the HDCP key from fuses.
> *
> - * BXT+ platforms, HDCP key needs to be loaded by SW. Only SKL and KBL
> - * differ in the key load trigger process from other platforms.
> + * BXT+ platforms, HDCP key needs to be loaded by SW. Only Gen 9
> + * platforms except BXT and GLK, differ in the key load trigger process
> + * from other platforms.
> */
> - if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
> + if (IS_GEN9(dev_priv) &&
> + (!IS_BROXTON(dev_priv) && !IS_GEMINILAKE(dev_priv))) {
IS_GEN9_BC()
> mutex_lock(&dev_priv->pcu_lock);
> ret = sandybridge_pcode_write(dev_priv,
> SKL_PCODE_LOAD_HDCP_KEYS, 1);
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [Intel-gfx] [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process
2018-11-27 15:15 ` Ville Syrjälä
@ 2018-11-27 16:27 ` C, Ramalingam
0 siblings, 0 replies; 17+ messages in thread
From: C, Ramalingam @ 2018-11-27 16:27 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2190 bytes --]
On 11/27/2018 8:45 PM, Ville Syrjälä wrote:
> On Tue, Nov 27, 2018 at 07:32:56PM +0530, Ramalingam C wrote:
>> HDCP1.4 key load process varies between Intel platform to platform.
>>
>> For Gen9 platforms except BXT and GLK, HDCP1.4 key is loaded using
>> the GT Driver Mailbox interface. Instead of listing all the platforms
>> for this method, adopted this method for all Gen9 platforms with
>> exceptions. In this way we need not extent check for new GEN9 platforms
>> like CFL.
>>
>> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_hdcp.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
>> index 1bf487f94254..beacfbb6e5e1 100644
>> --- a/drivers/gpu/drm/i915/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
>> @@ -157,10 +157,12 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
>> /*
>> * Initiate loading the HDCP key from fuses.
>> *
>> - * BXT+ platforms, HDCP key needs to be loaded by SW. Only SKL and KBL
>> - * differ in the key load trigger process from other platforms.
>> + * BXT+ platforms, HDCP key needs to be loaded by SW. Only Gen 9
>> + * platforms except BXT and GLK, differ in the key load trigger process
>> + * from other platforms.
>> */
>> - if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
>> + if (IS_GEN9(dev_priv) &&
>> + (!IS_BROXTON(dev_priv) && !IS_GEMINILAKE(dev_priv))) {
> IS_GEN9_BC()
Bspec doesn't state anything about BC/LP. They have mentioned GEN9+ with BXT, CNL, ICL excluded.
So I am inferring that this method is only for Gen9 excluding BXT and GLK (verified).
Remaining platforms are SKL, KBL, and CFL.
IS_GEN9_BC() will filter them easily. unless we find otherwise, we can use this. Thanks Ville.
--Ram
>
>> mutex_lock(&dev_priv->pcu_lock);
>> ret = sandybridge_pcode_write(dev_priv,
>> SKL_PCODE_LOAD_HDCP_KEYS, 1);
>> --
>> 2.7.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: Type: text/html, Size: 3172 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process
2018-11-27 14:02 ` [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
2018-11-27 15:15 ` Ville Syrjälä
@ 2018-11-28 14:00 ` Ramalingam C
2018-12-03 14:23 ` [PATCH " Sean Paul
2 siblings, 0 replies; 17+ messages in thread
From: Ramalingam C @ 2018-11-28 14:00 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
HDCP1.4 key load process varies between Intel platform to platform.
For Gen9 platforms except BXT and GLK, HDCP1.4 key is loaded using
the GT Driver Mailbox interface. So all GEN9_BC platforms will use
the GT Driver Mailbox interface for HDCP1.4 key load.
v2:
Using the IS_GEN9_BC for filtering the platforms [Ville]
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index 1bf487f94254..c16bffcce3b0 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -157,10 +157,11 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
/*
* Initiate loading the HDCP key from fuses.
*
- * BXT+ platforms, HDCP key needs to be loaded by SW. Only SKL and KBL
- * differ in the key load trigger process from other platforms.
+ * BXT+ platforms, HDCP key needs to be loaded by SW. Only Gen 9
+ * platforms except BXT and GLK, differ in the key load trigger process
+ * from other platforms. So GEN9_BC uses the GT Driver Mailbox i/f.
*/
- if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
+ if (IS_GEN9_BC(dev_priv)) {
mutex_lock(&dev_priv->pcu_lock);
ret = sandybridge_pcode_write(dev_priv,
SKL_PCODE_LOAD_HDCP_KEYS, 1);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process
2018-11-27 14:02 ` [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
2018-11-27 15:15 ` Ville Syrjälä
2018-11-28 14:00 ` [PATCH v2 " Ramalingam C
@ 2018-12-03 14:23 ` Sean Paul
2 siblings, 0 replies; 17+ messages in thread
From: Sean Paul @ 2018-12-03 14:23 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
On Tue, Nov 27, 2018 at 07:32:56PM +0530, Ramalingam C wrote:
> HDCP1.4 key load process varies between Intel platform to platform.
>
> For Gen9 platforms except BXT and GLK, HDCP1.4 key is loaded using
> the GT Driver Mailbox interface. Instead of listing all the platforms
> for this method, adopted this method for all Gen9 platforms with
> exceptions. In this way we need not extent check for new GEN9 platforms
> like CFL.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Sean Paul <sean@poorly.run>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 1bf487f94254..beacfbb6e5e1 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -157,10 +157,12 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)
> /*
> * Initiate loading the HDCP key from fuses.
> *
> - * BXT+ platforms, HDCP key needs to be loaded by SW. Only SKL and KBL
> - * differ in the key load trigger process from other platforms.
> + * BXT+ platforms, HDCP key needs to be loaded by SW. Only Gen 9
> + * platforms except BXT and GLK, differ in the key load trigger process
> + * from other platforms.
> */
> - if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
> + if (IS_GEN9(dev_priv) &&
> + (!IS_BROXTON(dev_priv) && !IS_GEMINILAKE(dev_priv))) {
> mutex_lock(&dev_priv->pcu_lock);
> ret = sandybridge_pcode_write(dev_priv,
> SKL_PCODE_LOAD_HDCP_KEYS, 1);
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/4] drm/i915: Fix platform coverage for HDCP1.4
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
2018-11-27 14:02 ` [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
@ 2018-11-27 14:02 ` Ramalingam C
2018-12-03 14:23 ` Sean Paul
2018-11-27 14:02 ` [PATCH 3/4] drm/i915: debug log for REPLY_ACK missing Ramalingam C
` (6 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ramalingam C @ 2018-11-27 14:02 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
HDCP1.4 is enabled and validated only on GEN9+ platforms.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index beacfbb6e5e1..bd60d0e7bbfa 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -770,8 +770,7 @@ static void intel_hdcp_prop_work(struct work_struct *work)
bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
{
/* PORT E doesn't have HDCP, and PORT F is disabled */
- return ((INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) &&
- !IS_CHERRYVIEW(dev_priv) && port < PORT_E);
+ return ((INTEL_GEN(dev_priv) >= 9) && port < PORT_E);
}
int intel_hdcp_init(struct intel_connector *connector,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 2/4] drm/i915: Fix platform coverage for HDCP1.4
2018-11-27 14:02 ` [PATCH 2/4] drm/i915: Fix platform coverage for HDCP1.4 Ramalingam C
@ 2018-12-03 14:23 ` Sean Paul
0 siblings, 0 replies; 17+ messages in thread
From: Sean Paul @ 2018-12-03 14:23 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
On Tue, Nov 27, 2018 at 07:32:57PM +0530, Ramalingam C wrote:
> HDCP1.4 is enabled and validated only on GEN9+ platforms.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Sean Paul <sean@poorly.run>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index beacfbb6e5e1..bd60d0e7bbfa 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -770,8 +770,7 @@ static void intel_hdcp_prop_work(struct work_struct *work)
> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
> {
> /* PORT E doesn't have HDCP, and PORT F is disabled */
> - return ((INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) &&
> - !IS_CHERRYVIEW(dev_priv) && port < PORT_E);
> + return ((INTEL_GEN(dev_priv) >= 9) && port < PORT_E);
> }
>
> int intel_hdcp_init(struct intel_connector *connector,
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/4] drm/i915: debug log for REPLY_ACK missing
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
2018-11-27 14:02 ` [PATCH 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
2018-11-27 14:02 ` [PATCH 2/4] drm/i915: Fix platform coverage for HDCP1.4 Ramalingam C
@ 2018-11-27 14:02 ` Ramalingam C
2018-12-03 14:26 ` Sean Paul
2018-11-27 14:02 ` [PATCH 4/4] drm/i915: Increase timeout for Encrypt status change Ramalingam C
` (5 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ramalingam C @ 2018-11-27 14:02 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
Adding a debug log when the DP_AUX_NATIVE_REPLY_ACK is missing
for aksv write. This helps to locate the possible non responding
DP HDCP sinks.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 70ae3d57316b..18e3a5a3d873 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5390,7 +5390,11 @@ int intel_dp_hdcp_write_an_aksv(struct intel_digital_port *intel_dig_port,
}
reply = (rxbuf[0] >> 4) & DP_AUX_NATIVE_REPLY_MASK;
- return reply == DP_AUX_NATIVE_REPLY_ACK ? 0 : -EIO;
+ ret = reply == DP_AUX_NATIVE_REPLY_ACK ? 0 : -EIO;
+ if (ret)
+ DRM_DEBUG_KMS("Aksv write: DP_AUX_NATIVE_REPLY_ACK missing\n");
+
+ return ret;
}
static int intel_dp_hdcp_read_bksv(struct intel_digital_port *intel_dig_port,
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 3/4] drm/i915: debug log for REPLY_ACK missing
2018-11-27 14:02 ` [PATCH 3/4] drm/i915: debug log for REPLY_ACK missing Ramalingam C
@ 2018-12-03 14:26 ` Sean Paul
0 siblings, 0 replies; 17+ messages in thread
From: Sean Paul @ 2018-12-03 14:26 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
On Tue, Nov 27, 2018 at 07:32:58PM +0530, Ramalingam C wrote:
> Adding a debug log when the DP_AUX_NATIVE_REPLY_ACK is missing
> for aksv write. This helps to locate the possible non responding
> DP HDCP sinks.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 70ae3d57316b..18e3a5a3d873 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5390,7 +5390,11 @@ int intel_dp_hdcp_write_an_aksv(struct intel_digital_port *intel_dig_port,
> }
>
> reply = (rxbuf[0] >> 4) & DP_AUX_NATIVE_REPLY_MASK;
> - return reply == DP_AUX_NATIVE_REPLY_ACK ? 0 : -EIO;
> + ret = reply == DP_AUX_NATIVE_REPLY_ACK ? 0 : -EIO;
> + if (ret)
> + DRM_DEBUG_KMS("Aksv write: DP_AUX_NATIVE_REPLY_ACK missing\n");
This is pretty hard to read. Could you please change to:
if (reply != DP_AUX_NATIVE_REPLY_ACK) {
DRM_DEBUG_KMS("Aksv write: no DP_AUX_NATIVE_REPLY_ACK %x\n",
reply);
return -EIO
}
return 0;
With this change,
Reviewed-by: Sean Paul <sean@poorly.run>
> +
> + return ret;
> }
>
> static int intel_dp_hdcp_read_bksv(struct intel_digital_port *intel_dig_port,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/4] drm/i915: Increase timeout for Encrypt status change
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (2 preceding siblings ...)
2018-11-27 14:02 ` [PATCH 3/4] drm/i915: debug log for REPLY_ACK missing Ramalingam C
@ 2018-11-27 14:02 ` Ramalingam C
2018-12-03 14:27 ` Sean Paul
2018-11-27 14:36 ` ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev8) Patchwork
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ramalingam C @ 2018-11-27 14:02 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
At enable/disable of the HDCP encryption, for encryption status change
we need minimum one frame duration. And we might program this bit any
point(start/End) in the previous frame.
With 20mSec, observed the timeout for change in encryption status.
Since this is not time critical operation and we need to hold on
until the status is changed, fixing the timeout to 50mSec. (Based on
trial and error method!)
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index bd60d0e7bbfa..156b14d19e09 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -15,6 +15,7 @@
#include "i915_reg.h"
#define KEY_LOAD_TRIES 5
+#define TIME_FOR_ENCRYPT_STATUS_CHANGE 50
static
bool intel_hdcp_is_ksv_valid(u8 *ksv)
@@ -638,7 +639,8 @@ static int intel_hdcp_auth(struct intel_digital_port *intel_dig_port,
/* Wait for encryption confirmation */
if (intel_wait_for_register(dev_priv, PORT_HDCP_STATUS(port),
- HDCP_STATUS_ENC, HDCP_STATUS_ENC, 20)) {
+ HDCP_STATUS_ENC, HDCP_STATUS_ENC,
+ TIME_FOR_ENCRYPT_STATUS_CHANGE)) {
DRM_ERROR("Timed out waiting for encryption\n");
return -ETIMEDOUT;
}
@@ -668,7 +670,7 @@ static int _intel_hdcp_disable(struct intel_connector *connector)
I915_WRITE(PORT_HDCP_CONF(port), 0);
if (intel_wait_for_register(dev_priv, PORT_HDCP_STATUS(port), ~0, 0,
- 20)) {
+ TIME_FOR_ENCRYPT_STATUS_CHANGE)) {
DRM_ERROR("Failed to disable HDCP, timeout clearing status\n");
return -ETIMEDOUT;
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 4/4] drm/i915: Increase timeout for Encrypt status change
2018-11-27 14:02 ` [PATCH 4/4] drm/i915: Increase timeout for Encrypt status change Ramalingam C
@ 2018-12-03 14:27 ` Sean Paul
0 siblings, 0 replies; 17+ messages in thread
From: Sean Paul @ 2018-12-03 14:27 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, seanpaul, dri-devel
On Tue, Nov 27, 2018 at 07:32:59PM +0530, Ramalingam C wrote:
> At enable/disable of the HDCP encryption, for encryption status change
> we need minimum one frame duration. And we might program this bit any
> point(start/End) in the previous frame.
>
> With 20mSec, observed the timeout for change in encryption status.
> Since this is not time critical operation and we need to hold on
> until the status is changed, fixing the timeout to 50mSec. (Based on
> trial and error method!)
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index bd60d0e7bbfa..156b14d19e09 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -15,6 +15,7 @@
> #include "i915_reg.h"
>
> #define KEY_LOAD_TRIES 5
> +#define TIME_FOR_ENCRYPT_STATUS_CHANGE 50
ENCRYPT_STATUS_CHANGE_TIMEOUT_MS please
with that fixed,
Reviewed-by: Sean Paul <sean@poorly.run>
>
> static
> bool intel_hdcp_is_ksv_valid(u8 *ksv)
> @@ -638,7 +639,8 @@ static int intel_hdcp_auth(struct intel_digital_port *intel_dig_port,
>
> /* Wait for encryption confirmation */
> if (intel_wait_for_register(dev_priv, PORT_HDCP_STATUS(port),
> - HDCP_STATUS_ENC, HDCP_STATUS_ENC, 20)) {
> + HDCP_STATUS_ENC, HDCP_STATUS_ENC,
> + TIME_FOR_ENCRYPT_STATUS_CHANGE)) {
> DRM_ERROR("Timed out waiting for encryption\n");
> return -ETIMEDOUT;
> }
> @@ -668,7 +670,7 @@ static int _intel_hdcp_disable(struct intel_connector *connector)
>
> I915_WRITE(PORT_HDCP_CONF(port), 0);
> if (intel_wait_for_register(dev_priv, PORT_HDCP_STATUS(port), ~0, 0,
> - 20)) {
> + TIME_FOR_ENCRYPT_STATUS_CHANGE)) {
> DRM_ERROR("Failed to disable HDCP, timeout clearing status\n");
> return -ETIMEDOUT;
> }
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev8)
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (3 preceding siblings ...)
2018-11-27 14:02 ` [PATCH 4/4] drm/i915: Increase timeout for Encrypt status change Ramalingam C
@ 2018-11-27 14:36 ` Patchwork
2018-11-27 17:52 ` ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-11-27 14:36 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: HDCP1.4 fixes (rev8)
URL : https://patchwork.freedesktop.org/series/38978/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5209 -> Patchwork_10912 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/38978/revisions/8/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10912:
=== IGT changes ===
==== Possible regressions ====
igt@kms_chamelium@hdmi-hpd-fast:
{fi-kbl-7500u}: PASS -> FAIL
== Known issues ==
Here are the changes found in Patchwork_10912 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) +1
{igt@runner@aborted}:
{fi-icl-u3}: NOTRUN -> FAIL (fdo#108866 )
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-bsw-n3050: FAIL (fdo#108656) -> PASS
igt@i915_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
==== Warnings ====
igt@i915_selftest@live_contexts:
{fi-icl-u3}: DMESG-FAIL (fdo#108569) -> INCOMPLETE (fdo#108315)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
fdo#108866 https://bugs.freedesktop.org/show_bug.cgi?id=108866
== Participating hosts (51 -> 46) ==
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5209 -> Patchwork_10912
CI_DRM_5209: 945241708e4b83b02f917427f5d65218f3f9a97c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4730: a6b514d242bddd9457f04bb25cde0ddf85032b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10912: d533b873cb4b7cb5bb04e64929bb3ef7dd67856c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d533b873cb4b drm/i915: Increase timeout for Encrypt status change
d40eef87fce1 drm/i915: debug log for REPLY_ACK missing
9a2a55f03145 drm/i915: Fix platform coverage for HDCP1.4
351eb91485c9 drm/i915: Fix GEN9 HDCP1.4 key load process
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10912/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* ✓ Fi.CI.IGT: success for HDCP1.4 fixes (rev8)
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (4 preceding siblings ...)
2018-11-27 14:36 ` ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev8) Patchwork
@ 2018-11-27 17:52 ` Patchwork
2018-11-28 16:10 ` ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev9) Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-11-27 17:52 UTC (permalink / raw)
To: C, Ramalingam; +Cc: intel-gfx
== Series Details ==
Series: HDCP1.4 fixes (rev8)
URL : https://patchwork.freedesktop.org/series/38978/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5209_full -> Patchwork_10912_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10912_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-vebox:
shard-skl: NOTRUN -> FAIL ([fdo#103158])
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-skl: NOTRUN -> TIMEOUT ([fdo#108039])
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: PASS -> INCOMPLETE ([fdo#103665], [fdo#106023], [fdo#106887])
igt@gem_userptr_blits@readonly-unsync:
shard-skl: NOTRUN -> INCOMPLETE ([fdo#108074])
igt@i915_suspend@shrink:
shard-snb: NOTRUN -> DMESG-WARN ([fdo#108784])
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-skl: PASS -> INCOMPLETE ([fdo#104108])
igt@kms_cursor_crc@cursor-128x42-random:
shard-glk: PASS -> FAIL ([fdo#103232]) +1
shard-apl: PASS -> FAIL ([fdo#103232]) +1
igt@kms_fbcon_fbt@fbc-suspend:
shard-skl: PASS -> INCOMPLETE ([fdo#104108], [fdo#107773]) +1
igt@kms_fbcon_fbt@psr:
shard-skl: NOTRUN -> FAIL ([fdo#107882])
igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
shard-glk: PASS -> FAIL ([fdo#103060])
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL ([fdo#105363])
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-skl: NOTRUN -> FAIL ([fdo#103167])
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-apl: PASS -> FAIL ([fdo#103167])
igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
{shard-iclb}: PASS -> FAIL ([fdo#103167]) +1
igt@kms_plane@pixel-format-pipe-c-planes:
shard-apl: PASS -> FAIL ([fdo#103166])
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
shard-skl: PASS -> FAIL ([fdo#103166])
igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
shard-skl: NOTRUN -> FAIL ([fdo#108145])
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-skl: NOTRUN -> FAIL ([fdo#103166], [fdo#107815])
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-glk: PASS -> FAIL ([fdo#103166]) +1
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
{shard-iclb}: PASS -> FAIL ([fdo#103166])
igt@pm_rpm@legacy-planes:
{shard-iclb}: PASS -> INCOMPLETE ([fdo#108840])
==== Possible fixes ====
igt@drm_import_export@import-close-race-flink:
shard-skl: TIMEOUT ([fdo#108667]) -> PASS
igt@gem_ctx_isolation@vcs0-s3:
shard-skl: INCOMPLETE ([fdo#104108], [fdo#107773]) -> PASS
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
shard-glk: FAIL ([fdo#108145]) -> PASS
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-apl: FAIL ([fdo#103232]) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: FAIL ([fdo#103167]) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: FAIL ([fdo#103167], [fdo#105682]) -> PASS
igt@kms_frontbuffer_tracking@fbc-suspend:
shard-skl: INCOMPLETE ([fdo#104108], [fdo#105959], [fdo#107773]) -> PASS
igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
{shard-iclb}: FAIL ([fdo#103167]) -> PASS +3
igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
shard-skl: FAIL ([fdo#103166]) -> PASS
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-apl: FAIL ([fdo#108145]) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
{shard-iclb}: FAIL ([fdo#103166]) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-glk: FAIL ([fdo#103166]) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL ([fdo#99912]) -> PASS
igt@perf_pmu@rc6-runtime-pm-long:
shard-skl: FAIL ([fdo#105010]) -> PASS
==== Warnings ====
igt@kms_content_protection@legacy:
shard-apl: FAIL ([fdo#108597]) -> INCOMPLETE ([fdo#103927])
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108597 https://bugs.freedesktop.org/show_bug.cgi?id=108597
fdo#108667 https://bugs.freedesktop.org/show_bug.cgi?id=108667
fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
fdo#108840 https://bugs.freedesktop.org/show_bug.cgi?id=108840
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (7 -> 7) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5209 -> Patchwork_10912
CI_DRM_5209: 945241708e4b83b02f917427f5d65218f3f9a97c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4730: a6b514d242bddd9457f04bb25cde0ddf85032b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10912: d533b873cb4b7cb5bb04e64929bb3ef7dd67856c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10912/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev9)
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (5 preceding siblings ...)
2018-11-27 17:52 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-11-28 16:10 ` Patchwork
2018-11-29 0:10 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-03 10:08 ` [PATCH 0/4] HDCP1.4 fixes C, Ramalingam
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-11-28 16:10 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: HDCP1.4 fixes (rev9)
URL : https://patchwork.freedesktop.org/series/38978/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5213 -> Patchwork_10932
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/38978/revisions/9/mbox/
Known issues
------------
Here are the changes found in Patchwork_10932 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: PASS -> DMESG-WARN [fdo#102614]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
#### Possible fixes ####
* igt@gem_basic@create-fd-close:
- fi-kbl-7560u: INCOMPLETE -> PASS
* igt@gem_ctx_create@basic-files:
- fi-bsw-n3050: FAIL [fdo#108656] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
Participating hosts (51 -> 44)
------------------------------
Missing (7): fi-kbl-soraka fi-kbl-7567u fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_5213 -> Patchwork_10932
CI_DRM_5213: 5912c54d9804fb15d6a9fa2798bfef1e837c8938 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10932: 660e4c1eb06ea85b63b3365ea6366221e6849ecb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
660e4c1eb06e drm/i915: Increase timeout for Encrypt status change
5aafd4b462a5 drm/i915: debug log for REPLY_ACK missing
6a6338e03553 drm/i915: Fix platform coverage for HDCP1.4
cfb317a66a80 drm/i915: Fix GEN9 HDCP1.4 key load process
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10932/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* ✓ Fi.CI.IGT: success for HDCP1.4 fixes (rev9)
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (6 preceding siblings ...)
2018-11-28 16:10 ` ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev9) Patchwork
@ 2018-11-29 0:10 ` Patchwork
2018-12-03 10:08 ` [PATCH 0/4] HDCP1.4 fixes C, Ramalingam
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-11-29 0:10 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: HDCP1.4 fixes (rev9)
URL : https://patchwork.freedesktop.org/series/38978/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5213_full -> Patchwork_10932_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_10932_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10932_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_10932_full:
### IGT changes ###
#### Warnings ####
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP -> PASS
Known issues
------------
Here are the changes found in Patchwork_10932_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#106887]
* igt@gem_softpin@noreloc-s3:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@i915_suspend@shrink:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#108784]
* igt@kms_available_modes_crc@available_mode_test_crc:
- {shard-iclb}: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
- {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-c-crc-primary-basic:
- {shard-iclb}: NOTRUN -> FAIL [fdo#107725]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-skl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-skl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_flip@flip-vs-fences:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +22
* igt@kms_flip_tiling@flip-to-y-tiled:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +1
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-skl: NOTRUN -> FAIL [fdo#105682] +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- {shard-iclb}: PASS -> DMESG-FAIL [fdo#107724]
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-skl: PASS -> FAIL [fdo#105682]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {shard-iclb}: PASS -> INCOMPLETE [fdo#107713]
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- {shard-iclb}: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]
- shard-skl: NOTRUN -> FAIL [fdo#103166] / [fdo#107815]
* igt@kms_rotation_crc@primary-rotation-180:
- shard-snb: NOTRUN -> FAIL [fdo#103925]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +5
* igt@pm_rpm@basic-rte:
- {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107724] +1
* igt@pm_rpm@modeset-lpsp-stress-no-wait:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
* igt@pm_rpm@universal-planes:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#108654] / [fdo#108756]
* {igt@runner@aborted}:
- {shard-iclb}: NOTRUN -> FAIL [fdo#108756]
#### Possible fixes ####
* igt@drm_import_export@import-close-race-flink:
- shard-skl: TIMEOUT [fdo#108667] -> PASS
* igt@gem_ctx_isolation@vecs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_color@pipe-b-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-glk: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@pipe-c-forked-bo:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +5
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
- shard-skl: FAIL [fdo#107791] -> PASS
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-skl: FAIL [fdo#108472] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- {shard-iclb}: FAIL [fdo#105683] -> PASS +1
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +26
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- {shard-iclb}: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@perf@blocking:
- shard-hsw: FAIL [fdo#102252] -> PASS
* igt@pm_rpm@modeset-non-lpsp:
- shard-skl: INCOMPLETE [fdo#107807] -> SKIP
* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107807] -> PASS
* igt@pm_rpm@universal-planes-dpms:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#106886] -> DMESG-WARN [fdo#108784]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#103166]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#106887]: https://bugs.freedesktop.org/show_bug.cgi?id=106887
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107791]: https://bugs.freedesktop.org/show_bug.cgi?id=107791
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108667]: https://bugs.freedesktop.org/show_bug.cgi?id=108667
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5213 -> Patchwork_10932
CI_DRM_5213: 5912c54d9804fb15d6a9fa2798bfef1e837c8938 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10932: 660e4c1eb06ea85b63b3365ea6366221e6849ecb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10932/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 0/4] HDCP1.4 fixes
2018-11-27 14:02 [PATCH 0/4] HDCP1.4 fixes Ramalingam C
` (7 preceding siblings ...)
2018-11-29 0:10 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-03 10:08 ` C, Ramalingam
8 siblings, 0 replies; 17+ messages in thread
From: C, Ramalingam @ 2018-12-03 10:08 UTC (permalink / raw)
To: intel-gfx, dri-devel, seanpaul, daniel.vetter
[-- Attachment #1.1: Type: text/plain, Size: 680 bytes --]
Sean and Daniel,
Could you please help me with the review these changes?
--Ram
On 11/27/2018 7:32 PM, Ramalingam C wrote:
> Couple of more HDCP1.4 fixes on
> - Key load process for CFL
> - Encryption status change time
> - debug log addition
> - active platform coverage
>
> Ramalingam C (4):
> drm/i915: Fix GEN9 HDCP1.4 key load process
> drm/i915: Fix platform coverage for HDCP1.4
> drm/i915: debug log for REPLY_ACK missing
> drm/i915: Increase timeout for Encrypt status change
>
> drivers/gpu/drm/i915/intel_dp.c | 6 +++++-
> drivers/gpu/drm/i915/intel_hdcp.c | 17 ++++++++++-------
> 2 files changed, 15 insertions(+), 8 deletions(-)
>
[-- Attachment #1.2: Type: text/html, Size: 1036 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread