* [Qemu-devel] [PATCH] configure: fix elf2dmp check
@ 2018-11-23 9:01 Roman Kagan
2018-11-23 9:55 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Roman Kagan @ 2018-11-23 9:01 UTC (permalink / raw)
To: qemu-devel, Viktor Prutyanov; +Cc: Paolo Bonzini
elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
set anywhere.
The original intent was presumably to skip building it on Windows, so
check for "$mingw32" = "no" instead.
Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 0a3c6a72c3..fc6ce0065d 100755
--- a/configure
+++ b/configure
@@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
if [ "$ivshmem" = "yes" ]; then
tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
fi
- if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
+ if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
tools="elf2dmp $tools"
fi
fi
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
2018-11-23 9:01 [Qemu-devel] [PATCH] configure: fix elf2dmp check Roman Kagan
@ 2018-11-23 9:55 ` Philippe Mathieu-Daudé
2018-11-23 16:34 ` Paolo Bonzini
2018-11-27 18:50 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-23 9:55 UTC (permalink / raw)
To: Roman Kagan, qemu-devel, Viktor Prutyanov; +Cc: Paolo Bonzini
On 23/11/18 10:01, Roman Kagan wrote:
> elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> set anywhere.
>
> The original intent was presumably to skip building it on Windows, so
> check for "$mingw32" = "no" instead.
>
> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0a3c6a72c3..fc6ce0065d 100755
> --- a/configure
> +++ b/configure
> @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> if [ "$ivshmem" = "yes" ]; then
> tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> fi
> - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> tools="elf2dmp $tools"
> fi
> fi
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
2018-11-23 9:01 [Qemu-devel] [PATCH] configure: fix elf2dmp check Roman Kagan
2018-11-23 9:55 ` Philippe Mathieu-Daudé
@ 2018-11-23 16:34 ` Paolo Bonzini
2018-11-27 18:50 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2018-11-23 16:34 UTC (permalink / raw)
To: Roman Kagan, qemu-devel, Viktor Prutyanov
On 23/11/18 10:01, Roman Kagan wrote:
> elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> set anywhere.
>
> The original intent was presumably to skip building it on Windows, so
> check for "$mingw32" = "no" instead.
>
> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0a3c6a72c3..fc6ce0065d 100755
> --- a/configure
> +++ b/configure
> @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> if [ "$ivshmem" = "yes" ]; then
> tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> fi
> - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> tools="elf2dmp $tools"
> fi
> fi
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
2018-11-23 9:01 [Qemu-devel] [PATCH] configure: fix elf2dmp check Roman Kagan
2018-11-23 9:55 ` Philippe Mathieu-Daudé
2018-11-23 16:34 ` Paolo Bonzini
@ 2018-11-27 18:50 ` Paolo Bonzini
2018-11-27 19:31 ` Roman Kagan
2 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2018-11-27 18:50 UTC (permalink / raw)
To: Roman Kagan, qemu-devel, Viktor Prutyanov
On 23/11/18 10:01, Roman Kagan wrote:
> elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> set anywhere.
>
> The original intent was presumably to skip building it on Windows, so
> check for "$mingw32" = "no" instead.
>
> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0a3c6a72c3..fc6ce0065d 100755
> --- a/configure
> +++ b/configure
> @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> if [ "$ivshmem" = "yes" ]; then
> tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> fi
> - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> tools="elf2dmp $tools"
> fi
> fi
>
Unfortunately this shows that elf2dmp is not portable to 32-bit systems,
nor to non-Linux. Can this be fixed?
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check
2018-11-27 18:50 ` Paolo Bonzini
@ 2018-11-27 19:31 ` Roman Kagan
0 siblings, 0 replies; 5+ messages in thread
From: Roman Kagan @ 2018-11-27 19:31 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Viktor Prutyanov
On Tue, Nov 27, 2018 at 07:50:54PM +0100, Paolo Bonzini wrote:
> On 23/11/18 10:01, Roman Kagan wrote:
> > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> > set anywhere.
> >
> > The original intent was presumably to skip building it on Windows, so
> > check for "$mingw32" = "no" instead.
> >
> > Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 0a3c6a72c3..fc6ce0065d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5722,7 +5722,7 @@ if test "$want_tools" = "yes" ; then
> > if [ "$ivshmem" = "yes" ]; then
> > tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
> > fi
> > - if [ "$posix" = "yes" ] && [ "$curl" = "yes" ]; then
> > + if [ "$mingw32" = "no" ] && [ "$curl" = "yes" ]; then
> > tools="elf2dmp $tools"
> > fi
> > fi
> >
>
> Unfortunately this shows that elf2dmp is not portable to 32-bit systems,
> nor to non-Linux. Can this be fixed?
I'm sure it can, but not in time for 3.2. I'd rather drop this patch
for now and leave the tool disabled in 3.2.
[ FWIW the format specifier mismatches were addressed by Viktor's
patchset of some three weeks ago, "[PATCH 0/2] contrib/elf2dmp: elf2dmp
for Windows hosts", but it hasn't made it yet. ]
/me is wondering why patchew didn't scream at me for breaking 32-bit
builds. In the meantime I'll be setting up docker for testing 32-bit
builds locally.
Roman.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-27 19:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23 9:01 [Qemu-devel] [PATCH] configure: fix elf2dmp check Roman Kagan
2018-11-23 9:55 ` Philippe Mathieu-Daudé
2018-11-23 16:34 ` Paolo Bonzini
2018-11-27 18:50 ` Paolo Bonzini
2018-11-27 19:31 ` Roman Kagan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.