[PATCH] drm/i915/ringbuffer: Clear semaphore sync registers on ring init

[PATCH] drm/i915/ringbuffer: Clear semaphore sync registers on ring init

[Chris Wilson]

Ensure that the sync registers are cleared every time we restart the
ring to avoid stale values from creeping in from random neutrinos.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e18a64d41843..82c844488755 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -529,6 +529,13 @@ static int init_ring_common(struct intel_engine_cs *engine)
 
 	intel_engine_reset_breadcrumbs(engine);
 
+	if (HAS_LEGACY_SEMAPHORES(engine->i915)) {
+		I915_WRITE(RING_SYNC_0(engine->mmio_base), 0);
+		I915_WRITE(RING_SYNC_1(engine->mmio_base), 0);
+		if (HAS_VEBOX(dev_priv))
+			I915_WRITE(RING_SYNC_2(engine->mmio_base), 0);
+	}
+
 	/* Enforce ordering by reading HEAD register back */
 	I915_READ_HEAD(engine);
 
-- 
2.20.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/ringbuffer: Clear semaphore sync registers on ring init

[Patchwork]

== Series Details ==

Series: drm/i915/ringbuffer: Clear semaphore sync registers on ring init
URL   : https://patchwork.freedesktop.org/series/53112/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5212 -> Patchwork_10922 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53112/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10922 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-ivb-3520m:       PASS -> FAIL ([fdo#108880])

    igt@i915_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL ([fdo#107164])

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      PASS -> DMESG-WARN ([fdo#105998])

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL ([fdo#103167])

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL ([fdo#103191], [fdo#107362])

    
    ==== Possible fixes ====

    igt@gem_ctx_create@basic-files:
      fi-bsw-n3050:       DMESG-FAIL ([fdo#108656]) -> PASS

    igt@kms_chamelium@hdmi-hpd-fast:
      {fi-kbl-7500u}:     FAIL -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
  fdo#108880 https://bugs.freedesktop.org/show_bug.cgi?id=108880


== Participating hosts (51 -> 45) ==

  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_5212 -> Patchwork_10922

  CI_DRM_5212: db8d567e7cf70aeca866e85972078cd5c9b59cfb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4734: 0a961239c27bfbd60c045e6255b2970d4bf84411 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10922: 280b224f42bc6c4b744c3317065a5cc0635e28b6 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

280b224f42bc drm/i915/ringbuffer: Clear semaphore sync registers on ring init

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10922/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915/ringbuffer: Clear semaphore sync registers on ring init

[Patchwork]

== Series Details ==

Series: drm/i915/ringbuffer: Clear semaphore sync registers on ring init
URL   : https://patchwork.freedesktop.org/series/53112/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5212_full -> Patchwork_10922_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_10922_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10922_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10922_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_10922_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_userptr_blits@readonly-unsync:
      shard-skl:          PASS -> INCOMPLETE ([fdo#108074])

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
      shard-snb:          PASS -> DMESG-WARN ([fdo#107956])

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-glk:          NOTRUN -> DMESG-WARN ([fdo#107956]) +1

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-glk:          PASS -> FAIL ([fdo#103232]) +2

    igt@kms_cursor_crc@cursor-64x64-onscreen:
      shard-apl:          PASS -> FAIL ([fdo#103232]) +1

    igt@kms_fbcon_fbt@psr:
      shard-skl:          NOTRUN -> FAIL ([fdo#107882])

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-skl:          PASS -> FAIL ([fdo#105363])

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
      {shard-iclb}:       PASS -> DMESG-FAIL ([fdo#107720], [fdo#107724])

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-apl:          PASS -> FAIL ([fdo#103167])

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
      shard-glk:          PASS -> FAIL ([fdo#103167])

    igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
      {shard-iclb}:       PASS -> DMESG-FAIL ([fdo#107724]) +2

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
      {shard-iclb}:       NOTRUN -> FAIL ([fdo#103167])

    igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
      {shard-iclb}:       PASS -> DMESG-WARN ([fdo#107724], [fdo#108336]) +12

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      shard-skl:          PASS -> INCOMPLETE ([fdo#104108], [fdo#107773])

    igt@kms_plane@pixel-format-pipe-c-planes:
      shard-apl:          PASS -> FAIL ([fdo#103166]) +2

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
      {shard-iclb}:       PASS -> DMESG-FAIL ([fdo#103166], [fdo#107724])

    igt@kms_plane@plane-position-covered-pipe-c-planes:
      shard-glk:          PASS -> FAIL ([fdo#103166]) +2

    igt@kms_vblank@pipe-a-ts-continuation-idle:
      {shard-iclb}:       PASS -> DMESG-WARN ([fdo#107724]) +18

    igt@kms_vblank@pipe-b-ts-continuation-suspend:
      shard-kbl:          PASS -> INCOMPLETE ([fdo#103665])

    igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
      shard-skl:          PASS -> INCOMPLETE ([fdo#104108])

    igt@pm_rpm@dpms-non-lpsp:
      shard-skl:          SKIP -> INCOMPLETE ([fdo#107807]) +1

    igt@pm_rpm@sysfs-read:
      shard-skl:          PASS -> INCOMPLETE ([fdo#107807])

    
    ==== Possible fixes ====

    igt@i915_suspend@fence-restore-untiled:
      shard-glk:          INCOMPLETE ([fdo#103359], [k.org#198133]) -> PASS

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      shard-glk:          FAIL ([fdo#108145]) -> PASS +1

    igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
      shard-skl:          FAIL ([fdo#104671]) -> PASS

    igt@kms_color@pipe-b-ctm-green-to-red:
      shard-skl:          FAIL ([fdo#107201]) -> PASS

    igt@kms_cursor_crc@cursor-256x256-dpms:
      shard-apl:          FAIL ([fdo#103232]) -> PASS

    igt@kms_cursor_crc@cursor-256x256-offscreen:
      shard-skl:          FAIL ([fdo#103232]) -> PASS

    igt@kms_cursor_crc@cursor-64x64-onscreen:
      shard-glk:          FAIL ([fdo#103232]) -> PASS

    igt@kms_cursor_legacy@flip-vs-cursor-legacy:
      shard-glk:          FAIL ([fdo#102670]) -> PASS

    igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
      {shard-iclb}:       WARN ([fdo#108336]) -> PASS +3

    igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled:
      shard-skl:          FAIL ([fdo#107791]) -> PASS

    igt@kms_draw_crc@fill-fb:
      shard-skl:          FAIL ([fdo#103184]) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-apl:          INCOMPLETE ([fdo#103927]) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
      shard-skl:          FAIL ([fdo#105682]) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
      shard-skl:          FAIL ([fdo#103167]) -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-apl:          FAIL ([fdo#103167]) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          FAIL ([fdo#103167]) -> PASS +3

    igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
      {shard-iclb}:       DMESG-FAIL ([fdo#107724]) -> PASS +3

    igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
      {shard-iclb}:       FAIL ([fdo#103167]) -> PASS +4

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      shard-skl:          FAIL ([fdo#107362]) -> PASS

    igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
      shard-skl:          FAIL ([fdo#107815], [fdo#108145]) -> PASS

    igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
      shard-skl:          FAIL ([fdo#107815]) -> PASS

    igt@kms_plane_lowres@pipe-c-tiling-none:
      {shard-iclb}:       DMESG-WARN ([fdo#107724], [fdo#108336]) -> PASS +6

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-apl:          FAIL ([fdo#103166]) -> PASS +1

    igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
      {shard-iclb}:       FAIL ([fdo#103166]) -> PASS +2

    igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
      shard-glk:          FAIL ([fdo#103166]) -> PASS

    igt@kms_vblank@pipe-c-wait-forked-hang:
      {shard-iclb}:       DMESG-WARN ([fdo#107724]) -> PASS +11

    igt@pm_rpm@system-suspend-execbuf:
      {shard-iclb}:       INCOMPLETE ([fdo#107713], [fdo#108840]) -> PASS

    
    ==== Warnings ====

    igt@i915_suspend@shrink:
      shard-apl:          DMESG-WARN ([fdo#108784]) -> INCOMPLETE ([fdo#103927], [fdo#106886])

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      {shard-iclb}:       DMESG-WARN ([fdo#107724], [fdo#108336]) -> FAIL ([fdo#107725])

    igt@kms_cursor_crc@cursor-128x128-suspend:
      {shard-iclb}:       DMESG-FAIL ([fdo#103232], [fdo#107724]) -> FAIL ([fdo#103232])

    igt@kms_cursor_crc@cursor-256x256-onscreen:
      {shard-iclb}:       DMESG-WARN ([fdo#107724], [fdo#108336]) -> FAIL ([fdo#103232])

    igt@kms_cursor_crc@cursor-256x85-sliding:
      {shard-iclb}:       FAIL ([fdo#103232]) -> DMESG-WARN ([fdo#107724], [fdo#108336]) +1

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107201 https://bugs.freedesktop.org/show_bug.cgi?id=107201
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
  fdo#107720 https://bugs.freedesktop.org/show_bug.cgi?id=107720
  fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
  fdo#107725 https://bugs.freedesktop.org/show_bug.cgi?id=107725
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
  fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108336 https://bugs.freedesktop.org/show_bug.cgi?id=108336
  fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
  fdo#108840 https://bugs.freedesktop.org/show_bug.cgi?id=108840
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (7 -> 7) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_5212 -> Patchwork_10922

  CI_DRM_5212: db8d567e7cf70aeca866e85972078cd5c9b59cfb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4734: 0a961239c27bfbd60c045e6255b2970d4bf84411 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10922: 280b224f42bc6c4b744c3317065a5cc0635e28b6 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10922/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx