* [PATCH] xen/x86: fix paging_max_paddr_bits()
@ 2018-11-28 7:52 Juergen Gross
2018-11-28 8:41 ` Roger Pau Monné
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2018-11-28 7:52 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, andrew.cooper3, wei.liu2, jbeulich, roger.pau
paging_max_paddr_bits() has an invalid use of IS_ENABLED(): instead of
IS_ENABLED(CONFIG_BIGMEM) it is using IS_ENABLED(BIGMEM). Fix that.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/include/asm-x86/paging.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/include/asm-x86/paging.h b/xen/include/asm-x86/paging.h
index dd0d6b5159..fdcc22844b 100644
--- a/xen/include/asm-x86/paging.h
+++ b/xen/include/asm-x86/paging.h
@@ -371,7 +371,8 @@ static inline unsigned int paging_max_paddr_bits(const struct domain *d)
{
unsigned int bits = paging_mode_hap(d) ? hap_paddr_bits : paddr_bits;
- if ( !IS_ENABLED(BIGMEM) && paging_mode_shadow(d) && !is_pv_domain(d) )
+ if ( !IS_ENABLED(CONFIG_BIGMEM) && paging_mode_shadow(d) &&
+ !is_pv_domain(d) )
{
/* Shadowed superpages store GFNs in 32-bit page_info fields. */
bits = min(bits, 32U + PAGE_SHIFT);
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/x86: fix paging_max_paddr_bits()
2018-11-28 7:52 [PATCH] xen/x86: fix paging_max_paddr_bits() Juergen Gross
@ 2018-11-28 8:41 ` Roger Pau Monné
2018-11-28 12:55 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monné @ 2018-11-28 8:41 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, wei.liu2, jbeulich, andrew.cooper3
On Wed, Nov 28, 2018 at 08:52:24AM +0100, Juergen Gross wrote:
> paging_max_paddr_bits() has an invalid use of IS_ENABLED(): instead of
> IS_ENABLED(CONFIG_BIGMEM) it is using IS_ENABLED(BIGMEM). Fix that.
>
> Signed-off-by: Juergen Gross <jgross@suse.como>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/x86: fix paging_max_paddr_bits()
2018-11-28 8:41 ` Roger Pau Monné
@ 2018-11-28 12:55 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2018-11-28 12:55 UTC (permalink / raw)
To: Juergen Gross; +Cc: Andrew Cooper, Wei Liu, xen-devel, Roger Pau Monne
>>> On 28.11.18 at 09:41, <roger.pau@citrix.com> wrote:
> On Wed, Nov 28, 2018 at 08:52:24AM +0100, Juergen Gross wrote:
>> paging_max_paddr_bits() has an invalid use of IS_ENABLED(): instead of
>> IS_ENABLED(CONFIG_BIGMEM) it is using IS_ENABLED(BIGMEM). Fix that.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.como>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-28 12:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 7:52 [PATCH] xen/x86: fix paging_max_paddr_bits() Juergen Gross
2018-11-28 8:41 ` Roger Pau Monné
2018-11-28 12:55 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.