* [PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'
@ 2018-11-28 12:31 YueHaibing
2018-11-28 19:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-28 12:31 UTC (permalink / raw)
To: davem, subashab; +Cc: linux-kernel, netdev, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:26:6:
warning: variable 'ip_family' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:27:6:
warning: variable 'fc_seq' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:28:6:
warning: variable 'qos_id' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
index 3ee8ae9..8990307 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
@@ -23,9 +23,6 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
struct rmnet_map_control_command *cmd;
struct rmnet_endpoint *ep;
struct net_device *vnd;
- u16 ip_family;
- u16 fc_seq;
- u32 qos_id;
u8 mux_id;
int r;
@@ -45,10 +42,6 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
vnd = ep->egress_dev;
- ip_family = cmd->flow_control.ip_family;
- fc_seq = ntohs(cmd->flow_control.flow_control_seq_num);
- qos_id = ntohl(cmd->flow_control.qos_id);
-
/* Ignore the ip family and pass the sequence number for both v4 and v6
* sequence. User space does not support creating dedicated flows for
* the 2 protocols
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'
2018-11-28 12:31 [PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id' YueHaibing
@ 2018-11-28 19:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-11-28 19:10 UTC (permalink / raw)
To: yuehaibing; +Cc: subashab, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 28 Nov 2018 20:31:42 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:26:6:
> warning: variable 'ip_family' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:27:6:
> warning: variable 'fc_seq' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:28:6:
> warning: variable 'qos_id' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-28 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 12:31 [PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id' YueHaibing
2018-11-28 19:10 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.