* [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
@ 2018-11-29 15:52 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 15:52 UTC (permalink / raw)
To: dri-devel
Cc: Sean Paul, Daniel Vetter, Maarten Lankhorst, Maxime Ripard,
Sean Paul, David Airlie, linux-doc
From: Sean Paul <seanpaul@chromium.org>
We should also get the drivers using the helpers. Seems like a good
intermediate TODO item.
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
Documentation/gpu/todo.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ab347dec50796..1a6dc586fb156 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -241,6 +241,18 @@ struct drm_gem_object_funcs
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
+Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
+---------------------------------------------------------
+
+For cases where drivers are attempting to grab the modeset locks with a local
+acquire context. Replace the boilerplate code surrounding
+drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
+DRM_MODESET_LOCK_ALL_END() instead.
+
+As a reference, take a look at the conversions already completed in drm core.
+
+Contact: Sean Paul, respective driver maintainers
+
Core refactorings
=================
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
@ 2018-11-29 15:52 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 15:52 UTC (permalink / raw)
To: dri-devel; +Cc: linux-doc, Maxime Ripard, David Airlie, Sean Paul, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
We should also get the drivers using the helpers. Seems like a good
intermediate TODO item.
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
Documentation/gpu/todo.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ab347dec50796..1a6dc586fb156 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -241,6 +241,18 @@ struct drm_gem_object_funcs
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
+Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
+---------------------------------------------------------
+
+For cases where drivers are attempting to grab the modeset locks with a local
+acquire context. Replace the boilerplate code surrounding
+drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
+DRM_MODESET_LOCK_ALL_END() instead.
+
+As a reference, take a look at the conversions already completed in drm core.
+
+Contact: Sean Paul, respective driver maintainers
+
Core refactorings
=================
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
2018-11-29 15:52 ` Sean Paul
@ 2018-11-29 16:46 ` Daniel Vetter
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2018-11-29 16:46 UTC (permalink / raw)
To: Sean Paul
Cc: dri-devel, Sean Paul, Daniel Vetter, Maarten Lankhorst,
Maxime Ripard, David Airlie, linux-doc
On Thu, Nov 29, 2018 at 10:52:40AM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> We should also get the drivers using the helpers. Seems like a good
> intermediate TODO item.
>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> Documentation/gpu/todo.rst | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ab347dec50796..1a6dc586fb156 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -241,6 +241,18 @@ struct drm_gem_object_funcs
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
>
> +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
> +---------------------------------------------------------
> +
> +For cases where drivers are attempting to grab the modeset locks with a local
> +acquire context. Replace the boilerplate code surrounding
> +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
> +DRM_MODESET_LOCK_ALL_END() instead.
Maybe add:
"This should also be done for all places where drm_modest_lock_all() is
still used."
Cheers, Daniel
> +
> +As a reference, take a look at the conversions already completed in drm core.
> +
> +Contact: Sean Paul, respective driver maintainers
> +
> Core refactorings
> =================
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
@ 2018-11-29 16:46 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2018-11-29 16:46 UTC (permalink / raw)
To: Sean Paul; +Cc: linux-doc, Maxime Ripard, dri-devel, David Airlie, Sean Paul
On Thu, Nov 29, 2018 at 10:52:40AM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> We should also get the drivers using the helpers. Seems like a good
> intermediate TODO item.
>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> Documentation/gpu/todo.rst | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ab347dec50796..1a6dc586fb156 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -241,6 +241,18 @@ struct drm_gem_object_funcs
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
>
> +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
> +---------------------------------------------------------
> +
> +For cases where drivers are attempting to grab the modeset locks with a local
> +acquire context. Replace the boilerplate code surrounding
> +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
> +DRM_MODESET_LOCK_ALL_END() instead.
Maybe add:
"This should also be done for all places where drm_modest_lock_all() is
still used."
Cheers, Daniel
> +
> +As a reference, take a look at the conversions already completed in drm core.
> +
> +Contact: Sean Paul, respective driver maintainers
> +
> Core refactorings
> =================
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
2018-11-29 16:46 ` Daniel Vetter
@ 2018-11-29 19:58 ` Sean Paul
-1 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 19:58 UTC (permalink / raw)
To: dri-devel
Cc: Sean Paul, Daniel Vetter, David Airlie, Maarten Lankhorst,
Maxime Ripard, Sean Paul, Jonathan Corbet, linux-doc
From: Sean Paul <seanpaul@chromium.org>
We should also get the drivers using the helpers. Seems like a good
intermediate TODO item.
Changes in v2:
- Add line about replacing drm_modest_lock_all() (Daniel)
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
Documentation/gpu/todo.rst | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ab347dec50796..14191b64446df 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -241,6 +241,21 @@ struct drm_gem_object_funcs
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
+Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
+---------------------------------------------------------
+
+For cases where drivers are attempting to grab the modeset locks with a local
+acquire context. Replace the boilerplate code surrounding
+drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
+DRM_MODESET_LOCK_ALL_END() instead.
+
+This should also be done for all places where drm_modest_lock_all() is still
+used.
+
+As a reference, take a look at the conversions already completed in drm core.
+
+Contact: Sean Paul, respective driver maintainers
+
Core refactorings
=================
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
@ 2018-11-29 19:58 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 19:58 UTC (permalink / raw)
To: dri-devel
Cc: Jonathan Corbet, David Airlie, Daniel Vetter, linux-doc,
Maxime Ripard, Sean Paul, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
We should also get the drivers using the helpers. Seems like a good
intermediate TODO item.
Changes in v2:
- Add line about replacing drm_modest_lock_all() (Daniel)
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
Documentation/gpu/todo.rst | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ab347dec50796..14191b64446df 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -241,6 +241,21 @@ struct drm_gem_object_funcs
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
+Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
+---------------------------------------------------------
+
+For cases where drivers are attempting to grab the modeset locks with a local
+acquire context. Replace the boilerplate code surrounding
+drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
+DRM_MODESET_LOCK_ALL_END() instead.
+
+This should also be done for all places where drm_modest_lock_all() is still
+used.
+
+As a reference, take a look at the conversions already completed in drm core.
+
+Contact: Sean Paul, respective driver maintainers
+
Core refactorings
=================
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
2018-11-29 19:58 ` Sean Paul
@ 2018-11-29 20:30 ` Sean Paul
-1 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 20:30 UTC (permalink / raw)
To: dri-devel
Cc: Sean Paul, Daniel Vetter, David Airlie, Maarten Lankhorst,
Maxime Ripard, Sean Paul, Jonathan Corbet, linux-doc
On Thu, Nov 29, 2018 at 02:58:33PM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> We should also get the drivers using the helpers. Seems like a good
> intermediate TODO item.
>
> Changes in v2:
> - Add line about replacing drm_modest_lock_all() (Daniel)
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed this to -misc-next
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> Documentation/gpu/todo.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ab347dec50796..14191b64446df 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -241,6 +241,21 @@ struct drm_gem_object_funcs
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
>
> +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
> +---------------------------------------------------------
> +
> +For cases where drivers are attempting to grab the modeset locks with a local
> +acquire context. Replace the boilerplate code surrounding
> +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
> +DRM_MODESET_LOCK_ALL_END() instead.
> +
> +This should also be done for all places where drm_modest_lock_all() is still
> +used.
> +
> +As a reference, take a look at the conversions already completed in drm core.
> +
> +Contact: Sean Paul, respective driver maintainers
> +
> Core refactorings
> =================
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst
@ 2018-11-29 20:30 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2018-11-29 20:30 UTC (permalink / raw)
To: dri-devel
Cc: Jonathan Corbet, David Airlie, Daniel Vetter, linux-doc,
Maxime Ripard, Sean Paul, Sean Paul
On Thu, Nov 29, 2018 at 02:58:33PM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> We should also get the drivers using the helpers. Seems like a good
> intermediate TODO item.
>
> Changes in v2:
> - Add line about replacing drm_modest_lock_all() (Daniel)
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed this to -misc-next
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> Documentation/gpu/todo.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ab347dec50796..14191b64446df 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -241,6 +241,21 @@ struct drm_gem_object_funcs
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
>
> +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
> +---------------------------------------------------------
> +
> +For cases where drivers are attempting to grab the modeset locks with a local
> +acquire context. Replace the boilerplate code surrounding
> +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
> +DRM_MODESET_LOCK_ALL_END() instead.
> +
> +This should also be done for all places where drm_modest_lock_all() is still
> +used.
> +
> +As a reference, take a look at the conversions already completed in drm core.
> +
> +Contact: Sean Paul, respective driver maintainers
> +
> Core refactorings
> =================
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-29 20:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 15:52 [PATCH] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst Sean Paul
2018-11-29 15:52 ` Sean Paul
2018-11-29 16:46 ` Daniel Vetter
2018-11-29 16:46 ` Daniel Vetter
2018-11-29 19:58 ` [PATCH v2] " Sean Paul
2018-11-29 19:58 ` Sean Paul
2018-11-29 20:30 ` Sean Paul
2018-11-29 20:30 ` Sean Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.